Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-02 20:54:50 -04:00
Code Issues Projects Releases Packages Wiki Activity

Check logcontexts before and after each test (#4190)

Browse source 
* Add better diagnostics to flakey keyring test

* fix interpolation fail

* Check logcontexts before and after each test

* update changelog

* update changelog
This commit is contained in:
Richard van der Hoff 2018-11-27 03:47:18 +01:00 • committed by Amber Brown
parent 80527b568d
commit a44c0a096f
3 changed files with 22 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/unittest.py
View file

@ -102,8 +102,16 @@ class TestCase(unittest.TestCase):
# traceback when a unit test exits leaving things on the reactor.
twisted.internet.base.DelayedCall.debug = True
old_level = logging.getLogger().level
# if we're not starting in the sentinel logcontext, then to be honest
# all future bets are off.
if LoggingContext.current_context() is not LoggingContext.sentinel:
self.fail(
"Test starting with non-sentinel logging context %s" % (
LoggingContext.current_context(),
)
)
old_level = logging.getLogger().level
if old_level != level:
@around(self)
@ -118,7 +126,6 @@ class TestCase(unittest.TestCase):
@around(self)
def tearDown(orig):
ret = orig()
# force a GC to workaround problems with deferreds leaking logcontexts when
# they are GCed (see the logcontext docs)
gc.collect()