Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-06-12 22:02:53 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fail with a coherent error message if /sync?filter= is invalid

Browse source
This commit is contained in:
Kegan Dougal 2016-11-21 13:13:55 +00:00
parent dc6cede78e
commit a2a6c1c22f
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
synapse/storage/filtering.py
View file

@ -16,6 +16,7 @@
from twisted.internet import defer
from ._base import SQLBaseStore
from synapse.api.errors import SynapseError, Codes
from synapse.util.caches.descriptors import cachedInlineCallbacks
import simplejson as json
@ -24,6 +25,13 @@ import simplejson as json
class FilteringStore(SQLBaseStore):
@cachedInlineCallbacks(num_args=2)
def get_user_filter(self, user_localpart, filter_id):
# filter_id is BIGINT UNSIGNED, so if it isn't a number, fail
# with a coherent error message rather than 500 M_UNKNOWN.
try:
int(filter_id)
except ValueError:
raise SynapseError(400, "Invalid filter ID", Codes.INVALID_PARAM)
def_json = yield self._simple_select_one_onecol(
table="user_filters",
keyvalues={