Enforce ascii filenames for uploads

This commit is contained in:
Erik Johnston 2015-06-30 10:31:59 +01:00
parent 2124f668db
commit 9beaedd164
3 changed files with 15 additions and 1 deletions

View file

@ -15,7 +15,7 @@
from synapse.http.server import respond_with_json, request_handler
from synapse.util.stringutils import random_string
from synapse.util.stringutils import random_string, is_ascii
from synapse.api.errors import SynapseError
from twisted.web.server import NOT_DONE_YET
@ -87,6 +87,8 @@ class UploadResource(BaseMediaResource):
upload_name = request.args.get("filename", None)
if upload_name:
upload_name = upload_name[0]
if upload_name and not is_ascii(upload_name):
raise SynapseError(400, "filename must be ascii")
headers = request.requestHeaders