Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2024-12-26 15:19:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1070 from matrix-org/erikj/presence_stats

Browse Source 
Record why we have chosen to notify
This commit is contained in:
Erik Johnston 2016-09-05 15:01:30 +01:00 committed by GitHub
commit 8c93e0bae7
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
synapse/handlers/presence.py
View File

@ -52,6 +52,8 @@ bump_active_time_counter = metrics.register_counter("bump_active_time")
get_updates_counter = metrics.register_counter("get_updates", labels=["type"])
notify_reason_counter = metrics.register_counter("notify_reason", labels=["reason"])
# If a user was last active in the last LAST_ACTIVE_GRANULARITY, consider them
# "currently_active"
@ -940,26 +942,32 @@ def should_notify(old_state, new_state):
"""Decides if a presence state change should be sent to interested parties.
"""
if old_state.status_msg != new_state.status_msg:
notify_reason_counter.inc("status_msg_change")
return True
if old_state.state == PresenceState.ONLINE:
if new_state.state != PresenceState.ONLINE:
# Always notify for online -> anything
notify_reason_counter.inc("online_to_not")
return True
if new_state.currently_active != old_state.currently_active:
notify_reason_counter.inc("current_active_change")
return True
if new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
# Only notify about last active bumps if we're not currently acive
if not (old_state.currently_active and new_state.currently_active):
notify_reason_counter.inc("last_active_change")
return True
elif new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
# Always notify for a transition where last active gets bumped.
notify_reason_counter.inc("last_active_change")
return True
if old_state.state != new_state.state:
notify_reason_counter.inc("state_change")
return True
return False