Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-03 00:54:47 -04:00
Code Issues Projects Releases Packages Wiki Activity

Factor out msisdn canonicalisation

Browse source 
Plus a couple of other minor fixes
This commit is contained in:
David Baker 2017-03-08 11:03:39 +00:00
parent 402a7bf63d
commit 88df6c0c9a
4 changed files with 11 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

21
synapse/rest/client/v2_alpha/account.py
View file

@ -20,13 +20,12 @@ from synapse.api.constants import LoginType
from synapse.api.errors import LoginError, SynapseError, Codes
from synapse.http.servlet import RestServlet, parse_json_object_from_request
from synapse.util.async import run_on_reactor
from synapse.util.msisdn import phone_number_to_msisdn
from ._base import client_v2_patterns
import logging
import phonenumbers
logger = logging.getLogger(__name__)
@ -87,14 +86,7 @@ class MsisdnPasswordRequestTokenRestServlet(RestServlet):
if absent:
raise SynapseError(400, "Missing params: %r" % absent, Codes.MISSING_PARAM)
phoneNumber = None
try:
phoneNumber = phonenumbers.parse(body['phone_number'], body['country'])
except phonenumbers.NumberParseException:
raise SynapseError(400, "Unable to parse phone number")
msisdn = phonenumbers.format_number(
phoneNumber, phonenumbers.PhoneNumberFormat.E164
)[1:]
msisdn = phone_number_to_msisdn(body['country'], body['phone_number'])
existingUid = yield self.hs.get_datastore().get_user_id_by_threepid(
'msisdn', msisdn
@ -273,14 +265,7 @@ class MsisdnThreepidRequestTokenRestServlet(RestServlet):
if absent:
raise SynapseError(400, "Missing params: %r" % absent, Codes.MISSING_PARAM)
phoneNumber = None
try:
phoneNumber = phonenumbers.parse(body['phone_number'], body['country'])
except phonenumbers.NumberParseException:
raise SynapseError(400, "Unable to parse phone number")
msisdn = phonenumbers.format_number(
phoneNumber, phonenumbers.PhoneNumberFormat.E164
)[1:]
msisdn = phone_number_to_msisdn(body['country'], body['phone_number'])
existingUid = yield self.hs.get_datastore().get_user_id_by_threepid(
'msisdn', msisdn