Move Measure calls into resolve_events_with_store

This commit is contained in:
Richard van der Hoff 2020-09-29 13:07:09 +01:00
parent ba700074c6
commit 8412c08a87

View File

@ -448,7 +448,6 @@ class StateHandler:
state_map = {ev.event_id: ev for st in state_sets for ev in st}
with Measure(self.clock, "state._resolve_events"):
new_state = await self._state_resolution_handler.resolve_events_with_store(
event.room_id,
room_version,
@ -529,7 +528,6 @@ class StateResolutionHandler:
state_groups_histogram.observe(len(state_groups_ids))
with Measure(self.clock, "state._resolve_events"):
new_state = await self.resolve_events_with_store(
room_id,
room_version,
@ -550,14 +548,14 @@ class StateResolutionHandler:
return cache
def resolve_events_with_store(
async def resolve_events_with_store(
self,
room_id: str,
room_version: str,
state_sets: Sequence[StateMap[str]],
event_map: Optional[Dict[str, EventBase]],
state_res_store: "StateResolutionStore",
) -> Awaitable[StateMap[str]]:
) -> StateMap[str]:
"""
Args:
room_id: the room we are working in
@ -580,13 +578,14 @@ class StateResolutionHandler:
Returns:
a map from (type, state_key) to event_id.
"""
with Measure(self.clock, "state._resolve_events"):
v = KNOWN_ROOM_VERSIONS[room_version]
if v.state_res == StateResolutionVersions.V1:
return v1.resolve_events_with_store(
return await v1.resolve_events_with_store(
room_id, state_sets, event_map, state_res_store.get_events
)
else:
return v2.resolve_events_with_store(
return await v2.resolve_events_with_store(
self.clock,
room_id,
room_version,