Do not assume calls to runInteraction return Deferreds. (#8133)

This commit is contained in:
Patrick Cloke 2020-08-20 06:39:55 -04:00 committed by GitHub
parent 12aebdfa5a
commit 76c43f086a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 41 additions and 31 deletions

View file

@ -341,14 +341,15 @@ class GroupServerWorkerStore(SQLBaseStore):
"get_users_for_summary_by_role", _get_users_for_summary_txn
)
def is_user_in_group(self, user_id, group_id):
return self.db_pool.simple_select_one_onecol(
async def is_user_in_group(self, user_id: str, group_id: str) -> bool:
result = await self.db_pool.simple_select_one_onecol(
table="group_users",
keyvalues={"group_id": group_id, "user_id": user_id},
retcol="user_id",
allow_none=True,
desc="is_user_in_group",
).addCallback(lambda r: bool(r))
)
return bool(result)
def is_user_admin_in_group(self, group_id, user_id):
return self.db_pool.simple_select_one_onecol(