Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-03 20:24:51 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix caching behavior for relations push rules. (#12859)

Browse source 
By always returning all requested values from the function
wrapped by cachedList. Otherwise implicit None values get
added into the cache, which are unexpected.
This commit is contained in:
Patrick Cloke 2022-05-25 07:49:54 -04:00 • committed by GitHub
parent 4cbcd4a999
commit 759f9c09e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
synapse/util/caches/descriptors.py
View file

@ -595,13 +595,14 @@ def cached(
def cachedList(
*, cached_method_name: str, list_name: str, num_args: Optional[int] = None
) -> Callable[[F], _CachedFunction[F]]:
"""Creates a descriptor that wraps a function in a `CacheListDescriptor`.
"""Creates a descriptor that wraps a function in a `DeferredCacheListDescriptor`.
Used to do batch lookups for an already created cache. A single argument
Used to do batch lookups for an already created cache. One of the arguments
is specified as a list that is iterated through to lookup keys in the
original cache. A new tuple consisting of the (deduplicated) keys that weren't in
the cache gets passed to the original function, the result of which is stored in the
cache.
the cache gets passed to the original function, which is expected to results
in a map of key to value for each passed value. THe new results are stored in the
original cache. Note that any missing values are cached as None.
Args:
cached_method_name: The name of the single-item lookup method.
@ -614,11 +615,11 @@ def cachedList(
Example:
class Example:
@cached(num_args=2)
def do_something(self, first_arg):
@cached()
def do_something(self, first_arg, second_arg):
...
@cachedList(do_something.cache, list_name="second_args", num_args=2)
@cachedList(cached_method_name="do_something", list_name="second_args")
def batch_do_something(self, first_arg, second_args):
...
"""