From 747f8eb2311099f4f8b6c0c76f3105a941fbb6bb Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Wed, 4 Jan 2023 16:46:25 +0000
Subject: [PATCH] Use env vars in GHA dependabot changelog (#14772)

---
 .github/workflows/dependabot_changelog.yml | 7 +++++--
 changelog.d/14772.misc                     | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)
 create mode 100644 changelog.d/14772.misc

diff --git a/.github/workflows/dependabot_changelog.yml b/.github/workflows/dependabot_changelog.yml
index b6a29a572..df47e3dcb 100644
--- a/.github/workflows/dependabot_changelog.yml
+++ b/.github/workflows/dependabot_changelog.yml
@@ -6,7 +6,7 @@ on:
       - reopened  # For debugging!
 
 permissions:
-  # Needed to be able to push the commit. See 
+  # Needed to be able to push the commit. See
   #     https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#enable-auto-merge-on-a-pull-request
   # for a similar example
   contents: write
@@ -20,8 +20,11 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.ref }}
       - name: Write, commit and push changelog
+        env:
+          PR_TITLE: ${{ github.event.pull_request.title }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}
         run: |
-          echo "${{ github.event.pull_request.title }}." > "changelog.d/${{ github.event.pull_request.number }}".misc
+          echo "${PR_TITLE}." > "changelog.d/${PR_NUMBER}".misc
           git add changelog.d
           git config user.email "github-actions[bot]@users.noreply.github.com"
           git config user.name "GitHub Actions"
diff --git a/changelog.d/14772.misc b/changelog.d/14772.misc
new file mode 100644
index 000000000..7ead5a920
--- /dev/null
+++ b/changelog.d/14772.misc
@@ -0,0 +1 @@
+Change GHA CI job to follow best practices.