Add a comment to clarify why we split on closing curly brace when reading CAS attribute tags

This commit is contained in:
Steven Hammerton 2015-10-12 16:02:17 +01:00
parent 83b464e4f7
commit 739464fbc5

View File

@ -177,6 +177,11 @@ class LoginRestServlet(ClientV1RestServlet):
if child.tag.endswith("attributes"): if child.tag.endswith("attributes"):
attributes = {} attributes = {}
for attribute in child: for attribute in child:
# ElementTree library expands the namespace in attribute tags
# to the full URL of the namespace.
# See (https://docs.python.org/2/library/xml.etree.elementtree.html)
# We don't care about namespace here and it will always be encased in
# curly braces, so we remove them.
if "}" in attribute.tag: if "}" in attribute.tag:
attributes[attribute.tag.split("}")[1]] = attribute.text attributes[attribute.tag.split("}")[1]] = attribute.text
else: else: