Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-06 02:55:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Properly report user-agent/IP during registration of SSO users. (#8784)

Browse source 
This also expands type-hints to the SSO and registration code.

Refactors the CAS code to more closely match OIDC/SAML.
This commit is contained in:
Patrick Cloke 2020-11-23 13:28:03 -05:00 • committed by GitHub
parent 7127855741
commit 6fde6aa9c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 173 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

6
synapse/handlers/saml_handler.py
View file

@ -39,7 +39,7 @@ from synapse.util.async_helpers import Linearizer
from synapse.util.iterutils import chunk_seq
if TYPE_CHECKING:
import synapse.server
from synapse.server import HomeServer
logger = logging.getLogger(__name__)
@ -56,7 +56,7 @@ class Saml2SessionData:
class SamlHandler(BaseHandler):
def __init__(self, hs: "synapse.server.HomeServer"):
def __init__(self, hs: "HomeServer"):
super().__init__(hs)
self._saml_client = Saml2Client(hs.config.saml2_sp_config)
self._saml_idp_entityid = hs.config.saml2_idp_entityid
@ -330,7 +330,7 @@ class SamlHandler(BaseHandler):
localpart=localpart,
default_display_name=displayname,
bind_emails=emails,
user_agent_ips=(user_agent, ip_address),
user_agent_ips=[(user_agent, ip_address)],
)
await self.store.record_user_external_id(