Properly report user-agent/IP during registration of SSO users. (#8784)

This also expands type-hints to the SSO and registration code.

Refactors the CAS code to more closely match OIDC/SAML.
This commit is contained in:
Patrick Cloke 2020-11-23 13:28:03 -05:00 committed by GitHub
parent 7127855741
commit 6fde6aa9c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 173 additions and 122 deletions

View file

@ -925,7 +925,7 @@ class OidcHandler(BaseHandler):
registered_user_id = await self._registration_handler.register_user(
localpart=localpart,
default_display_name=attributes["display_name"],
user_agent_ips=(user_agent, ip_address),
user_agent_ips=[(user_agent, ip_address)],
)
await self.store.record_user_external_id(