Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-02 11:16:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove uses of REPLACE and ON CONFLICT IGNORE to make the SQL more portable.

Browse source
This commit is contained in:
Erik Johnston 2015-03-23 15:38:56 +00:00
parent 9a7f496298
commit 6e7131f02f
4 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

13
synapse/storage/_base.py
View file

@ -341,26 +341,21 @@ class SQLBaseStore(object):
# "Simple" SQL API methods that operate on a single table with no JOINs,
# no complex WHERE clauses, just a dict of values for columns.
def _simple_insert(self, table, values, or_replace=False, or_ignore=False,
desc="_simple_insert"):
def _simple_insert(self, table, values, desc="_simple_insert"):
"""Executes an INSERT query on the named table.
Args:
table : string giving the table name
values : dict of new column names and values for them
or_replace : bool; if True performs an INSERT OR REPLACE
"""
return self.runInteraction(
desc,
self._simple_insert_txn, table, values, or_replace=or_replace,
or_ignore=or_ignore,
self._simple_insert_txn, table, values,
)
@log_function
def _simple_insert_txn(self, txn, table, values, or_replace=False,
or_ignore=False):
sql = "%s INTO %s (%s) VALUES(%s)" % (
("REPLACE" if or_replace else "INSERT"),
def _simple_insert_txn(self, txn, table, values):
sql = "INSERT INTO %s (%s) VALUES(%s)" % (
table,
", ".join(k for k in values),
", ".join("?" for k in values)