Return an empty body for OPTIONS requests. (#7886)

This commit is contained in:
Patrick Cloke 2020-07-24 07:08:07 -04:00 committed by GitHub
parent 1ec688bf21
commit 6a080ea184
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 25 deletions

View file

@ -193,10 +193,10 @@ class OptionsResourceTests(unittest.TestCase):
return channel
def test_unknown_options_request(self):
"""An OPTIONS requests to an unknown URL still returns 200 OK."""
"""An OPTIONS requests to an unknown URL still returns 204 No Content."""
channel = self._make_request(b"OPTIONS", b"/foo/")
self.assertEqual(channel.result["code"], b"200")
self.assertEqual(channel.result["body"], b"{}")
self.assertEqual(channel.result["code"], b"204")
self.assertNotIn("body", channel.result)
# Ensure the correct CORS headers have been added
self.assertTrue(
@ -213,10 +213,10 @@ class OptionsResourceTests(unittest.TestCase):
)
def test_known_options_request(self):
"""An OPTIONS requests to an known URL still returns 200 OK."""
"""An OPTIONS requests to an known URL still returns 204 No Content."""
channel = self._make_request(b"OPTIONS", b"/res/")
self.assertEqual(channel.result["code"], b"200")
self.assertEqual(channel.result["body"], b"{}")
self.assertEqual(channel.result["code"], b"204")
self.assertNotIn("body", channel.result)
# Ensure the correct CORS headers have been added
self.assertTrue(