Add descriptions and remove redundant set(..)

This commit is contained in:
Erik Johnston 2019-06-19 11:49:39 +01:00
parent 16a3124b76
commit 65787b0f7c
2 changed files with 7 additions and 4 deletions

View File

@ -40,7 +40,8 @@ logger = logging.getLogger(__name__)
# Metrics for number of state groups involved in a resolution. # Metrics for number of state groups involved in a resolution.
state_groups_histogram = Histogram( state_groups_histogram = Histogram(
"synapse_state_number_state_groups", "", "synapse_state_number_state_groups_in_resolution",
"Number of state groups used when performing a state resolution",
buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"), buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"),
) )

View File

@ -76,14 +76,16 @@ state_delta_reuse_delta_counter = Counter(
# The number of forward extremities for each new event. # The number of forward extremities for each new event.
forward_extremities_counter = Histogram( forward_extremities_counter = Histogram(
"synapse_storage_events_forward_extremities_persisted", "", "synapse_storage_events_forward_extremities_persisted",
"Number of forward extremities for each new event",
buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf") buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf")
) )
# The number of stale forward extremities for each new event. Stale extremities # The number of stale forward extremities for each new event. Stale extremities
# are those that were in the previous set of extremities as well as the new. # are those that were in the previous set of extremities as well as the new.
stale_forward_extremities_counter = Histogram( stale_forward_extremities_counter = Histogram(
"synapse_storage_events_stale_forward_extremities_persisted", "", "synapse_storage_events_stale_forward_extremities_persisted",
"Number of unchanged forward extremities for each new event",
buckets=(0, 1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf") buckets=(0, 1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf")
) )
@ -583,7 +585,7 @@ class EventsStore(
# (e.g. we ignore backfill/outliers/etc) # (e.g. we ignore backfill/outliers/etc)
if result != latest_event_ids: if result != latest_event_ids:
forward_extremities_counter.observe(len(result)) forward_extremities_counter.observe(len(result))
stale = set(latest_event_ids) & result stale = latest_event_ids & result
stale_forward_extremities_counter.observe(len(stale)) stale_forward_extremities_counter.observe(len(stale))
defer.returnValue(result) defer.returnValue(result)