Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-08-07 11:12:15 -04:00
Code Issues Projects Releases Packages Wiki Activity

Improve opentracing for incoming HTTP requests (#11618)

Browse source 
* remove `start_active_span_from_request`

Instead, pull out a separate function, `span_context_from_request`, to extract
the parent span, which we can then pass into `start_active_span` as
normal. This seems to be clearer all round.

* Remove redundant tags from `incoming-federation-request`

These are all wrapped up inside a parent span generated in AsyncResource, so
there's no point duplicating all the tags that are set there.

* Leave request spans open until the request completes

It may take some time for the response to be encoded into JSON, and that JSON
to be streamed back to the client, and really we want that inside the top-level
span, so let's hand responsibility for closure to the SynapseRequest.

* opentracing logs for HTTP request events

* changelog
This commit is contained in:
Richard van der Hoff 2021-12-20 17:45:03 +00:00 • committed by GitHub
parent 8e4083e2f6
commit 60fa4935b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 64 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/11618.misc Normal file
View file

@ -0,0 +1 @@
Improve opentracing support for incoming HTTP requests.