Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-12 16:02:10 -04:00
Code Issues Projects Releases Packages Wiki Activity

Reject receipt requests with invalid room or event IDs. (#14632)

Browse source 
If the room or event IDs are empty or of an invalid form they
should be rejected.
This commit is contained in:
Nick Mills-Barrett 2022-12-07 17:35:41 +00:00 • committed by GitHub
parent 2506dd7641
commit 60c3fea327
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 81 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
synapse/rest/client/receipts.py
View file

@ -20,7 +20,7 @@ from synapse.api.errors import Codes, SynapseError
from synapse.http.server import HttpServer
from synapse.http.servlet import RestServlet, parse_json_object_from_request
from synapse.http.site import SynapseRequest
from synapse.types import JsonDict
from synapse.types import EventID, JsonDict, RoomID
from ._base import client_patterns
@ -56,6 +56,9 @@ class ReceiptRestServlet(RestServlet):
) -> Tuple[int, JsonDict]:
requester = await self.auth.get_user_by_req(request)
if not RoomID.is_valid(room_id) or not event_id.startswith(EventID.SIGIL):
raise SynapseError(400, "A valid room ID and event ID must be specified")
if receipt_type not in self._known_receipt_types:
raise SynapseError(
400,