Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-03-09 18:49:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update the error code for duplicate annotation (#15075)

Browse Source
This commit is contained in:
Richard van der Hoff 2023-02-15 11:47:57 +00:00 committed by GitHub
parent 06ba71083e
commit 5febf88b6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelog.d/15075.feature Normal file
View File

@ -0,0 +1,2 @@
Update the error code returned when user sends a duplicate annotation.

4
synapse/api/errors.py
View File

@ -108,6 +108,10 @@ class Codes(str, Enum):
USER_AWAITING_APPROVAL = "ORG.MATRIX.MSC3866_USER_AWAITING_APPROVAL" USER_AWAITING_APPROVAL = "ORG.MATRIX.MSC3866_USER_AWAITING_APPROVAL"
# Attempt to send a second annotation with the same event type & annotation key
# MSC2677
DUPLICATE_ANNOTATION = "M_DUPLICATE_ANNOTATION"
class CodeMessageException(RuntimeError): class CodeMessageException(RuntimeError):
"""An exception with integer code and message string attributes. """An exception with integer code and message string attributes.

6
synapse/handlers/message.py
View File

@ -1337,7 +1337,11 @@ class EventCreationHandler:
relation.parent_id, event.type, aggregation_key, event.sender relation.parent_id, event.type, aggregation_key, event.sender
) )
if already_exists: if already_exists:
raise SynapseError(400, "Can't send same reaction twice") raise SynapseError(
400,
"Can't send same reaction twice",
errcode=Codes.DUPLICATE_ANNOTATION,
)
# Don't attempt to start a thread if the parent event is a relation. # Don't attempt to start a thread if the parent event is a relation.
elif relation.rel_type == RelationTypes.THREAD: elif relation.rel_type == RelationTypes.THREAD: