Back out ill-advised notary server hackery (#6657)

Browse source

This was ill-advised. We can't modify verify_keys here, because the response
object has already been signed by the requested key.

Furthermore, it's somewhat unnecessary because existing versions of Synapse
(which get upset that the notary key isn't present in verify_keys) will fall
back to a direct fetch via `/key/v2/server`.

Also: more tests for fetching keys via perspectives: it would be nice if we actually tested when our fetcher can't talk to our notary impl.

...

This commit is contained in:

Richard van der Hoff 2020-01-08 13:24:10 +00:00 • committed by GitHub

parent 235d977e1f

commit 573fee759c

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

5 changed files with 140 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

0

tests/rest/key/v2/__init__.py Normal file

Unescape Escape View file