Run as background process and fix comments

This commit is contained in:
Erik Johnston 2019-06-19 11:33:03 +01:00
parent fc51e21326
commit 554609288b
3 changed files with 7 additions and 4 deletions

View File

@ -93,7 +93,7 @@ class _EventInternalMetadata(object):
return getattr(self, "soft_failed", False) return getattr(self, "soft_failed", False)
def should_proactively_send(self): def should_proactively_send(self):
"""Whether the eventm, if ours, should be sent to other clients and """Whether the event, if ours, should be sent to other clients and
servers. servers.
This is used for sending dummy events internally. Servers and clients This is used for sending dummy events internally. Servers and clients

View File

@ -34,6 +34,7 @@ from synapse.api.errors import (
from synapse.api.room_versions import RoomVersions from synapse.api.room_versions import RoomVersions
from synapse.api.urls import ConsentURIBuilder from synapse.api.urls import ConsentURIBuilder
from synapse.events.validator import EventValidator from synapse.events.validator import EventValidator
from synapse.metrics.background_process_metrics import run_as_background_process
from synapse.replication.http.send_event import ReplicationSendEventRestServlet from synapse.replication.http.send_event import ReplicationSendEventRestServlet
from synapse.storage.state import StateFilter from synapse.storage.state import StateFilter
from synapse.types import RoomAlias, UserID, create_requester from synapse.types import RoomAlias, UserID, create_requester
@ -265,9 +266,11 @@ class EventCreationHandler(object):
not self.config.worker_app not self.config.worker_app
and self.config.cleanup_extremities_with_dummy_events and self.config.cleanup_extremities_with_dummy_events
): ):
# XXX: Send dummy events.
self.clock.looping_call( self.clock.looping_call(
self._send_dummy_events_to_fill_extremities, lambda: run_as_background_process(
"send_dummy_events_to_fill_extremities",
self._send_dummy_events_to_fill_extremities
),
5 * 60 * 1000, 5 * 60 * 1000,
) )

View File

@ -255,7 +255,7 @@ class CleanupExtremDummyEventsTestCase(HomeserverTestCase):
) )
self.assertEqual(len(latest_event_ids), 50) self.assertEqual(len(latest_event_ids), 50)
# Bump the reacto repeatedly so that the background updates have a # Pump the reactor repeatedly so that the background updates have a
# chance to run. # chance to run.
self.pump(10 * 60) self.pump(10 * 60)