Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-02 23:44:57 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix rare error in ReadWriteLock when writers complete immediately (#12105)

Browse source 
Signed-off-by: Sean Quah <seanq@element.io>
This commit is contained in:
Sean Quah 2022-03-01 15:27:15 +00:00 • committed by GitHub
parent 300ed0b8a6
commit 4d6b6c17c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
synapse/util/async_helpers.py
View file

@ -555,7 +555,10 @@ class ReadWriteLock:
finally:
with PreserveLoggingContext():
new_defer.callback(None)
if self.key_to_current_writer[key] == new_defer:
# `self.key_to_current_writer[key]` may be missing if there was another
# writer waiting for us and it completed entirely within the
# `new_defer.callback()` call above.
if self.key_to_current_writer.get(key) == new_defer:
self.key_to_current_writer.pop(key)
return _ctx_manager()