Replace returnValue with return (#5736)

This commit is contained in:
Amber Brown 2019-07-23 23:00:55 +10:00 committed by GitHub
parent 18a466b84e
commit 4806651744
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
177 changed files with 1359 additions and 1513 deletions

View file

@ -85,7 +85,7 @@ class RoomCreateRestServlet(TransactionRestServlet):
requester, self.get_room_config(request)
)
defer.returnValue((200, info))
return (200, info)
def get_room_config(self, request):
user_supplied_config = parse_json_object_from_request(request)
@ -155,9 +155,9 @@ class RoomStateEventRestServlet(TransactionRestServlet):
if format == "event":
event = format_event_for_client_v2(data.get_dict())
defer.returnValue((200, event))
return (200, event)
elif format == "content":
defer.returnValue((200, data.get_dict()["content"]))
return (200, data.get_dict()["content"])
@defer.inlineCallbacks
def on_PUT(self, request, room_id, event_type, state_key, txn_id=None):
@ -192,7 +192,7 @@ class RoomStateEventRestServlet(TransactionRestServlet):
ret = {}
if event:
ret = {"event_id": event.event_id}
defer.returnValue((200, ret))
return (200, ret)
# TODO: Needs unit testing for generic events + feedback
@ -226,7 +226,7 @@ class RoomSendEventRestServlet(TransactionRestServlet):
requester, event_dict, txn_id=txn_id
)
defer.returnValue((200, {"event_id": event.event_id}))
return (200, {"event_id": event.event_id})
def on_GET(self, request, room_id, event_type, txn_id):
return (200, "Not implemented")
@ -289,7 +289,7 @@ class JoinRoomAliasServlet(TransactionRestServlet):
third_party_signed=content.get("third_party_signed", None),
)
defer.returnValue((200, {"room_id": room_id}))
return (200, {"room_id": room_id})
def on_PUT(self, request, room_identifier, txn_id):
return self.txns.fetch_or_execute_request(
@ -342,7 +342,7 @@ class PublicRoomListRestServlet(TransactionRestServlet):
limit=limit, since_token=since_token
)
defer.returnValue((200, data))
return (200, data)
@defer.inlineCallbacks
def on_POST(self, request):
@ -387,7 +387,7 @@ class PublicRoomListRestServlet(TransactionRestServlet):
network_tuple=network_tuple,
)
defer.returnValue((200, data))
return (200, data)
# TODO: Needs unit testing
@ -438,7 +438,7 @@ class RoomMemberListRestServlet(RestServlet):
continue
chunk.append(event)
defer.returnValue((200, {"chunk": chunk}))
return (200, {"chunk": chunk})
# deprecated in favour of /members?membership=join?
@ -459,7 +459,7 @@ class JoinedRoomMemberListRestServlet(RestServlet):
requester, room_id
)
defer.returnValue((200, {"joined": users_with_profile}))
return (200, {"joined": users_with_profile})
# TODO: Needs better unit testing
@ -492,7 +492,7 @@ class RoomMessageListRestServlet(RestServlet):
event_filter=event_filter,
)
defer.returnValue((200, msgs))
return (200, msgs)
# TODO: Needs unit testing
@ -513,7 +513,7 @@ class RoomStateRestServlet(RestServlet):
user_id=requester.user.to_string(),
is_guest=requester.is_guest,
)
defer.returnValue((200, events))
return (200, events)
# TODO: Needs unit testing
@ -532,7 +532,7 @@ class RoomInitialSyncRestServlet(RestServlet):
content = yield self.initial_sync_handler.room_initial_sync(
room_id=room_id, requester=requester, pagin_config=pagination_config
)
defer.returnValue((200, content))
return (200, content)
class RoomEventServlet(RestServlet):
@ -555,9 +555,9 @@ class RoomEventServlet(RestServlet):
time_now = self.clock.time_msec()
if event:
event = yield self._event_serializer.serialize_event(event, time_now)
defer.returnValue((200, event))
return (200, event)
else:
defer.returnValue((404, "Event not found."))
return (404, "Event not found.")
class RoomEventContextServlet(RestServlet):
@ -607,7 +607,7 @@ class RoomEventContextServlet(RestServlet):
results["state"], time_now
)
defer.returnValue((200, results))
return (200, results)
class RoomForgetRestServlet(TransactionRestServlet):
@ -626,7 +626,7 @@ class RoomForgetRestServlet(TransactionRestServlet):
yield self.room_member_handler.forget(user=requester.user, room_id=room_id)
defer.returnValue((200, {}))
return (200, {})
def on_PUT(self, request, room_id, txn_id):
return self.txns.fetch_or_execute_request(
@ -676,7 +676,7 @@ class RoomMembershipRestServlet(TransactionRestServlet):
requester,
txn_id,
)
defer.returnValue((200, {}))
return (200, {})
return
target = requester.user
@ -703,7 +703,7 @@ class RoomMembershipRestServlet(TransactionRestServlet):
if membership_action == "join":
return_value["room_id"] = room_id
defer.returnValue((200, return_value))
return (200, return_value)
def _has_3pid_invite_keys(self, content):
for key in {"id_server", "medium", "address"}:
@ -745,7 +745,7 @@ class RoomRedactEventRestServlet(TransactionRestServlet):
txn_id=txn_id,
)
defer.returnValue((200, {"event_id": event.event_id}))
return (200, {"event_id": event.event_id})
def on_PUT(self, request, room_id, event_id, txn_id):
return self.txns.fetch_or_execute_request(
@ -790,7 +790,7 @@ class RoomTypingRestServlet(RestServlet):
target_user=target_user, auth_user=requester.user, room_id=room_id
)
defer.returnValue((200, {}))
return (200, {})
class SearchRestServlet(RestServlet):
@ -812,7 +812,7 @@ class SearchRestServlet(RestServlet):
requester.user, content, batch
)
defer.returnValue((200, results))
return (200, results)
class JoinedRoomsRestServlet(RestServlet):
@ -828,7 +828,7 @@ class JoinedRoomsRestServlet(RestServlet):
requester = yield self.auth.get_user_by_req(request, allow_guest=True)
room_ids = yield self.store.get_rooms_for_user(requester.user.to_string())
defer.returnValue((200, {"joined_rooms": list(room_ids)}))
return (200, {"joined_rooms": list(room_ids)})
def register_txn_path(servlet, regex_string, http_server, with_get=False):