typing: check origin server of typing event against room's servers (#13830)

This is also using the partial state approximation if needed so we do
not block here during a fast join.

Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
This commit is contained in:
Mathieu Velten 2022-09-26 17:33:32 +02:00 committed by GitHub
parent 6b4593a80f
commit 41461fd4d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions

1
changelog.d/13830.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a long-standing bug where typing events would be accepted from remote servers not present in a room. Also fix a bug where incoming typing events would cause other incoming events to get stuck during a fast join.

View File

@ -362,11 +362,14 @@ class TypingWriterHandler(FollowerTypingHandler):
) )
return return
domains = await self._storage_controllers.state.get_current_hosts_in_room( # Let's check that the origin server is in the room before accepting the typing
# event. We don't want to block waiting on a partial state so take an
# approximation if needed.
domains = await self._storage_controllers.state.get_current_hosts_in_room_or_partial_state_approximation(
room_id room_id
) )
if self.server_name in domains: if user.domain in domains:
logger.info("Got typing update from %s: %r", user_id, content) logger.info("Got typing update from %s: %r", user_id, content)
now = self.clock.time_msec() now = self.clock.time_msec()
self._member_typing_until[member] = now + FEDERATION_TIMEOUT self._member_typing_until[member] = now + FEDERATION_TIMEOUT

View File

@ -138,6 +138,10 @@ class TypingNotificationsTestCase(unittest.HomeserverTestCase):
get_current_hosts_in_room get_current_hosts_in_room
) )
hs.get_storage_controllers().state.get_current_hosts_in_room_or_partial_state_approximation = (
get_current_hosts_in_room
)
async def get_users_in_room(room_id: str): async def get_users_in_room(room_id: str):
return {str(u) for u in self.room_members} return {str(u) for u in self.room_members}