Track DB scheduling delay per-request

For each request, track the amount of time spent waiting for a db
connection. This entails adding it to the LoggingContext and we may as well add
metrics for it while we are passing.
This commit is contained in:
Richard van der Hoff 2018-01-12 00:27:14 +00:00
parent 0f5d2cc37c
commit 3d12d97415
5 changed files with 43 additions and 4 deletions

View file

@ -59,7 +59,8 @@ class LoggingContext(object):
__slots__ = [
"previous_context", "name", "ru_stime", "ru_utime",
"db_txn_count", "db_txn_duration_ms", "usage_start", "usage_end",
"db_txn_count", "db_txn_duration_ms", "db_sched_duration_ms",
"usage_start", "usage_end",
"main_thread", "alive",
"request", "tag",
]
@ -86,6 +87,9 @@ class LoggingContext(object):
def add_database_transaction(self, duration_ms):
pass
def add_database_scheduled(self, sched_ms):
pass
def __nonzero__(self):
return False
@ -101,6 +105,9 @@ class LoggingContext(object):
# ms spent waiting for db txns, excluding scheduling time
self.db_txn_duration_ms = 0
# ms spent waiting for db txns to be scheduled
self.db_sched_duration_ms = 0
self.usage_start = None
self.usage_end = None
self.main_thread = threading.current_thread()
@ -210,6 +217,15 @@ class LoggingContext(object):
self.db_txn_count += 1
self.db_txn_duration_ms += duration_ms
def add_database_scheduled(self, sched_ms):
"""Record a use of the database pool
Args:
sched_ms (int): number of milliseconds it took us to get a
connection
"""
self.db_sched_duration_ms += sched_ms
class LoggingContextFilter(logging.Filter):
"""Logging filter that adds values from the current logging context to each