From 318245eaa6d37a27ca72168356198fdd90abfbb7 Mon Sep 17 00:00:00 2001
From: Patrick Cloke <clokep@users.noreply.github.com>
Date: Tue, 1 Sep 2020 08:16:58 -0400
Subject: [PATCH] Do not install setuptools 50.0. (#8212)

This is due to compatibility issues with old Python versions.
---
 INSTALL.md                     | 2 +-
 changelog.d/8212.bugfix        | 1 +
 synapse/python_dependencies.py | 4 ++++
 3 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/8212.bugfix

diff --git a/INSTALL.md b/INSTALL.md
index 22f7b7c02..bdb7769fe 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -73,7 +73,7 @@ mkdir -p ~/synapse
 virtualenv -p python3 ~/synapse/env
 source ~/synapse/env/bin/activate
 pip install --upgrade pip
-pip install --upgrade setuptools
+pip install --upgrade setuptools!=50.0  # setuptools==50.0 fails on some older Python versions
 pip install matrix-synapse
 ```
 
diff --git a/changelog.d/8212.bugfix b/changelog.d/8212.bugfix
new file mode 100644
index 000000000..0f8c0aed9
--- /dev/null
+++ b/changelog.d/8212.bugfix
@@ -0,0 +1 @@
+Do not install setuptools 50.0. It can lead to a broken configuration on some older Python versions.
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
index 2d995ec45..d666f2267 100644
--- a/synapse/python_dependencies.py
+++ b/synapse/python_dependencies.py
@@ -74,6 +74,10 @@ REQUIREMENTS = [
     "Jinja2>=2.9",
     "bleach>=1.4.3",
     "typing-extensions>=3.7.4",
+    # setuptools is required by a variety of dependencies, unfortunately version
+    # 50.0 is incompatible with older Python versions, see
+    # https://github.com/pypa/setuptools/issues/2352
+    "setuptools!=50.0",
 ]
 
 CONDITIONAL_REQUIREMENTS = {