Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-06-20 03:54:09 -04:00
Code Issues Projects Releases Packages Wiki Activity

Pass str to twisted's IReactorTCP (#10895)

Browse source 
This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job.

Until that change is in a twisted release, we'll have to ignore the type
of the `host` argument. I've raised #10899 to remind us to review the
issue in a few months' time.
This commit is contained in:
David Robertson 2021-09-30 12:51:47 +01:00 • committed by GitHub
parent 3aefc7b66d
commit 29364145b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 27 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

9
synapse/handlers/send_email.py
View file

@ -105,8 +105,13 @@ async def _sendmail(
# set to enable TLS.
factory = build_sender_factory(hostname=smtphost if enable_tls else None)
# the IReactorTCP interface claims host has to be a bytes, which seems to be wrong
reactor.connectTCP(smtphost, smtpport, factory, timeout=30, bindAddress=None) # type: ignore[arg-type]
reactor.connectTCP(
smtphost, # type: ignore[arg-type]
smtpport,
factory,
timeout=30,
bindAddress=None,
)
await make_deferred_yieldable(d)