mirror of
https://git.anonymousland.org/anonymousland/synapse.git
synced 2024-12-25 10:09:22 -05:00
Ensure portdb selects _all_ rows with negative rowids (#13226)
This commit is contained in:
parent
739adf1551
commit
28d96cb2b4
1
changelog.d/13226.bugfix
Normal file
1
changelog.d/13226.bugfix
Normal file
@ -0,0 +1 @@
|
|||||||
|
Fix a long-standing bug where the `synapse_port_db` script could fail to copy rows with negative row ids.
|
@ -418,12 +418,15 @@ class Porter:
|
|||||||
self.progress.update(table, table_size) # Mark table as done
|
self.progress.update(table, table_size) # Mark table as done
|
||||||
return
|
return
|
||||||
|
|
||||||
|
# We sweep over rowids in two directions: one forwards (rowids 1, 2, 3, ...)
|
||||||
|
# and another backwards (rowids 0, -1, -2, ...).
|
||||||
forward_select = (
|
forward_select = (
|
||||||
"SELECT rowid, * FROM %s WHERE rowid >= ? ORDER BY rowid LIMIT ?" % (table,)
|
"SELECT rowid, * FROM %s WHERE rowid >= ? ORDER BY rowid LIMIT ?" % (table,)
|
||||||
)
|
)
|
||||||
|
|
||||||
backward_select = (
|
backward_select = (
|
||||||
"SELECT rowid, * FROM %s WHERE rowid <= ? ORDER BY rowid LIMIT ?" % (table,)
|
"SELECT rowid, * FROM %s WHERE rowid <= ? ORDER BY rowid DESC LIMIT ?"
|
||||||
|
% (table,)
|
||||||
)
|
)
|
||||||
|
|
||||||
do_forward = [True]
|
do_forward = [True]
|
||||||
|
Loading…
Reference in New Issue
Block a user