Review comments

This commit is contained in:
Erik Johnston 2019-01-24 18:28:00 +00:00
parent 4a8b715679
commit 26f44164c8
2 changed files with 4 additions and 2 deletions

View File

@ -247,6 +247,7 @@ def room_version_to_event_format(room_version):
int int
""" """
if room_version not in KNOWN_ROOM_VERSIONS: if room_version not in KNOWN_ROOM_VERSIONS:
raise # We should have already checked version, so this should not happen
raise RuntimeError("Unrecognized room version %s" % (room_version,))
return EventFormatVersions.V1 return EventFormatVersions.V1

View File

@ -543,7 +543,8 @@ class FederationClient(FederationBase):
Return: Return:
Deferred[tuple[str, dict, int]]: resolves to a tuple of Deferred[tuple[str, dict, int]]: resolves to a tuple of
`(origin, event, event_format)` where origin is the remote `(origin, event, event_format)` where origin is the remote
homeserver which generated the event. homeserver which generated the event, and event_format is one of
`synapse.api.constants.EventFormatVersions`.
Fails with a ``SynapseError`` if the chosen remote server Fails with a ``SynapseError`` if the chosen remote server
returns a 300/400 code. returns a 300/400 code.