From 224783a73f9c438d6fdf041a336749c6ae336bb2 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 21 Mar 2019 15:28:19 +0000 Subject: [PATCH] Allow newsfragments to end with exclamation marks! (#4912) --- changelog.d/4912.misc | 1 + scripts-dev/check-newsfragment | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelog.d/4912.misc diff --git a/changelog.d/4912.misc b/changelog.d/4912.misc new file mode 100644 index 000000000..f05a23918 --- /dev/null +++ b/changelog.d/4912.misc @@ -0,0 +1 @@ +Allow newsfragments to end with exclamation marks. Exciting! diff --git a/scripts-dev/check-newsfragment b/scripts-dev/check-newsfragment index e0ac84198..0ec5075e7 100755 --- a/scripts-dev/check-newsfragment +++ b/scripts-dev/check-newsfragment @@ -31,8 +31,8 @@ echo # check that any new newsfiles on this branch end with a full stop. for f in `git diff --name-only FETCH_HEAD... -- changelog.d`; do lastchar=`tr -d '\n' < $f | tail -c 1` - if [ $lastchar != '.' ]; then - echo -e "\e[31mERROR: newsfragment $f does not end with a '.'\e[39m" >&2 + if [ $lastchar != '.' -a $lastchar != '!' ]; then + echo -e "\e[31mERROR: newsfragment $f does not end with a '.' or '!'\e[39m" >&2 exit 1 fi done