mirror of
https://git.anonymousland.org/anonymousland/synapse.git
synced 2025-09-21 18:54:37 -04:00
Revert accidental fast-forward merge from v1.49.0rc1
Revert "Sort internal changes in changelog" Revert "Update CHANGES.md" Revert "1.49.0rc1" Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)" Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)" Revert "Correctly register shutdown handler for presence workers (#11518)" Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)" Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)" Revert "Correctly ignore invites from ignored users (#11511)" Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)" Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)" Revert "Save the OIDC session ID (sid) with the device on login (#11482)" Revert "Add admin API to get some information about federation status (#11407)" Revert "Include bundled aggregations in /sync and related fixes (#11478)" Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)" Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)" Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)" Revert "Add type hints to `synapse/tests/rest/admin` (#11501)" Revert "Revert accidental commits to develop." Revert "Newsfile" Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour" Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`" Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`" Revert "Disambiguate queries on `state_key` (#11497)" Revert "Comments on the /sync tentacles (#11494)" Revert "Clean up tests.storage.test_appservice (#11492)" Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)" Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)" Revert "Minor cleanup on recently ported doc pages (#11466)" Revert "Add most of the missing type hints to `synapse.federation`. (#11483)" Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)" Revert "Fix media repository failing when media store path contains symlinks (#11446)" Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)" Revert "`scripts-dev/sign_json`: support for signing events (#11486)" Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)" Revert "Port wiki pages to documentation website (#11402)" Revert "Add a license header and comment. (#11479)" Revert "Clean-up get_version_string (#11468)" Revert "Link background update controller docs to summary (#11475)" Revert "Additional type hints for config module. (#11465)" Revert "Register the login redirect endpoint for v3. (#11451)" Revert "Update openid.md" Revert "Remove mention of OIDC certification from Dex (#11470)" Revert "Add a note about huge pages to our Postgres doc (#11467)" Revert "Don't start Synapse master process if `worker_app` is set (#11416)" Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)" Revert "Bundle relations of relations into the `/relations` result. (#11284)" Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)" Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)" Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)" Revert "Merge branch 'master' into develop" This reverts commit26b5d2320f
. This reverts commitbce4220f38
. This reverts commit966b5d0fa0
. This reverts commit088d748f2c
. This reverts commit14d593f72d
. This reverts commit2a3ec6facf
. This reverts commiteccc49d755
. This reverts commitb1ecd19c5d
. This reverts commit9c55dedc8c
. This reverts commit2d42e586a8
. This reverts commit2f053f3f82
. This reverts commita15a893df8
. This reverts commit8b4b153c9e
. This reverts commit494ebd7347
. This reverts commita77c369897
. This reverts commit4eb77965cd
. This reverts commit637df95de6
. This reverts commite5f426cd54
. This reverts commit8cd68b8102
. This reverts commit6cae125e20
. This reverts commit7be88fbf48
. This reverts commitb3fd99b74a
. This reverts commitf7ec6e7d9e
. This reverts commit5640992d17
. This reverts commitd26808dd85
. This reverts commitf91624a595
. This reverts commit16d39a5490
. This reverts commit8a4c296987
. This reverts commit49e1356ee3
. This reverts commitd2279f471b
. This reverts commitb50e39df57
. This reverts commit858d80bf0f
. This reverts commit435f044807
. This reverts commitf61462e1be
. This reverts commita6f1a3abec
. This reverts commit84dc50e160
. This reverts commited635d3285
. This reverts commit7b62791e00
. This reverts commit153194c771
. This reverts commitf44d729d4c
. This reverts commita265fbd397
. This reverts commitb9fef1a7cd
. This reverts commitb0eb64ff7b
. This reverts commitf1795463bf
. This reverts commit70cbb1a5e3
. This reverts commit42bf020463
. This reverts commit379f2650cf
. This reverts commit7ff22d6da4
. This reverts commit5a0b652d36
. This reverts commit432a174bc1
. This reverts commitb14f8a1baf
, reversing changes made toe713855dca
.
This commit is contained in:
parent
26b5d2320f
commit
158d73ebdd
165 changed files with 2709 additions and 7721 deletions
|
@ -12,24 +12,11 @@
|
|||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
import json
|
||||
from contextlib import contextmanager
|
||||
from typing import Generator
|
||||
|
||||
from twisted.enterprise.adbapi import ConnectionPool
|
||||
from twisted.internet.defer import ensureDeferred
|
||||
from twisted.test.proto_helpers import MemoryReactor
|
||||
|
||||
from synapse.api.room_versions import EventFormatVersions, RoomVersions
|
||||
from synapse.logging.context import LoggingContext
|
||||
from synapse.rest import admin
|
||||
from synapse.rest.client import login, room
|
||||
from synapse.server import HomeServer
|
||||
from synapse.storage.databases.main.events_worker import (
|
||||
EVENT_QUEUE_THREADS,
|
||||
EventsWorkerStore,
|
||||
)
|
||||
from synapse.storage.types import Connection
|
||||
from synapse.util import Clock
|
||||
from synapse.storage.databases.main.events_worker import EventsWorkerStore
|
||||
from synapse.util.async_helpers import yieldable_gather_results
|
||||
|
||||
from tests import unittest
|
||||
|
@ -157,127 +144,3 @@ class EventCacheTestCase(unittest.HomeserverTestCase):
|
|||
|
||||
# We should have fetched the event from the DB
|
||||
self.assertEqual(ctx.get_resource_usage().evt_db_fetch_count, 1)
|
||||
|
||||
|
||||
class DatabaseOutageTestCase(unittest.HomeserverTestCase):
|
||||
"""Test event fetching during a database outage."""
|
||||
|
||||
def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer):
|
||||
self.store: EventsWorkerStore = hs.get_datastore()
|
||||
|
||||
self.room_id = f"!room:{hs.hostname}"
|
||||
self.event_ids = [f"event{i}" for i in range(20)]
|
||||
|
||||
self._populate_events()
|
||||
|
||||
def _populate_events(self) -> None:
|
||||
"""Ensure that there are test events in the database.
|
||||
|
||||
When testing with the in-memory SQLite database, all the events are lost during
|
||||
the simulated outage.
|
||||
|
||||
To ensure consistency between `room_id`s and `event_id`s before and after the
|
||||
outage, rows are built and inserted manually.
|
||||
|
||||
Upserts are used to handle the non-SQLite case where events are not lost.
|
||||
"""
|
||||
self.get_success(
|
||||
self.store.db_pool.simple_upsert(
|
||||
"rooms",
|
||||
{"room_id": self.room_id},
|
||||
{"room_version": RoomVersions.V4.identifier},
|
||||
)
|
||||
)
|
||||
|
||||
self.event_ids = [f"event{i}" for i in range(20)]
|
||||
for idx, event_id in enumerate(self.event_ids):
|
||||
self.get_success(
|
||||
self.store.db_pool.simple_upsert(
|
||||
"events",
|
||||
{"event_id": event_id},
|
||||
{
|
||||
"event_id": event_id,
|
||||
"room_id": self.room_id,
|
||||
"topological_ordering": idx,
|
||||
"stream_ordering": idx,
|
||||
"type": "test",
|
||||
"processed": True,
|
||||
"outlier": False,
|
||||
},
|
||||
)
|
||||
)
|
||||
self.get_success(
|
||||
self.store.db_pool.simple_upsert(
|
||||
"event_json",
|
||||
{"event_id": event_id},
|
||||
{
|
||||
"room_id": self.room_id,
|
||||
"json": json.dumps({"type": "test", "room_id": self.room_id}),
|
||||
"internal_metadata": "{}",
|
||||
"format_version": EventFormatVersions.V3,
|
||||
},
|
||||
)
|
||||
)
|
||||
|
||||
@contextmanager
|
||||
def _outage(self) -> Generator[None, None, None]:
|
||||
"""Simulate a database outage.
|
||||
|
||||
Returns:
|
||||
A context manager. While the context is active, any attempts to connect to
|
||||
the database will fail.
|
||||
"""
|
||||
connection_pool = self.store.db_pool._db_pool
|
||||
|
||||
# Close all connections and shut down the database `ThreadPool`.
|
||||
connection_pool.close()
|
||||
|
||||
# Restart the database `ThreadPool`.
|
||||
connection_pool.start()
|
||||
|
||||
original_connection_factory = connection_pool.connectionFactory
|
||||
|
||||
def connection_factory(_pool: ConnectionPool) -> Connection:
|
||||
raise Exception("Could not connect to the database.")
|
||||
|
||||
connection_pool.connectionFactory = connection_factory # type: ignore[assignment]
|
||||
try:
|
||||
yield
|
||||
finally:
|
||||
connection_pool.connectionFactory = original_connection_factory
|
||||
|
||||
# If the in-memory SQLite database is being used, all the events are gone.
|
||||
# Restore the test data.
|
||||
self._populate_events()
|
||||
|
||||
def test_failure(self) -> None:
|
||||
"""Test that event fetches do not get stuck during a database outage."""
|
||||
with self._outage():
|
||||
failure = self.get_failure(
|
||||
self.store.get_event(self.event_ids[0]), Exception
|
||||
)
|
||||
self.assertEqual(str(failure.value), "Could not connect to the database.")
|
||||
|
||||
def test_recovery(self) -> None:
|
||||
"""Test that event fetchers recover after a database outage."""
|
||||
with self._outage():
|
||||
# Kick off a bunch of event fetches but do not pump the reactor
|
||||
event_deferreds = []
|
||||
for event_id in self.event_ids:
|
||||
event_deferreds.append(ensureDeferred(self.store.get_event(event_id)))
|
||||
|
||||
# We should have maxed out on event fetcher threads
|
||||
self.assertEqual(self.store._event_fetch_ongoing, EVENT_QUEUE_THREADS)
|
||||
|
||||
# All the event fetchers will fail
|
||||
self.pump()
|
||||
self.assertEqual(self.store._event_fetch_ongoing, 0)
|
||||
|
||||
for event_deferred in event_deferreds:
|
||||
failure = self.get_failure(event_deferred, Exception)
|
||||
self.assertEqual(
|
||||
str(failure.value), "Could not connect to the database."
|
||||
)
|
||||
|
||||
# This next event fetch should succeed
|
||||
self.get_success(self.store.get_event(self.event_ids[0]))
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue