Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-08-19 02:57:51 -04:00
Code Issues Projects Releases Packages Wiki Activity

Add some checks that we aren't using state from rejected events (#6330)

Browse source 
* Raise an exception if accessing state for rejected events

Add some sanity checks on accessing state_group etc for
rejected events.

* Skip calculating push actions for rejected events

It didn't actually cause any bugs, because rejected events get filtered out at
various later points, but there's not point in trying to calculate the push
actions for a rejected event.
This commit is contained in:
Richard van der Hoff 2019-11-05 22:13:37 +00:00 • committed by GitHub
parent 01ba7b38a7
commit 0e3ab8afdc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 50 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
synapse/handlers/federation.py
View file

@ -1688,7 +1688,11 @@ class FederationHandler(BaseHandler):
# hack around with a try/finally instead.
success = False
try:
if not event.internal_metadata.is_outlier() and not backfilled:
if (
not event.internal_metadata.is_outlier()
and not backfilled
and not context.rejected
):
yield self.action_generator.handle_push_actions_for_event(
event, context
)