2021-06-09 14:39:51 -04:00
|
|
|
# Copyright 2014-2021 The Matrix.org Foundation C.I.C.
|
|
|
|
# Copyright 2020 Sorunome
|
2014-08-12 10:10:52 -04:00
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
2014-08-12 22:14:34 -04:00
|
|
|
|
2014-08-12 10:10:52 -04:00
|
|
|
"""Contains handlers for federation events."""
|
2018-04-17 17:11:19 -04:00
|
|
|
|
|
|
|
import itertools
|
|
|
|
import logging
|
2020-07-20 13:33:04 -04:00
|
|
|
from collections.abc import Container
|
2020-06-16 08:51:47 -04:00
|
|
|
from http import HTTPStatus
|
2021-04-06 07:21:57 -04:00
|
|
|
from typing import (
|
|
|
|
TYPE_CHECKING,
|
2021-06-08 05:37:01 -04:00
|
|
|
Collection,
|
2021-04-06 07:21:57 -04:00
|
|
|
Dict,
|
|
|
|
Iterable,
|
|
|
|
List,
|
|
|
|
Optional,
|
|
|
|
Sequence,
|
|
|
|
Set,
|
|
|
|
Tuple,
|
|
|
|
Union,
|
|
|
|
)
|
2018-04-17 17:11:19 -04:00
|
|
|
|
2019-12-05 10:02:35 -05:00
|
|
|
import attr
|
2021-06-11 05:12:35 -04:00
|
|
|
from prometheus_client import Counter
|
2018-07-09 02:09:20 -04:00
|
|
|
from signedjson.key import decode_verify_key_bytes
|
|
|
|
from signedjson.sign import verify_signed_json
|
2016-02-23 10:11:25 -05:00
|
|
|
from unpaddedbase64 import decode_base64
|
2014-08-12 10:10:52 -04:00
|
|
|
|
2018-07-09 02:09:20 -04:00
|
|
|
from twisted.internet import defer
|
2014-08-12 10:10:52 -04:00
|
|
|
|
2019-10-18 13:43:36 -04:00
|
|
|
from synapse import event_auth
|
2020-06-10 12:44:34 -04:00
|
|
|
from synapse.api.constants import (
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
EventContentFields,
|
2020-06-10 12:44:34 -04:00
|
|
|
EventTypes,
|
|
|
|
Membership,
|
|
|
|
RejectedReason,
|
|
|
|
RoomEncryptionAlgorithms,
|
|
|
|
)
|
2014-11-26 11:06:20 -05:00
|
|
|
from synapse.api.errors import (
|
2018-07-09 02:09:20 -04:00
|
|
|
AuthError,
|
|
|
|
CodeMessageException,
|
2019-06-12 05:31:37 -04:00
|
|
|
Codes,
|
2018-01-22 13:11:18 -05:00
|
|
|
FederationDeniedError,
|
2018-07-09 02:09:20 -04:00
|
|
|
FederationError,
|
2020-05-22 06:39:20 -04:00
|
|
|
HttpResponseException,
|
2020-07-16 10:17:31 -04:00
|
|
|
NotFoundError,
|
2019-06-03 04:56:45 -04:00
|
|
|
RequestSendFailed,
|
2018-07-09 02:09:20 -04:00
|
|
|
SynapseError,
|
2014-11-26 11:06:20 -05:00
|
|
|
)
|
2020-01-27 09:30:57 -05:00
|
|
|
from synapse.api.room_versions import KNOWN_ROOM_VERSIONS, RoomVersion, RoomVersions
|
2019-01-23 15:05:44 -05:00
|
|
|
from synapse.crypto.event_signing import compute_event_signature
|
2019-02-12 05:31:21 -05:00
|
|
|
from synapse.event_auth import auth_types_for_event
|
2020-01-28 09:18:29 -05:00
|
|
|
from synapse.events import EventBase
|
2019-11-01 12:19:09 -04:00
|
|
|
from synapse.events.snapshot import EventContext
|
2018-07-09 02:09:20 -04:00
|
|
|
from synapse.events.validator import EventValidator
|
2020-03-30 14:06:52 -04:00
|
|
|
from synapse.handlers._base import BaseHandler
|
2020-11-19 05:05:33 -05:00
|
|
|
from synapse.http.servlet import assert_params_in_dict
|
2019-07-03 10:07:04 -04:00
|
|
|
from synapse.logging.context import (
|
|
|
|
make_deferred_yieldable,
|
|
|
|
nested_logging_context,
|
|
|
|
preserve_fn,
|
|
|
|
run_in_background,
|
|
|
|
)
|
|
|
|
from synapse.logging.utils import log_function
|
2020-07-10 13:23:17 -04:00
|
|
|
from synapse.metrics.background_process_metrics import run_as_background_process
|
2020-01-30 12:06:38 -05:00
|
|
|
from synapse.replication.http.devices import ReplicationUserDevicesResyncRestServlet
|
2018-07-26 06:44:22 -04:00
|
|
|
from synapse.replication.http.federation import (
|
2018-08-09 05:29:48 -04:00
|
|
|
ReplicationCleanRoomRestServlet,
|
2018-07-26 06:44:22 -04:00
|
|
|
ReplicationFederationSendEventsRestServlet,
|
2020-11-13 11:24:04 -05:00
|
|
|
ReplicationStoreRoomOnOutlierMembershipRestServlet,
|
2018-07-26 06:44:22 -04:00
|
|
|
)
|
2020-09-28 10:20:02 -04:00
|
|
|
from synapse.state import StateResolutionStore
|
2020-08-05 16:38:57 -04:00
|
|
|
from synapse.storage.databases.main.events_worker import EventRedactBehaviour
|
2020-08-28 07:28:53 -04:00
|
|
|
from synapse.types import (
|
|
|
|
JsonDict,
|
|
|
|
MutableStateMap,
|
2020-09-24 08:24:17 -04:00
|
|
|
PersistedEventPosition,
|
|
|
|
RoomStreamToken,
|
2020-08-28 07:28:53 -04:00
|
|
|
StateMap,
|
|
|
|
UserID,
|
|
|
|
get_domain_from_id,
|
|
|
|
)
|
2019-12-16 07:26:28 -05:00
|
|
|
from synapse.util.async_helpers import Linearizer, concurrently_execute
|
2021-05-27 12:10:58 -04:00
|
|
|
from synapse.util.iterutils import batch_iter
|
2015-05-12 05:35:45 -04:00
|
|
|
from synapse.util.retryutils import NotRetryingDestination
|
2020-03-30 14:06:52 -04:00
|
|
|
from synapse.util.stringutils import shortstr
|
2018-07-16 06:38:45 -04:00
|
|
|
from synapse.visibility import filter_events_for_server
|
2015-05-12 05:35:45 -04:00
|
|
|
|
2020-09-28 10:20:02 -04:00
|
|
|
if TYPE_CHECKING:
|
|
|
|
from synapse.server import HomeServer
|
|
|
|
|
2014-08-12 10:10:52 -04:00
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
2021-06-11 05:12:35 -04:00
|
|
|
soft_failed_event_counter = Counter(
|
|
|
|
"synapse_federation_soft_failed_events_total",
|
|
|
|
"Events received over federation that we marked as soft_failed",
|
|
|
|
)
|
|
|
|
|
2014-08-12 10:10:52 -04:00
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
@attr.s(slots=True, frozen=True, auto_attribs=True)
|
2019-12-05 10:02:35 -05:00
|
|
|
class _NewEventInfo:
|
2021-04-14 12:35:28 -04:00
|
|
|
"""Holds information about a received event, ready for passing to _auth_and_persist_events
|
2019-12-05 10:02:35 -05:00
|
|
|
|
|
|
|
Attributes:
|
|
|
|
event: the received event
|
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
state: the state at that event, according to /state_ids from a remote
|
|
|
|
homeserver. Only populated for backfilled events which are going to be a
|
|
|
|
new backwards extremity.
|
|
|
|
|
|
|
|
claimed_auth_event_map: a map of (type, state_key) => event for the event's
|
|
|
|
claimed auth_events.
|
|
|
|
|
|
|
|
This can include events which have not yet been persisted, in the case that
|
|
|
|
we are backfilling a batch of events.
|
|
|
|
|
|
|
|
Note: May be incomplete: if we were unable to find all of the claimed auth
|
|
|
|
events. Also, treat the contents with caution: the events might also have
|
|
|
|
been rejected, might not yet have been authorized themselves, or they might
|
|
|
|
be in the wrong room.
|
2019-12-05 10:02:35 -05:00
|
|
|
|
|
|
|
"""
|
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
event: EventBase
|
|
|
|
state: Optional[Sequence[EventBase]]
|
|
|
|
claimed_auth_event_map: StateMap[EventBase]
|
2019-12-05 10:02:35 -05:00
|
|
|
|
|
|
|
|
2014-08-12 10:10:52 -04:00
|
|
|
class FederationHandler(BaseHandler):
|
2014-08-26 14:49:42 -04:00
|
|
|
"""Handles events that originated from federation.
|
|
|
|
Responsible for:
|
|
|
|
a) handling received Pdus before handing them on as Events to the rest
|
2020-10-23 12:38:40 -04:00
|
|
|
of the homeserver (including auth and state conflict resolutions)
|
2014-08-26 14:49:42 -04:00
|
|
|
b) converting events that were produced by local clients that may need
|
2019-11-12 08:08:12 -05:00
|
|
|
to be sent to remote homeservers.
|
2014-11-12 11:20:21 -05:00
|
|
|
c) doing the necessary dances to invite remote users and join remote
|
|
|
|
rooms.
|
2014-08-26 14:49:42 -04:00
|
|
|
"""
|
2014-08-12 10:10:52 -04:00
|
|
|
|
2020-09-28 10:20:02 -04:00
|
|
|
def __init__(self, hs: "HomeServer"):
|
2020-09-18 09:56:44 -04:00
|
|
|
super().__init__(hs)
|
2014-08-21 09:38:22 -04:00
|
|
|
|
2015-11-05 11:43:19 -05:00
|
|
|
self.hs = hs
|
|
|
|
|
2019-01-30 05:53:17 -05:00
|
|
|
self.store = hs.get_datastore()
|
2019-10-23 07:02:36 -04:00
|
|
|
self.storage = hs.get_storage()
|
2019-10-23 12:25:54 -04:00
|
|
|
self.state_store = self.storage.state
|
2018-07-31 10:44:05 -04:00
|
|
|
self.federation_client = hs.get_federation_client()
|
2014-08-26 14:49:42 -04:00
|
|
|
self.state_handler = hs.get_state_handler()
|
2020-09-28 10:20:02 -04:00
|
|
|
self._state_resolution_handler = hs.get_state_resolution_handler()
|
2014-08-26 14:49:42 -04:00
|
|
|
self.server_name = hs.hostname
|
2014-11-14 11:45:39 -05:00
|
|
|
self.keyring = hs.get_keyring()
|
2017-05-18 13:17:40 -04:00
|
|
|
self.action_generator = hs.get_action_generator()
|
2017-06-30 11:20:30 -04:00
|
|
|
self.is_mine_id = hs.is_mine_id
|
2017-10-03 08:53:09 -04:00
|
|
|
self.spam_checker = hs.get_spam_checker()
|
2018-01-15 11:52:07 -05:00
|
|
|
self.event_creation_handler = hs.get_event_creation_handler()
|
2021-04-23 07:05:51 -04:00
|
|
|
self._event_auth_handler = hs.get_event_auth_handler()
|
2019-12-03 14:19:45 -05:00
|
|
|
self._message_handler = hs.get_message_handler()
|
2018-05-18 06:18:39 -04:00
|
|
|
self._server_notices_mxid = hs.config.server_notices_mxid
|
2018-07-25 11:32:05 -04:00
|
|
|
self.config = hs.config
|
2020-12-02 11:09:24 -05:00
|
|
|
self.http_client = hs.get_proxied_blacklisted_http_client()
|
2020-05-22 11:11:35 -04:00
|
|
|
self._instance_name = hs.get_instance_name()
|
2020-05-22 09:21:54 -04:00
|
|
|
self._replication = hs.get_replication_data_handler()
|
2014-08-26 14:49:42 -04:00
|
|
|
|
2020-05-22 11:11:35 -04:00
|
|
|
self._send_events = ReplicationFederationSendEventsRestServlet.make_client(hs)
|
2018-08-09 05:29:48 -04:00
|
|
|
self._clean_room_for_join_client = ReplicationCleanRoomRestServlet.make_client(
|
|
|
|
hs
|
|
|
|
)
|
2014-08-26 14:49:42 -04:00
|
|
|
|
2020-01-30 12:06:38 -05:00
|
|
|
if hs.config.worker_app:
|
|
|
|
self._user_device_resync = (
|
|
|
|
ReplicationUserDevicesResyncRestServlet.make_client(hs)
|
|
|
|
)
|
2020-11-13 11:24:04 -05:00
|
|
|
self._maybe_store_room_on_outlier_membership = (
|
|
|
|
ReplicationStoreRoomOnOutlierMembershipRestServlet.make_client(hs)
|
2020-02-26 11:58:33 -05:00
|
|
|
)
|
2020-01-30 12:06:38 -05:00
|
|
|
else:
|
|
|
|
self._device_list_updater = hs.get_device_handler().device_list_updater
|
2020-11-13 11:24:04 -05:00
|
|
|
self._maybe_store_room_on_outlier_membership = (
|
|
|
|
self.store.maybe_store_room_on_outlier_membership
|
|
|
|
)
|
2020-01-30 12:06:38 -05:00
|
|
|
|
2020-09-29 10:57:36 -04:00
|
|
|
# When joining a room we need to queue any events for that room up.
|
|
|
|
# For each room, a list of (pdu, origin) tuples.
|
2021-07-16 13:22:36 -04:00
|
|
|
self.room_queues: Dict[str, List[Tuple[EventBase, str]]] = {}
|
2017-03-09 11:20:13 -05:00
|
|
|
self._room_pdu_linearizer = Linearizer("fed_room_pdu")
|
|
|
|
|
2021-06-04 05:47:58 -04:00
|
|
|
self._room_backfill = Linearizer("room_backfill")
|
|
|
|
|
2019-06-12 05:31:37 -04:00
|
|
|
self.third_party_event_rules = hs.get_third_party_event_rules()
|
|
|
|
|
2019-12-03 14:19:45 -05:00
|
|
|
self._ephemeral_messages_enabled = hs.config.enable_ephemeral_messages
|
|
|
|
|
2021-08-19 13:05:12 -04:00
|
|
|
async def on_receive_pdu(self, origin: str, pdu: EventBase) -> None:
|
|
|
|
"""Process a PDU received via a federation /send/ transaction
|
2017-03-09 11:20:13 -05:00
|
|
|
|
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
origin: server which initiated the /send/ transaction. Will
|
2017-03-09 11:20:13 -05:00
|
|
|
be used to fetch missing events or state.
|
2021-04-06 07:21:57 -04:00
|
|
|
pdu: received PDU
|
2017-03-09 11:20:13 -05:00
|
|
|
"""
|
|
|
|
|
2018-09-19 12:28:18 -04:00
|
|
|
room_id = pdu.room_id
|
|
|
|
event_id = pdu.event_id
|
|
|
|
|
2017-03-09 11:20:13 -05:00
|
|
|
# We reprocess pdus when we have seen them only as outliers
|
2019-12-10 12:01:37 -05:00
|
|
|
existing = await self.store.get_event(
|
2018-06-07 11:18:57 -04:00
|
|
|
event_id, allow_none=True, allow_rejected=True
|
2017-03-09 11:20:13 -05:00
|
|
|
)
|
|
|
|
|
|
|
|
# FIXME: Currently we fetch an event again when we already have it
|
|
|
|
# if it has been marked as an outlier.
|
2021-08-16 08:19:02 -04:00
|
|
|
if existing:
|
|
|
|
if not existing.internal_metadata.is_outlier():
|
|
|
|
logger.info(
|
|
|
|
"Ignoring received event %s which we have already seen", event_id
|
|
|
|
)
|
|
|
|
return
|
|
|
|
if pdu.internal_metadata.is_outlier():
|
|
|
|
logger.info(
|
|
|
|
"Ignoring received outlier %s which we already have as an outlier",
|
|
|
|
event_id,
|
|
|
|
)
|
|
|
|
return
|
|
|
|
logger.info("De-outliering event %s", event_id)
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2018-04-17 17:11:19 -04:00
|
|
|
# do some initial sanity-checking of the event. In particular, make
|
|
|
|
# sure it doesn't have hundreds of prev_events or auth_events, which
|
2018-04-17 18:41:12 -04:00
|
|
|
# could cause a huge state resolution or cascade of event fetches.
|
|
|
|
try:
|
|
|
|
self._sanity_check_event(pdu)
|
|
|
|
except SynapseError as err:
|
2021-03-12 10:08:03 -05:00
|
|
|
logger.warning("Received event failed sanity checks")
|
2019-05-23 06:17:42 -04:00
|
|
|
raise FederationError("ERROR", err.code, err.msg, affected=pdu.event_id)
|
2018-04-17 17:11:19 -04:00
|
|
|
|
2017-03-14 07:26:57 -04:00
|
|
|
# If we are currently in the process of joining this room, then we
|
|
|
|
# queue up events for later processing.
|
2018-09-19 12:28:18 -04:00
|
|
|
if room_id in self.room_queues:
|
|
|
|
logger.info(
|
2021-03-12 10:08:03 -05:00
|
|
|
"Queuing PDU from %s for now: join in progress",
|
2018-09-19 12:28:18 -04:00
|
|
|
origin,
|
|
|
|
)
|
|
|
|
self.room_queues[room_id].append((pdu, origin))
|
2017-03-14 07:26:57 -04:00
|
|
|
return
|
|
|
|
|
2018-11-09 06:34:45 -05:00
|
|
|
# If we're not in the room just ditch the event entirely. This is
|
|
|
|
# probably an old server that has come back and thinks we're still in
|
|
|
|
# the room (or we've been rejoined to the room by a state reset).
|
2017-10-03 06:09:51 -04:00
|
|
|
#
|
2018-11-09 06:34:45 -05:00
|
|
|
# Note that if we were never in the room then we would have already
|
|
|
|
# dropped the event, since we wouldn't know the room version.
|
2021-07-01 14:25:37 -04:00
|
|
|
is_in_room = await self._event_auth_handler.check_host_in_room(
|
|
|
|
room_id, self.server_name
|
|
|
|
)
|
2017-10-03 06:09:51 -04:00
|
|
|
if not is_in_room:
|
2018-11-09 06:34:45 -05:00
|
|
|
logger.info(
|
2021-03-12 10:08:03 -05:00
|
|
|
"Ignoring PDU from %s as we're not in the room",
|
2018-11-09 06:34:45 -05:00
|
|
|
origin,
|
2017-10-03 06:09:51 -04:00
|
|
|
)
|
2019-07-23 09:00:55 -04:00
|
|
|
return None
|
2017-10-03 06:09:51 -04:00
|
|
|
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
# Check that the event passes auth based on the state at the event. This is
|
|
|
|
# done for events that are to be added to the timeline (non-outliers).
|
|
|
|
#
|
|
|
|
# Get missing pdus if necessary:
|
|
|
|
# - Fetching any missing prev events to fill in gaps in the graph
|
|
|
|
# - Fetching state if we have a hole in the graph
|
2017-03-09 11:20:13 -05:00
|
|
|
if not pdu.internal_metadata.is_outlier():
|
2021-08-19 13:05:12 -04:00
|
|
|
prevs = set(pdu.prev_event_ids())
|
|
|
|
seen = await self.store.have_events_in_timeline(prevs)
|
|
|
|
missing_prevs = prevs - seen
|
|
|
|
|
|
|
|
if missing_prevs:
|
|
|
|
# We only backfill backwards to the min depth.
|
|
|
|
min_depth = await self.get_min_depth_for_context(pdu.room_id)
|
|
|
|
logger.debug("min_depth: %d", min_depth)
|
|
|
|
|
|
|
|
if min_depth is not None and pdu.depth > min_depth:
|
|
|
|
# If we're missing stuff, ensure we only fetch stuff one
|
|
|
|
# at a time.
|
|
|
|
logger.info(
|
|
|
|
"Acquiring room lock to fetch %d missing prev_events: %s",
|
|
|
|
len(missing_prevs),
|
|
|
|
shortstr(missing_prevs),
|
|
|
|
)
|
|
|
|
with (await self._room_pdu_linearizer.queue(pdu.room_id)):
|
2017-03-09 11:20:13 -05:00
|
|
|
logger.info(
|
2021-08-19 13:05:12 -04:00
|
|
|
"Acquired room lock to fetch %d missing prev_events",
|
2018-09-19 12:28:18 -04:00
|
|
|
len(missing_prevs),
|
2017-03-09 11:20:13 -05:00
|
|
|
)
|
2021-08-19 13:05:12 -04:00
|
|
|
|
|
|
|
try:
|
|
|
|
await self._get_missing_events_for_pdu(
|
|
|
|
origin, pdu, prevs, min_depth
|
2019-12-11 09:32:25 -05:00
|
|
|
)
|
2021-08-19 13:05:12 -04:00
|
|
|
except Exception as e:
|
|
|
|
raise Exception(
|
|
|
|
"Error fetching missing prev_events for %s: %s"
|
|
|
|
% (event_id, e)
|
|
|
|
) from e
|
2021-08-18 07:36:22 -04:00
|
|
|
|
2021-08-19 13:05:12 -04:00
|
|
|
# Update the set of things we've seen after trying to
|
|
|
|
# fetch the missing stuff
|
|
|
|
seen = await self.store.have_events_in_timeline(prevs)
|
|
|
|
missing_prevs = prevs - seen
|
2017-05-03 05:06:43 -04:00
|
|
|
|
2021-08-19 13:05:12 -04:00
|
|
|
if not missing_prevs:
|
|
|
|
logger.info("Found all missing prev_events")
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2021-08-19 13:05:12 -04:00
|
|
|
if missing_prevs:
|
|
|
|
# since this event was pushed to us, it is possible for it to
|
|
|
|
# become the only forward-extremity in the room, and we would then
|
|
|
|
# trust its state to be the state for the whole room. This is very
|
|
|
|
# bad. Further, if the event was pushed to us, there is no excuse
|
|
|
|
# for us not to have all the prev_events. (XXX: apart from
|
|
|
|
# min_depth?)
|
|
|
|
#
|
|
|
|
# We therefore reject any such events.
|
|
|
|
logger.warning(
|
|
|
|
"Rejecting: failed to fetch %d prev events: %s",
|
|
|
|
len(missing_prevs),
|
|
|
|
shortstr(missing_prevs),
|
|
|
|
)
|
|
|
|
raise FederationError(
|
|
|
|
"ERROR",
|
|
|
|
403,
|
|
|
|
(
|
|
|
|
"Your server isn't divulging details about prev_events "
|
|
|
|
"referenced in this event."
|
|
|
|
),
|
|
|
|
affected=pdu.event_id,
|
|
|
|
)
|
|
|
|
|
|
|
|
await self._process_received_pdu(origin, pdu, state=None)
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def _get_missing_events_for_pdu(
|
|
|
|
self, origin: str, pdu: EventBase, prevs: Set[str], min_depth: int
|
|
|
|
) -> None:
|
2017-03-09 11:20:13 -05:00
|
|
|
"""
|
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
origin: Origin of the pdu. Will be called to get the missing events
|
2017-03-09 11:20:13 -05:00
|
|
|
pdu: received pdu
|
2021-04-06 07:21:57 -04:00
|
|
|
prevs: List of event ids which we are missing
|
|
|
|
min_depth: Minimum depth of events to return.
|
2017-03-09 11:20:13 -05:00
|
|
|
"""
|
2018-09-19 12:28:18 -04:00
|
|
|
|
|
|
|
room_id = pdu.room_id
|
|
|
|
event_id = pdu.event_id
|
|
|
|
|
2020-07-01 11:59:31 -04:00
|
|
|
seen = await self.store.have_events_in_timeline(prevs)
|
2017-03-09 11:20:13 -05:00
|
|
|
|
|
|
|
if not prevs - seen:
|
2017-04-28 07:46:53 -04:00
|
|
|
return
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2020-09-03 10:38:32 -04:00
|
|
|
latest_list = await self.store.get_latest_event_ids_in_room(room_id)
|
2017-03-09 11:20:13 -05:00
|
|
|
|
|
|
|
# We add the prev events that we have seen to the latest
|
|
|
|
# list to ensure the remote server doesn't give them to us
|
2020-09-03 10:38:32 -04:00
|
|
|
latest = set(latest_list)
|
2017-03-09 11:20:13 -05:00
|
|
|
latest |= seen
|
|
|
|
|
|
|
|
logger.info(
|
2021-03-12 10:08:03 -05:00
|
|
|
"Requesting missing events between %s and %s",
|
2018-10-16 15:37:16 -04:00
|
|
|
shortstr(latest),
|
|
|
|
event_id,
|
2017-03-09 11:20:13 -05:00
|
|
|
)
|
|
|
|
|
|
|
|
# XXX: we set timeout to 10s to help workaround
|
|
|
|
# https://github.com/matrix-org/synapse/issues/1733.
|
|
|
|
# The reason is to avoid holding the linearizer lock
|
|
|
|
# whilst processing inbound /send transactions, causing
|
|
|
|
# FDs to stack up and block other inbound transactions
|
|
|
|
# which empirically can currently take up to 30 minutes.
|
|
|
|
#
|
|
|
|
# N.B. this explicitly disables retry attempts.
|
|
|
|
#
|
|
|
|
# N.B. this also increases our chances of falling back to
|
|
|
|
# fetching fresh state for the room if the missing event
|
|
|
|
# can't be found, which slightly reduces our security.
|
|
|
|
# it may also increase our DAG extremity count for the room,
|
|
|
|
# causing additional state resolution? See #1760.
|
|
|
|
# However, fetching state doesn't hold the linearizer lock
|
|
|
|
# apparently.
|
|
|
|
#
|
|
|
|
# see https://github.com/matrix-org/synapse/pull/1744
|
2018-09-18 10:02:51 -04:00
|
|
|
#
|
|
|
|
# ----
|
|
|
|
#
|
|
|
|
# Update richvdh 2018/09/18: There are a number of problems with timing this
|
2020-10-23 12:38:40 -04:00
|
|
|
# request out aggressively on the client side:
|
2018-09-18 10:02:51 -04:00
|
|
|
#
|
|
|
|
# - it plays badly with the server-side rate-limiter, which starts tarpitting you
|
|
|
|
# if you send too many requests at once, so you end up with the server carefully
|
|
|
|
# working through the backlog of your requests, which you have already timed
|
|
|
|
# out.
|
|
|
|
#
|
|
|
|
# - for this request in particular, we now (as of
|
|
|
|
# https://github.com/matrix-org/synapse/pull/3456) reject any PDUs where the
|
|
|
|
# server can't produce a plausible-looking set of prev_events - so we becone
|
|
|
|
# much more likely to reject the event.
|
|
|
|
#
|
|
|
|
# - contrary to what it says above, we do *not* fall back to fetching fresh state
|
|
|
|
# for the room if get_missing_events times out. Rather, we give up processing
|
|
|
|
# the PDU whose prevs we are missing, which then makes it much more likely that
|
|
|
|
# we'll end up back here for the *next* PDU in the list, which exacerbates the
|
|
|
|
# problem.
|
|
|
|
#
|
2020-10-23 12:38:40 -04:00
|
|
|
# - the aggressive 10s timeout was introduced to deal with incoming federation
|
2018-09-18 10:02:51 -04:00
|
|
|
# requests taking 8 hours to process. It's not entirely clear why that was going
|
|
|
|
# on; certainly there were other issues causing traffic storms which are now
|
|
|
|
# resolved, and I think in any case we may be more sensible about our locking
|
|
|
|
# now. We're *certainly* more sensible about our logging.
|
|
|
|
#
|
2020-10-23 12:38:40 -04:00
|
|
|
# All that said: Let's try increasing the timeout to 60s and see what happens.
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2019-04-10 05:39:54 -04:00
|
|
|
try:
|
2019-12-10 12:01:37 -05:00
|
|
|
missing_events = await self.federation_client.get_missing_events(
|
2019-04-10 05:39:54 -04:00
|
|
|
origin,
|
|
|
|
room_id,
|
|
|
|
earliest_events_ids=list(latest),
|
|
|
|
latest_events=[pdu],
|
|
|
|
limit=10,
|
|
|
|
min_depth=min_depth,
|
|
|
|
timeout=60000,
|
|
|
|
)
|
2020-06-03 09:12:13 -04:00
|
|
|
except (RequestSendFailed, HttpResponseException, NotRetryingDestination) as e:
|
2019-04-10 05:39:54 -04:00
|
|
|
# We failed to get the missing events, but since we need to handle
|
|
|
|
# the case of `get_missing_events` not returning the necessary
|
|
|
|
# events anyway, it is safe to simply log the error and continue.
|
2021-03-12 10:08:03 -05:00
|
|
|
logger.warning("Failed to get prev_events: %s", e)
|
2019-04-10 05:39:54 -04:00
|
|
|
return
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2021-08-16 08:19:02 -04:00
|
|
|
logger.info("Got %d prev_events", len(missing_events))
|
2021-08-19 13:05:12 -04:00
|
|
|
await self._process_pulled_events(origin, missing_events)
|
2017-03-09 11:20:13 -05:00
|
|
|
|
2019-12-10 12:25:18 -05:00
|
|
|
async def _get_state_for_room(
|
2019-12-11 11:37:51 -05:00
|
|
|
self,
|
|
|
|
destination: str,
|
|
|
|
room_id: str,
|
|
|
|
event_id: str,
|
2021-05-10 08:29:02 -04:00
|
|
|
) -> List[EventBase]:
|
|
|
|
"""Requests all of the room state at a given event from a remote
|
|
|
|
homeserver.
|
|
|
|
|
|
|
|
Will also fetch any missing events reported in the `auth_chain_ids`
|
|
|
|
section of `/state_ids`.
|
2019-12-10 12:42:46 -05:00
|
|
|
|
|
|
|
Args:
|
2019-12-11 11:37:51 -05:00
|
|
|
destination: The remote homeserver to query for the state.
|
2019-12-10 12:25:18 -05:00
|
|
|
room_id: The id of the room we're interested in.
|
|
|
|
event_id: The id of the event we want the state at.
|
2019-12-10 12:42:46 -05:00
|
|
|
|
|
|
|
Returns:
|
2021-05-10 08:29:02 -04:00
|
|
|
A list of events in the state, not including the event itself.
|
2019-12-10 12:42:46 -05:00
|
|
|
"""
|
|
|
|
(
|
|
|
|
state_event_ids,
|
|
|
|
auth_event_ids,
|
2019-12-10 12:25:18 -05:00
|
|
|
) = await self.federation_client.get_room_state_ids(
|
2019-12-10 12:42:46 -05:00
|
|
|
destination, room_id, event_id=event_id
|
|
|
|
)
|
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
# Fetch the state events from the DB, and check we have the auth events.
|
|
|
|
event_map = await self.store.get_events(state_event_ids, allow_rejected=True)
|
2021-06-01 07:04:47 -04:00
|
|
|
auth_events_in_store = await self.store.have_seen_events(
|
|
|
|
room_id, auth_event_ids
|
|
|
|
)
|
2021-05-10 08:29:02 -04:00
|
|
|
|
|
|
|
# Check for missing events. We handle state and auth event seperately,
|
|
|
|
# as we want to pull the state from the DB, but we don't for the auth
|
|
|
|
# events. (Note: we likely won't use the majority of the auth chain, and
|
|
|
|
# it can be *huge* for large rooms, so it's worth ensuring that we don't
|
|
|
|
# unnecessarily pull it from the DB).
|
|
|
|
missing_state_events = set(state_event_ids) - set(event_map)
|
|
|
|
missing_auth_events = set(auth_event_ids) - set(auth_events_in_store)
|
|
|
|
if missing_state_events or missing_auth_events:
|
|
|
|
await self._get_events_and_persist(
|
|
|
|
destination=destination,
|
|
|
|
room_id=room_id,
|
|
|
|
events=missing_state_events | missing_auth_events,
|
2019-12-10 12:42:46 -05:00
|
|
|
)
|
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
if missing_state_events:
|
|
|
|
new_events = await self.store.get_events(
|
|
|
|
missing_state_events, allow_rejected=True
|
|
|
|
)
|
|
|
|
event_map.update(new_events)
|
2019-12-12 07:57:45 -05:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
missing_state_events.difference_update(new_events)
|
2020-07-10 13:15:35 -04:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
if missing_state_events:
|
|
|
|
logger.warning(
|
|
|
|
"Failed to fetch missing state events for %s %s",
|
|
|
|
event_id,
|
|
|
|
missing_state_events,
|
|
|
|
)
|
2019-12-10 12:42:46 -05:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
if missing_auth_events:
|
|
|
|
auth_events_in_store = await self.store.have_seen_events(
|
2021-06-01 07:04:47 -04:00
|
|
|
room_id, missing_auth_events
|
2021-05-10 08:29:02 -04:00
|
|
|
)
|
|
|
|
missing_auth_events.difference_update(auth_events_in_store)
|
2019-12-10 12:42:46 -05:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
if missing_auth_events:
|
|
|
|
logger.warning(
|
|
|
|
"Failed to fetch missing auth events for %s %s",
|
|
|
|
event_id,
|
|
|
|
missing_auth_events,
|
|
|
|
)
|
2019-12-10 12:42:46 -05:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
remote_state = list(event_map.values())
|
2019-12-12 07:57:45 -05:00
|
|
|
|
|
|
|
# check for events which were in the wrong room.
|
|
|
|
#
|
|
|
|
# this can happen if a remote server claims that the state or
|
|
|
|
# auth_events at an event in room A are actually events in room B
|
|
|
|
|
2020-02-21 07:15:07 -05:00
|
|
|
bad_events = [
|
2021-05-10 08:29:02 -04:00
|
|
|
(event.event_id, event.room_id)
|
|
|
|
for event in remote_state
|
2019-12-12 07:57:45 -05:00
|
|
|
if event.room_id != room_id
|
2020-02-21 07:15:07 -05:00
|
|
|
]
|
2019-12-12 07:57:45 -05:00
|
|
|
|
|
|
|
for bad_event_id, bad_room_id in bad_events:
|
|
|
|
# This is a bogus situation, but since we may only discover it a long time
|
|
|
|
# after it happened, we try our best to carry on, by just omitting the
|
|
|
|
# bad events from the returned auth/state set.
|
|
|
|
logger.warning(
|
|
|
|
"Remote server %s claims event %s in room %s is an auth/state "
|
|
|
|
"event in room %s",
|
|
|
|
destination,
|
|
|
|
bad_event_id,
|
|
|
|
bad_room_id,
|
|
|
|
room_id,
|
2019-12-10 12:42:46 -05:00
|
|
|
)
|
2019-12-18 04:51:51 -05:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
if bad_events:
|
|
|
|
remote_state = [e for e in remote_state if e.room_id == room_id]
|
2019-12-10 12:42:46 -05:00
|
|
|
|
2021-05-10 08:29:02 -04:00
|
|
|
return remote_state
|
2019-12-10 12:42:46 -05:00
|
|
|
|
Optimise missing prev_event handling (#9601)
Background: When we receive incoming federation traffic, and notice that we are missing prev_events from
the incoming traffic, first we do a `/get_missing_events` request, and then if we still have missing prev_events,
we set up new backwards-extremities. To do that, we need to make a `/state_ids` request to ask the remote
server for the state at those prev_events, and then we may need to then ask the remote server for any events
in that state which we don't already have, as well as the auth events for those missing state events, so that we
can auth them.
This PR attempts to optimise the processing of that state request. The `state_ids` API returns a list of the state
events, as well as a list of all the auth events for *all* of those state events. The optimisation comes from the
observation that we are currently loading all of those auth events into memory at the start of the operation, but
we almost certainly aren't going to need *all* of the auth events. Rather, we can check that we have them, and
leave the actual load into memory for later. (Ideally the federation API would tell us which auth events we're
actually going to need, but it doesn't.)
The effect of this is to reduce the number of events that I need to load for an event in Matrix HQ from about
60000 to about 22000, which means it can stay in my in-memory cache, whereas previously the sheer number
of events meant that all 60K events had to be loaded from db for each request, due to the amount of cache
churn. (NB I've already tripled the size of the cache from its default of 10K).
Unfortunately I've ended up basically C&Ping `_get_state_for_room` and `_get_events_from_store_or_dest` into
a new method, because `_get_state_for_room` is also called during backfill, which expects the auth events to be
returned, so the same tricks don't work. That said, I don't really know why that codepath is completely different
(ultimately we're doing the same thing in setting up a new backwards extremity) so I've left a TODO suggesting
that we clean it up.
2021-03-15 09:51:02 -04:00
|
|
|
async def _get_state_after_missing_prev_event(
|
|
|
|
self,
|
|
|
|
destination: str,
|
|
|
|
room_id: str,
|
|
|
|
event_id: str,
|
|
|
|
) -> List[EventBase]:
|
|
|
|
"""Requests all of the room state at a given event from a remote homeserver.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
destination: The remote homeserver to query for the state.
|
|
|
|
room_id: The id of the room we're interested in.
|
|
|
|
event_id: The id of the event we want the state at.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
A list of events in the state, including the event itself
|
|
|
|
"""
|
|
|
|
# TODO: This function is basically the same as _get_state_for_room. Can
|
|
|
|
# we make backfill() use it, rather than having two code paths? I think the
|
|
|
|
# only difference is that backfill() persists the prev events separately.
|
|
|
|
|
|
|
|
(
|
|
|
|
state_event_ids,
|
|
|
|
auth_event_ids,
|
|
|
|
) = await self.federation_client.get_room_state_ids(
|
|
|
|
destination, room_id, event_id=event_id
|
|
|
|
)
|
|
|
|
|
|
|
|
logger.debug(
|
|
|
|
"state_ids returned %i state events, %i auth events",
|
|
|
|
len(state_event_ids),
|
|
|
|
len(auth_event_ids),
|
|
|
|
)
|
|
|
|
|
|
|
|
# start by just trying to fetch the events from the store
|
|
|
|
desired_events = set(state_event_ids)
|
|
|
|
desired_events.add(event_id)
|
|
|
|
logger.debug("Fetching %i events from cache/store", len(desired_events))
|
|
|
|
fetched_events = await self.store.get_events(
|
|
|
|
desired_events, allow_rejected=True
|
|
|
|
)
|
|
|
|
|
|
|
|
missing_desired_events = desired_events - fetched_events.keys()
|
|
|
|
logger.debug(
|
|
|
|
"We are missing %i events (got %i)",
|
|
|
|
len(missing_desired_events),
|
|
|
|
len(fetched_events),
|
|
|
|
)
|
|
|
|
|
|
|
|
# We probably won't need most of the auth events, so let's just check which
|
|
|
|
# we have for now, rather than thrashing the event cache with them all
|
|
|
|
# unnecessarily.
|
|
|
|
|
|
|
|
# TODO: we probably won't actually need all of the auth events, since we
|
|
|
|
# already have a bunch of the state events. It would be nice if the
|
|
|
|
# federation api gave us a way of finding out which we actually need.
|
|
|
|
|
|
|
|
missing_auth_events = set(auth_event_ids) - fetched_events.keys()
|
|
|
|
missing_auth_events.difference_update(
|
2021-06-01 07:04:47 -04:00
|
|
|
await self.store.have_seen_events(room_id, missing_auth_events)
|
Optimise missing prev_event handling (#9601)
Background: When we receive incoming federation traffic, and notice that we are missing prev_events from
the incoming traffic, first we do a `/get_missing_events` request, and then if we still have missing prev_events,
we set up new backwards-extremities. To do that, we need to make a `/state_ids` request to ask the remote
server for the state at those prev_events, and then we may need to then ask the remote server for any events
in that state which we don't already have, as well as the auth events for those missing state events, so that we
can auth them.
This PR attempts to optimise the processing of that state request. The `state_ids` API returns a list of the state
events, as well as a list of all the auth events for *all* of those state events. The optimisation comes from the
observation that we are currently loading all of those auth events into memory at the start of the operation, but
we almost certainly aren't going to need *all* of the auth events. Rather, we can check that we have them, and
leave the actual load into memory for later. (Ideally the federation API would tell us which auth events we're
actually going to need, but it doesn't.)
The effect of this is to reduce the number of events that I need to load for an event in Matrix HQ from about
60000 to about 22000, which means it can stay in my in-memory cache, whereas previously the sheer number
of events meant that all 60K events had to be loaded from db for each request, due to the amount of cache
churn. (NB I've already tripled the size of the cache from its default of 10K).
Unfortunately I've ended up basically C&Ping `_get_state_for_room` and `_get_events_from_store_or_dest` into
a new method, because `_get_state_for_room` is also called during backfill, which expects the auth events to be
returned, so the same tricks don't work. That said, I don't really know why that codepath is completely different
(ultimately we're doing the same thing in setting up a new backwards extremity) so I've left a TODO suggesting
that we clean it up.
2021-03-15 09:51:02 -04:00
|
|
|
)
|
|
|
|
logger.debug("We are also missing %i auth events", len(missing_auth_events))
|
|
|
|
|
|
|
|
missing_events = missing_desired_events | missing_auth_events
|
|
|
|
logger.debug("Fetching %i events from remote", len(missing_events))
|
|
|
|
await self._get_events_and_persist(
|
|
|
|
destination=destination, room_id=room_id, events=missing_events
|
|
|
|
)
|
|
|
|
|
|
|
|
# we need to make sure we re-load from the database to get the rejected
|
|
|
|
# state correct.
|
|
|
|
fetched_events.update(
|
2021-07-19 10:28:05 -04:00
|
|
|
await self.store.get_events(missing_desired_events, allow_rejected=True)
|
Optimise missing prev_event handling (#9601)
Background: When we receive incoming federation traffic, and notice that we are missing prev_events from
the incoming traffic, first we do a `/get_missing_events` request, and then if we still have missing prev_events,
we set up new backwards-extremities. To do that, we need to make a `/state_ids` request to ask the remote
server for the state at those prev_events, and then we may need to then ask the remote server for any events
in that state which we don't already have, as well as the auth events for those missing state events, so that we
can auth them.
This PR attempts to optimise the processing of that state request. The `state_ids` API returns a list of the state
events, as well as a list of all the auth events for *all* of those state events. The optimisation comes from the
observation that we are currently loading all of those auth events into memory at the start of the operation, but
we almost certainly aren't going to need *all* of the auth events. Rather, we can check that we have them, and
leave the actual load into memory for later. (Ideally the federation API would tell us which auth events we're
actually going to need, but it doesn't.)
The effect of this is to reduce the number of events that I need to load for an event in Matrix HQ from about
60000 to about 22000, which means it can stay in my in-memory cache, whereas previously the sheer number
of events meant that all 60K events had to be loaded from db for each request, due to the amount of cache
churn. (NB I've already tripled the size of the cache from its default of 10K).
Unfortunately I've ended up basically C&Ping `_get_state_for_room` and `_get_events_from_store_or_dest` into
a new method, because `_get_state_for_room` is also called during backfill, which expects the auth events to be
returned, so the same tricks don't work. That said, I don't really know why that codepath is completely different
(ultimately we're doing the same thing in setting up a new backwards extremity) so I've left a TODO suggesting
that we clean it up.
2021-03-15 09:51:02 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
# check for events which were in the wrong room.
|
|
|
|
#
|
|
|
|
# this can happen if a remote server claims that the state or
|
|
|
|
# auth_events at an event in room A are actually events in room B
|
|
|
|
|
|
|
|
bad_events = [
|
|
|
|
(event_id, event.room_id)
|
|
|
|
for event_id, event in fetched_events.items()
|
|
|
|
if event.room_id != room_id
|
|
|
|
]
|
|
|
|
|
|
|
|
for bad_event_id, bad_room_id in bad_events:
|
|
|
|
# This is a bogus situation, but since we may only discover it a long time
|
|
|
|
# after it happened, we try our best to carry on, by just omitting the
|
|
|
|
# bad events from the returned state set.
|
|
|
|
logger.warning(
|
|
|
|
"Remote server %s claims event %s in room %s is an auth/state "
|
|
|
|
"event in room %s",
|
|
|
|
destination,
|
|
|
|
bad_event_id,
|
|
|
|
bad_room_id,
|
|
|
|
room_id,
|
|
|
|
)
|
|
|
|
|
|
|
|
del fetched_events[bad_event_id]
|
|
|
|
|
|
|
|
# if we couldn't get the prev event in question, that's a problem.
|
|
|
|
remote_event = fetched_events.get(event_id)
|
|
|
|
if not remote_event:
|
|
|
|
raise Exception("Unable to get missing prev_event %s" % (event_id,))
|
|
|
|
|
|
|
|
# missing state at that event is a warning, not a blocker
|
|
|
|
# XXX: this doesn't sound right? it means that we'll end up with incomplete
|
|
|
|
# state.
|
|
|
|
failed_to_fetch = desired_events - fetched_events.keys()
|
|
|
|
if failed_to_fetch:
|
|
|
|
logger.warning(
|
|
|
|
"Failed to fetch missing state events for %s %s",
|
|
|
|
event_id,
|
|
|
|
failed_to_fetch,
|
|
|
|
)
|
|
|
|
|
|
|
|
remote_state = [
|
|
|
|
fetched_events[e_id] for e_id in state_event_ids if e_id in fetched_events
|
|
|
|
]
|
|
|
|
|
|
|
|
if remote_event.is_state() and remote_event.rejected_reason is None:
|
|
|
|
remote_state.append(remote_event)
|
|
|
|
|
|
|
|
return remote_state
|
|
|
|
|
2019-12-16 07:26:28 -05:00
|
|
|
async def _process_received_pdu(
|
|
|
|
self,
|
|
|
|
origin: str,
|
|
|
|
event: EventBase,
|
|
|
|
state: Optional[Iterable[EventBase]],
|
2021-04-06 07:21:57 -04:00
|
|
|
) -> None:
|
2017-03-09 11:20:13 -05:00
|
|
|
"""Called when we have a new pdu. We need to do auth checks and put it
|
|
|
|
through the StateHandler.
|
2019-12-16 07:26:28 -05:00
|
|
|
|
|
|
|
Args:
|
|
|
|
origin: server sending the event
|
|
|
|
|
|
|
|
event: event to be persisted
|
|
|
|
|
|
|
|
state: Normally None, but if we are handling a gap in the graph
|
|
|
|
(ie, we are missing one or more prev_events), the resolved state at the
|
|
|
|
event
|
2014-08-26 14:49:42 -04:00
|
|
|
"""
|
2021-03-12 10:08:03 -05:00
|
|
|
logger.debug("Processing event: %s", event)
|
2014-10-16 11:56:51 -04:00
|
|
|
|
2018-11-09 09:58:09 -05:00
|
|
|
try:
|
2021-04-14 12:35:28 -04:00
|
|
|
context = await self.state_handler.compute_event_context(
|
|
|
|
event, old_state=state
|
|
|
|
)
|
|
|
|
await self._auth_and_persist_event(origin, event, context, state=state)
|
2018-11-09 09:58:09 -05:00
|
|
|
except AuthError as e:
|
|
|
|
raise FederationError("ERROR", e.code, e.msg, affected=event.event_id)
|
2014-12-16 10:24:03 -05:00
|
|
|
|
2020-01-28 09:43:21 -05:00
|
|
|
# For encrypted messages we check that we know about the sending device,
|
|
|
|
# if we don't then we mark the device cache for that user as stale.
|
2020-02-04 12:25:54 -05:00
|
|
|
if event.type == EventTypes.Encrypted:
|
2020-01-28 09:43:21 -05:00
|
|
|
device_id = event.content.get("device_id")
|
2020-02-05 09:02:39 -05:00
|
|
|
sender_key = event.content.get("sender_key")
|
|
|
|
|
|
|
|
cached_devices = await self.store.get_cached_devices_for_user(event.sender)
|
|
|
|
|
|
|
|
resync = False # Whether we should resync device lists.
|
|
|
|
|
|
|
|
device = None
|
2020-01-28 09:43:21 -05:00
|
|
|
if device_id is not None:
|
2020-02-05 09:02:39 -05:00
|
|
|
device = cached_devices.get(device_id)
|
|
|
|
if device is None:
|
2020-01-28 09:43:21 -05:00
|
|
|
logger.info(
|
|
|
|
"Received event from remote device not in our cache: %s %s",
|
|
|
|
event.sender,
|
|
|
|
device_id,
|
|
|
|
)
|
2020-02-05 09:02:39 -05:00
|
|
|
resync = True
|
|
|
|
|
|
|
|
# We also check if the `sender_key` matches what we expect.
|
|
|
|
if sender_key is not None:
|
|
|
|
# Figure out what sender key we're expecting. If we know the
|
|
|
|
# device and recognize the algorithm then we can work out the
|
|
|
|
# exact key to expect. Otherwise check it matches any key we
|
|
|
|
# have for that device.
|
2020-07-01 11:21:02 -04:00
|
|
|
|
2021-07-16 13:22:36 -04:00
|
|
|
current_keys: Container[str] = []
|
2020-07-01 11:21:02 -04:00
|
|
|
|
2020-02-05 09:02:39 -05:00
|
|
|
if device:
|
|
|
|
keys = device.get("keys", {}).get("keys", {})
|
|
|
|
|
2020-06-10 12:44:34 -04:00
|
|
|
if (
|
|
|
|
event.content.get("algorithm")
|
|
|
|
== RoomEncryptionAlgorithms.MEGOLM_V1_AES_SHA2
|
|
|
|
):
|
2020-02-05 09:02:39 -05:00
|
|
|
# For this algorithm we expect a curve25519 key.
|
|
|
|
key_name = "curve25519:%s" % (device_id,)
|
|
|
|
current_keys = [keys.get(key_name)]
|
|
|
|
else:
|
|
|
|
# We don't know understand the algorithm, so we just
|
|
|
|
# check it matches a key for the device.
|
|
|
|
current_keys = keys.values()
|
|
|
|
elif device_id:
|
|
|
|
# We don't have any keys for the device ID.
|
2020-07-01 11:21:02 -04:00
|
|
|
pass
|
2020-02-05 09:02:39 -05:00
|
|
|
else:
|
|
|
|
# The event didn't include a device ID, so we just look for
|
|
|
|
# keys across all devices.
|
2020-07-01 11:21:02 -04:00
|
|
|
current_keys = [
|
2020-02-05 09:02:39 -05:00
|
|
|
key
|
2020-09-03 10:38:32 -04:00
|
|
|
for device in cached_devices.values()
|
2020-02-05 09:02:39 -05:00
|
|
|
for key in device.get("keys", {}).get("keys", {}).values()
|
2020-07-01 11:21:02 -04:00
|
|
|
]
|
2020-01-30 12:06:38 -05:00
|
|
|
|
2020-02-05 09:02:39 -05:00
|
|
|
# We now check that the sender key matches (one of) the expected
|
|
|
|
# keys.
|
|
|
|
if sender_key not in current_keys:
|
|
|
|
logger.info(
|
|
|
|
"Received event from remote device with unexpected sender key: %s %s: %s",
|
|
|
|
event.sender,
|
|
|
|
device_id or "<no device_id>",
|
|
|
|
sender_key,
|
|
|
|
)
|
|
|
|
resync = True
|
|
|
|
|
|
|
|
if resync:
|
2020-07-10 13:23:17 -04:00
|
|
|
run_as_background_process(
|
|
|
|
"resync_device_due_to_pdu", self._resync_device, event.sender
|
|
|
|
)
|
2020-02-05 09:02:39 -05:00
|
|
|
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
await self._handle_marker_event(origin, event)
|
|
|
|
|
|
|
|
async def _handle_marker_event(self, origin: str, marker_event: EventBase):
|
|
|
|
"""Handles backfilling the insertion event when we receive a marker
|
|
|
|
event that points to one.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
origin: Origin of the event. Will be called to get the insertion event
|
|
|
|
marker_event: The event to process
|
|
|
|
"""
|
|
|
|
|
|
|
|
if marker_event.type != EventTypes.MSC2716_MARKER:
|
|
|
|
# Not a marker event
|
|
|
|
return
|
|
|
|
|
|
|
|
if marker_event.rejected_reason is not None:
|
|
|
|
# Rejected event
|
|
|
|
return
|
|
|
|
|
|
|
|
# Skip processing a marker event if the room version doesn't
|
|
|
|
# support it.
|
|
|
|
room_version = await self.store.get_room_version(marker_event.room_id)
|
|
|
|
if not room_version.msc2716_historical:
|
|
|
|
return
|
|
|
|
|
|
|
|
logger.debug("_handle_marker_event: received %s", marker_event)
|
|
|
|
|
|
|
|
insertion_event_id = marker_event.content.get(
|
|
|
|
EventContentFields.MSC2716_MARKER_INSERTION
|
|
|
|
)
|
|
|
|
|
|
|
|
if insertion_event_id is None:
|
|
|
|
# Nothing to retrieve then (invalid marker)
|
|
|
|
return
|
|
|
|
|
|
|
|
logger.debug(
|
|
|
|
"_handle_marker_event: backfilling insertion event %s", insertion_event_id
|
|
|
|
)
|
|
|
|
|
|
|
|
await self._get_events_and_persist(
|
|
|
|
origin,
|
|
|
|
marker_event.room_id,
|
|
|
|
[insertion_event_id],
|
|
|
|
)
|
|
|
|
|
|
|
|
insertion_event = await self.store.get_event(
|
|
|
|
insertion_event_id, allow_none=True
|
|
|
|
)
|
|
|
|
if insertion_event is None:
|
|
|
|
logger.warning(
|
|
|
|
"_handle_marker_event: server %s didn't return insertion event %s for marker %s",
|
|
|
|
origin,
|
|
|
|
insertion_event_id,
|
|
|
|
marker_event.event_id,
|
|
|
|
)
|
|
|
|
return
|
|
|
|
|
|
|
|
logger.debug(
|
|
|
|
"_handle_marker_event: succesfully backfilled insertion event %s from marker event %s",
|
|
|
|
insertion_event,
|
|
|
|
marker_event,
|
|
|
|
)
|
|
|
|
|
|
|
|
await self.store.insert_insertion_extremity(
|
|
|
|
insertion_event_id, marker_event.room_id
|
|
|
|
)
|
|
|
|
|
|
|
|
logger.debug(
|
|
|
|
"_handle_marker_event: insertion extremity added for %s from marker event %s",
|
|
|
|
insertion_event,
|
|
|
|
marker_event,
|
|
|
|
)
|
|
|
|
|
2020-07-10 13:23:17 -04:00
|
|
|
async def _resync_device(self, sender: str) -> None:
|
|
|
|
"""We have detected that the device list for the given user may be out
|
|
|
|
of sync, so we try and resync them.
|
|
|
|
"""
|
|
|
|
|
|
|
|
try:
|
|
|
|
await self.store.mark_remote_user_device_cache_as_stale(sender)
|
|
|
|
|
|
|
|
# Immediately attempt a resync in the background
|
|
|
|
if self.config.worker_app:
|
|
|
|
await self._user_device_resync(user_id=sender)
|
|
|
|
else:
|
|
|
|
await self._device_list_updater.user_device_resync(sender)
|
|
|
|
except Exception:
|
|
|
|
logger.exception("Failed to resync device for %s", sender)
|
2020-01-28 09:43:21 -05:00
|
|
|
|
2014-08-19 09:20:03 -04:00
|
|
|
@log_function
|
2021-04-06 07:21:57 -04:00
|
|
|
async def backfill(
|
|
|
|
self, dest: str, room_id: str, limit: int, extremities: List[str]
|
|
|
|
) -> List[EventBase]:
|
2014-11-12 11:20:21 -05:00
|
|
|
"""Trigger a backfill request to `dest` for the given `room_id`
|
2016-04-12 07:04:19 -04:00
|
|
|
|
2018-04-17 18:41:36 -04:00
|
|
|
This will attempt to get more events from the remote. If the other side
|
|
|
|
has no new events to offer, this will return an empty list.
|
|
|
|
|
|
|
|
As the events are received, we check their signatures, and also do some
|
|
|
|
sanity-checking on them. If any of the backfilled events are invalid,
|
|
|
|
this method throws a SynapseError.
|
|
|
|
|
|
|
|
TODO: make this more useful to distinguish failures of the remote
|
|
|
|
server from invalid events (there is probably no point in trying to
|
|
|
|
re-fetch invalid events from every other HS in the room.)
|
2014-11-12 11:20:21 -05:00
|
|
|
"""
|
2016-04-05 07:56:29 -04:00
|
|
|
if dest == self.server_name:
|
|
|
|
raise SynapseError(400, "Can't backfill from self.")
|
|
|
|
|
2019-12-10 11:54:34 -05:00
|
|
|
events = await self.federation_client.backfill(
|
2014-11-10 06:59:51 -05:00
|
|
|
dest, room_id, limit=limit, extremities=extremities
|
2014-10-31 05:59:02 -04:00
|
|
|
)
|
2014-08-26 14:49:42 -04:00
|
|
|
|
2020-09-29 10:57:36 -04:00
|
|
|
if not events:
|
|
|
|
return []
|
|
|
|
|
2018-04-20 06:41:03 -04:00
|
|
|
# ideally we'd sanity check the events here for excess prev_events etc,
|
|
|
|
# but it's hard to reject events at this point without completely
|
|
|
|
# breaking backfill in the same way that it is currently broken by
|
|
|
|
# events whose signature we cannot verify (#3121).
|
|
|
|
#
|
|
|
|
# So for now we accept the events anyway. #3124 tracks this.
|
|
|
|
#
|
|
|
|
# for ev in events:
|
|
|
|
# self._sanity_check_event(ev)
|
2018-04-17 18:41:12 -04:00
|
|
|
|
2016-04-12 06:54:41 -04:00
|
|
|
# Don't bother processing events we already have.
|
2019-12-10 11:54:34 -05:00
|
|
|
seen_events = await self.store.have_events_in_timeline(
|
2020-02-21 07:15:07 -05:00
|
|
|
{e.event_id for e in events}
|
2016-04-12 06:19:10 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
events = [e for e in events if e.event_id not in seen_events]
|
|
|
|
|
|
|
|
if not events:
|
2019-07-23 09:00:55 -04:00
|
|
|
return []
|
2016-04-12 06:19:10 -04:00
|
|
|
|
2015-05-20 06:59:02 -04:00
|
|
|
event_map = {e.event_id: e for e in events}
|
2014-08-26 14:49:42 -04:00
|
|
|
|
2020-02-21 07:15:07 -05:00
|
|
|
event_ids = {e.event_id for e in events}
|
2014-10-15 11:06:59 -04:00
|
|
|
|
2019-12-16 07:26:28 -05:00
|
|
|
# build a list of events whose prev_events weren't in the batch.
|
|
|
|
# (XXX: this will include events whose prev_events we already have; that doesn't
|
|
|
|
# sound right?)
|
2018-11-05 08:35:15 -05:00
|
|
|
edges = [ev.event_id for ev in events if set(ev.prev_event_ids()) - event_ids]
|
2014-10-15 11:06:59 -04:00
|
|
|
|
2015-06-02 05:28:14 -04:00
|
|
|
logger.info("backfill: Got %d events with %d edges", len(events), len(edges))
|
|
|
|
|
2015-05-20 06:59:02 -04:00
|
|
|
# For each edge get the current state.
|
2014-10-15 11:06:59 -04:00
|
|
|
|
2015-06-02 05:11:32 -04:00
|
|
|
state_events = {}
|
2015-05-20 06:59:02 -04:00
|
|
|
events_to_state = {}
|
|
|
|
for e_id in edges:
|
2021-05-10 08:29:02 -04:00
|
|
|
state = await self._get_state_for_room(
|
2019-12-20 04:55:45 -05:00
|
|
|
destination=dest,
|
|
|
|
room_id=room_id,
|
|
|
|
event_id=e_id,
|
2015-05-20 06:59:02 -04:00
|
|
|
)
|
2015-06-02 05:11:32 -04:00
|
|
|
state_events.update({s.event_id: s for s in state})
|
2015-05-20 06:59:02 -04:00
|
|
|
events_to_state[e_id] = state
|
|
|
|
|
2020-02-21 07:15:07 -05:00
|
|
|
required_auth = {
|
2016-08-05 07:59:04 -04:00
|
|
|
a_id
|
2021-05-10 08:29:02 -04:00
|
|
|
for event in events + list(state_events.values())
|
2018-11-05 08:35:15 -05:00
|
|
|
for a_id in event.auth_event_ids()
|
2020-02-21 07:15:07 -05:00
|
|
|
}
|
2021-05-10 08:29:02 -04:00
|
|
|
auth_events = await self.store.get_events(required_auth, allow_rejected=True)
|
2016-08-05 07:59:04 -04:00
|
|
|
auth_events.update(
|
|
|
|
{e_id: event_map[e_id] for e_id in required_auth if e_id in event_map}
|
|
|
|
)
|
2019-02-25 05:02:12 -05:00
|
|
|
|
2015-06-25 12:18:19 -04:00
|
|
|
ev_infos = []
|
2019-02-22 06:33:51 -05:00
|
|
|
|
2019-12-16 07:26:28 -05:00
|
|
|
# Step 1: persist the events in the chunk we fetched state for (i.e.
|
|
|
|
# the backwards extremities), with custom auth events and state
|
2015-06-25 12:18:19 -04:00
|
|
|
for e_id in events_to_state:
|
2019-02-25 05:02:12 -05:00
|
|
|
# For paranoia we ensure that these events are marked as
|
|
|
|
# non-outliers
|
|
|
|
ev = event_map[e_id]
|
2019-02-25 11:32:02 -05:00
|
|
|
assert not ev.internal_metadata.is_outlier()
|
2019-06-20 05:32:02 -04:00
|
|
|
|
2015-06-25 12:18:19 -04:00
|
|
|
ev_infos.append(
|
2019-12-05 10:02:35 -05:00
|
|
|
_NewEventInfo(
|
|
|
|
event=ev,
|
|
|
|
state=events_to_state[e_id],
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map={
|
2015-06-25 12:18:19 -04:00
|
|
|
(
|
|
|
|
auth_events[a_id].type,
|
|
|
|
auth_events[a_id].state_key,
|
|
|
|
): auth_events[a_id]
|
2019-02-25 05:02:12 -05:00
|
|
|
for a_id in ev.auth_event_ids()
|
2016-08-05 07:59:04 -04:00
|
|
|
if a_id in auth_events
|
2019-06-20 05:32:02 -04:00
|
|
|
},
|
2019-12-05 10:02:35 -05:00
|
|
|
)
|
2015-06-25 12:18:19 -04:00
|
|
|
)
|
2015-05-20 06:59:02 -04:00
|
|
|
|
2020-09-14 05:16:41 -04:00
|
|
|
if ev_infos:
|
2021-04-14 12:35:28 -04:00
|
|
|
await self._auth_and_persist_events(
|
|
|
|
dest, room_id, ev_infos, backfilled=True
|
|
|
|
)
|
2016-04-12 06:19:10 -04:00
|
|
|
|
2019-02-25 09:45:02 -05:00
|
|
|
# Step 2: Persist the rest of the events in the chunk one by one
|
2015-05-20 06:59:02 -04:00
|
|
|
events.sort(key=lambda e: e.depth)
|
|
|
|
|
|
|
|
for event in events:
|
|
|
|
if event in events_to_state:
|
|
|
|
continue
|
|
|
|
|
2019-02-25 05:02:12 -05:00
|
|
|
# For paranoia we ensure that these events are marked as
|
|
|
|
# non-outliers
|
2019-02-25 09:42:11 -05:00
|
|
|
assert not event.internal_metadata.is_outlier()
|
2019-02-25 05:02:12 -05:00
|
|
|
|
2021-04-14 12:35:28 -04:00
|
|
|
context = await self.state_handler.compute_event_context(event)
|
|
|
|
|
2016-04-12 07:48:30 -04:00
|
|
|
# We store these one at a time since each event depends on the
|
|
|
|
# previous to work out the state.
|
|
|
|
# TODO: We can probably do something more clever here.
|
2021-04-14 12:35:28 -04:00
|
|
|
await self._auth_and_persist_event(dest, event, context, backfilled=True)
|
2014-08-26 14:49:42 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return events
|
2014-08-26 14:49:42 -04:00
|
|
|
|
2020-09-18 09:25:52 -04:00
|
|
|
async def maybe_backfill(
|
|
|
|
self, room_id: str, current_depth: int, limit: int
|
|
|
|
) -> bool:
|
2015-05-12 05:35:45 -04:00
|
|
|
"""Checks the database to see if we should backfill before paginating,
|
|
|
|
and if so do.
|
2020-09-18 09:25:52 -04:00
|
|
|
|
|
|
|
Args:
|
|
|
|
room_id
|
|
|
|
current_depth: The depth from which we're paginating from. This is
|
|
|
|
used to decide if we should backfill and what extremities to
|
|
|
|
use.
|
|
|
|
limit: The number of events that the pagination request will
|
|
|
|
return. This is used as part of the heuristic to decide if we
|
|
|
|
should back paginate.
|
2015-05-11 13:01:31 -04:00
|
|
|
"""
|
2021-06-04 05:47:58 -04:00
|
|
|
with (await self._room_backfill.queue(room_id)):
|
|
|
|
return await self._maybe_backfill_inner(room_id, current_depth, limit)
|
|
|
|
|
|
|
|
async def _maybe_backfill_inner(
|
|
|
|
self, room_id: str, current_depth: int, limit: int
|
|
|
|
) -> bool:
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
oldest_events_with_depth = (
|
|
|
|
await self.store.get_oldest_event_ids_with_depth_in_room(room_id)
|
|
|
|
)
|
|
|
|
insertion_events_to_be_backfilled = (
|
|
|
|
await self.store.get_insertion_event_backwards_extremities_in_room(room_id)
|
|
|
|
)
|
|
|
|
logger.debug(
|
|
|
|
"_maybe_backfill_inner: extremities oldest_events_with_depth=%s insertion_events_to_be_backfilled=%s",
|
|
|
|
oldest_events_with_depth,
|
|
|
|
insertion_events_to_be_backfilled,
|
|
|
|
)
|
2015-05-11 13:01:31 -04:00
|
|
|
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
if not oldest_events_with_depth and not insertion_events_to_be_backfilled:
|
2015-05-12 05:35:45 -04:00
|
|
|
logger.debug("Not backfilling as no extremeties found.")
|
2020-09-18 09:25:52 -04:00
|
|
|
return False
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-02-20 11:54:35 -05:00
|
|
|
# We only want to paginate if we can actually see the events we'll get,
|
|
|
|
# as otherwise we'll just spend a lot of resources to get redacted
|
|
|
|
# events.
|
|
|
|
#
|
2019-03-05 04:16:35 -05:00
|
|
|
# We do this by filtering all the backwards extremities and seeing if
|
|
|
|
# any remain. Given we don't have the extremity events themselves, we
|
|
|
|
# need to actually check the events that reference them.
|
2019-02-27 08:06:10 -05:00
|
|
|
#
|
|
|
|
# *Note*: the spec wants us to keep backfilling until we reach the start
|
|
|
|
# of the room in case we are allowed to see some of the history. However
|
|
|
|
# in practice that causes more issues than its worth, as a) its
|
|
|
|
# relatively rare for there to be any visible history and b) even when
|
|
|
|
# there is its often sufficiently long ago that clients would stop
|
|
|
|
# attempting to paginate before backfill reached the visible history.
|
|
|
|
#
|
2019-03-05 04:16:35 -05:00
|
|
|
# TODO: If we do do a backfill then we should filter the backwards
|
|
|
|
# extremities to only include those that point to visible portions of
|
|
|
|
# history.
|
2019-02-20 11:54:35 -05:00
|
|
|
#
|
|
|
|
# TODO: Correctly handle the case where we are allowed to see the
|
2019-03-05 04:16:35 -05:00
|
|
|
# forward event but not the backward extremity, e.g. in the case of
|
|
|
|
# initial join of the server where we are allowed to see the join
|
|
|
|
# event but not anything before it. This would require looking at the
|
|
|
|
# state *before* the event, ignoring the special casing certain event
|
|
|
|
# types have.
|
2019-02-20 11:54:35 -05:00
|
|
|
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
forward_event_ids = await self.store.get_successor_events(
|
|
|
|
list(oldest_events_with_depth)
|
|
|
|
)
|
2019-02-20 11:54:35 -05:00
|
|
|
|
2019-12-10 11:54:34 -05:00
|
|
|
extremities_events = await self.store.get_events(
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
forward_event_ids,
|
2019-12-11 08:39:47 -05:00
|
|
|
redact_behaviour=EventRedactBehaviour.AS_IS,
|
|
|
|
get_prev_content=False,
|
2019-02-20 11:54:35 -05:00
|
|
|
)
|
|
|
|
|
2019-03-04 09:34:34 -05:00
|
|
|
# We set `check_history_visibility_only` as we might otherwise get false
|
|
|
|
# positives from users having been erased.
|
2019-12-10 11:54:34 -05:00
|
|
|
filtered_extremities = await filter_events_for_server(
|
2019-10-23 12:25:54 -04:00
|
|
|
self.storage,
|
2019-02-20 11:54:35 -05:00
|
|
|
self.server_name,
|
|
|
|
list(extremities_events.values()),
|
2019-03-04 09:34:34 -05:00
|
|
|
redact=False,
|
|
|
|
check_history_visibility_only=True,
|
2019-02-20 11:54:35 -05:00
|
|
|
)
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
logger.debug(
|
|
|
|
"_maybe_backfill_inner: filtered_extremities %s", filtered_extremities
|
|
|
|
)
|
2019-02-20 11:54:35 -05:00
|
|
|
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
if not filtered_extremities and not insertion_events_to_be_backfilled:
|
2019-07-23 09:00:55 -04:00
|
|
|
return False
|
2019-02-20 11:54:35 -05:00
|
|
|
|
Add support for MSC2716 marker events (#10498)
* Make historical messages available to federated servers
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Follow-up to https://github.com/matrix-org/synapse/pull/9247
* Debug message not available on federation
* Add base starting insertion point when no chunk ID is provided
* Fix messages from multiple senders in historical chunk
Follow-up to https://github.com/matrix-org/synapse/pull/9247
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
---
Previously, Synapse would throw a 403,
`Cannot force another user to join.`,
because we were trying to use `?user_id` from a single virtual user
which did not match with messages from other users in the chunk.
* Remove debug lines
* Messing with selecting insertion event extremeties
* Move db schema change to new version
* Add more better comments
* Make a fake requester with just what we need
See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080
* Store insertion events in table
* Make base insertion event float off on its own
See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889
Conflicts:
synapse/rest/client/v1/room.py
* Validate that the app service can actually control the given user
See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455
Conflicts:
synapse/rest/client/v1/room.py
* Add some better comments on what we're trying to check for
* Continue debugging
* Share validation logic
* Add inserted historical messages to /backfill response
* Remove debug sql queries
* Some marker event implemntation trials
* Clean up PR
* Rename insertion_event_id to just event_id
* Add some better sql comments
* More accurate description
* Add changelog
* Make it clear what MSC the change is part of
* Add more detail on which insertion event came through
* Address review and improve sql queries
* Only use event_id as unique constraint
* Fix test case where insertion event is already in the normal DAG
* Remove debug changes
* Add support for MSC2716 marker events
* Process markers when we receive it over federation
* WIP: make hs2 backfill historical messages after marker event
* hs2 to better ask for insertion event extremity
But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`
error
* Add insertion_event_extremities table
* Switch to chunk events so we can auth via power_levels
Previously, we were using `content.chunk_id` to connect one
chunk to another. But these events can be from any `sender`
and we can't tell who should be able to send historical events.
We know we only want the application service to do it but these
events have the sender of a real historical message, not the
application service user ID as the sender. Other federated homeservers
also have no indicator which senders are an application service on
the originating homeserver.
So we want to auth all of the MSC2716 events via power_levels
and have them be sent by the application service with proper
PL levels in the room.
* Switch to chunk events for federation
* Add unstable room version to support new historical PL
* Messy: Fix undefined state_group for federated historical events
```
2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill
await self.backfill(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill
await self._auth_and_persist_event(dest, event, context, backfilled=True)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event
await self._run_push_actions_and_persist_event(event, context, backfilled)
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event
await self.persist_events_and_notify(
File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify
events, max_stream_token = await self.storage.persistence.persist_events(
File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner
return await func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events
ret_vals = await yieldable_gather_results(enqueue, partitioned.items())
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop
ret = await self._per_item_callback(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch
await self.persist_events_store._persist_events_and_state_updates(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates
await self.db_pool.runInteraction(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction
result = await self.runWithConnection(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection
return await make_deferred_yieldable(
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext
result = inContext.theWork() # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda>
inContext.theWork = lambda: context.call( # type: ignore[attr-defined]
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext
return func(*args, **kw)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection
compat.reraise(excValue, excTraceback)
File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction
return function(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise
raise exception.with_traceback(traceback)
File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection
result = func(conn, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func
return func(db_conn, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction
r = func(cursor, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped
return f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn
self._store_event_state_mappings_txn(txn, events_and_contexts)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn
self.db_pool.simple_insert_many_txn(
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn
txn.execute_batch(sql, vals)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch
self.executemany(sql, args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute
return func(sql, *args)
sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group
```
* Revert "Messy: Fix undefined state_group for federated historical events"
This reverts commit 187ab28611546321e02770944c86f30ee2bc742a.
* Fix federated events being rejected for no state_groups
Add fix from https://github.com/matrix-org/synapse/pull/10439
until it merges.
* Adapting to experimental room version
* Some log cleanup
* Add better comments around extremity fetching code and why
* Rename to be more accurate to what the function returns
* Add changelog
* Ignore rejected events
* Use simplified upsert
* Add Erik's explanation of extra event checks
See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332
* Clarify that the depth is not directly correlated to the backwards extremity that we return
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404
* lock only matters for sqlite
See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061
* Move new SQL changes to its own delta file
* Clean up upsert docstring
* Bump database schema version (62)
2021-08-04 13:07:57 -04:00
|
|
|
extremities = {
|
|
|
|
**oldest_events_with_depth,
|
|
|
|
# TODO: insertion_events_to_be_backfilled is currently skipping the filtered_extremities checks
|
|
|
|
**insertion_events_to_be_backfilled,
|
|
|
|
}
|
|
|
|
|
2015-05-11 13:01:31 -04:00
|
|
|
# Check if we reached a point where we should start backfilling.
|
|
|
|
sorted_extremeties_tuple = sorted(extremities.items(), key=lambda e: -int(e[1]))
|
|
|
|
max_depth = sorted_extremeties_tuple[0][1]
|
|
|
|
|
2020-09-18 09:25:52 -04:00
|
|
|
# If we're approaching an extremity we trigger a backfill, otherwise we
|
|
|
|
# no-op.
|
|
|
|
#
|
|
|
|
# We chose twice the limit here as then clients paginating backwards
|
|
|
|
# will send pagination requests that trigger backfill at least twice
|
|
|
|
# using the most recent extremity before it gets removed (see below). We
|
|
|
|
# chose more than one times the limit in case of failure, but choosing a
|
|
|
|
# much larger factor will result in triggering a backfill request much
|
|
|
|
# earlier than necessary.
|
|
|
|
if current_depth - 2 * limit > max_depth:
|
|
|
|
logger.debug(
|
|
|
|
"Not backfilling as we don't need to. %d < %d - 2 * %d",
|
|
|
|
max_depth,
|
|
|
|
current_depth,
|
|
|
|
limit,
|
|
|
|
)
|
|
|
|
return False
|
|
|
|
|
|
|
|
logger.debug(
|
|
|
|
"room_id: %s, backfill: current_depth: %s, max_depth: %s, extrems: %s",
|
|
|
|
room_id,
|
|
|
|
current_depth,
|
|
|
|
max_depth,
|
|
|
|
sorted_extremeties_tuple,
|
|
|
|
)
|
|
|
|
|
|
|
|
# We ignore extremities that have a greater depth than our current depth
|
|
|
|
# as:
|
|
|
|
# 1. we don't really care about getting events that have happened
|
|
|
|
# before our current position; and
|
|
|
|
# 2. we have likely previously tried and failed to backfill from that
|
|
|
|
# extremity, so to avoid getting "stuck" requesting the same
|
|
|
|
# backfill repeatedly we drop those extremities.
|
|
|
|
filtered_sorted_extremeties_tuple = [
|
|
|
|
t for t in sorted_extremeties_tuple if int(t[1]) <= current_depth
|
|
|
|
]
|
|
|
|
|
|
|
|
# However, we need to check that the filtered extremities are non-empty.
|
|
|
|
# If they are empty then either we can a) bail or b) still attempt to
|
|
|
|
# backill. We opt to try backfilling anyway just in case we do get
|
|
|
|
# relevant events.
|
|
|
|
if filtered_sorted_extremeties_tuple:
|
|
|
|
sorted_extremeties_tuple = filtered_sorted_extremeties_tuple
|
|
|
|
|
2016-08-16 06:34:36 -04:00
|
|
|
# We don't want to specify too many extremities as it causes the backfill
|
|
|
|
# request URI to be too long.
|
|
|
|
extremities = dict(sorted_extremeties_tuple[:5])
|
|
|
|
|
2015-05-11 13:01:31 -04:00
|
|
|
# Now we need to decide which hosts to hit first.
|
|
|
|
|
2015-05-12 05:35:45 -04:00
|
|
|
# First we try hosts that are already in the room
|
|
|
|
# TODO: HEURISTIC ALERT.
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-12-10 11:54:34 -05:00
|
|
|
curr_state = await self.state_handler.get_current_state(room_id)
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
def get_domains_from_state(state: StateMap[EventBase]) -> List[Tuple[str, int]]:
|
2018-05-22 11:23:39 -04:00
|
|
|
"""Get joined domains from state
|
|
|
|
|
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
state: State map from type/state key to event.
|
2018-05-22 11:23:39 -04:00
|
|
|
|
|
|
|
Returns:
|
2021-04-06 07:21:57 -04:00
|
|
|
Returns a list of servers with the lowest depth of their joins.
|
|
|
|
Sorted by lowest depth first.
|
2018-05-22 11:23:39 -04:00
|
|
|
"""
|
2015-05-11 13:01:31 -04:00
|
|
|
joined_users = [
|
|
|
|
(state_key, int(event.depth))
|
2020-06-15 07:03:36 -04:00
|
|
|
for (e_type, state_key), event in state.items()
|
2015-05-11 13:01:31 -04:00
|
|
|
if e_type == EventTypes.Member and event.membership == Membership.JOIN
|
|
|
|
]
|
|
|
|
|
2021-07-16 13:22:36 -04:00
|
|
|
joined_domains: Dict[str, int] = {}
|
2015-05-11 13:01:31 -04:00
|
|
|
for u, d in joined_users:
|
|
|
|
try:
|
2016-05-16 14:17:03 -04:00
|
|
|
dom = get_domain_from_id(u)
|
2015-05-11 13:01:31 -04:00
|
|
|
old_d = joined_domains.get(dom)
|
|
|
|
if old_d:
|
|
|
|
joined_domains[dom] = min(d, old_d)
|
|
|
|
else:
|
|
|
|
joined_domains[dom] = d
|
2017-10-23 10:52:32 -04:00
|
|
|
except Exception:
|
2015-05-11 13:01:31 -04:00
|
|
|
pass
|
|
|
|
|
2018-07-21 01:47:18 -04:00
|
|
|
return sorted(joined_domains.items(), key=lambda d: d[1])
|
2015-05-11 13:01:31 -04:00
|
|
|
|
|
|
|
curr_domains = get_domains_from_state(curr_state)
|
|
|
|
|
|
|
|
likely_domains = [
|
|
|
|
domain for domain, depth in curr_domains if domain != self.server_name
|
|
|
|
]
|
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def try_backfill(domains: List[str]) -> bool:
|
2015-05-11 13:01:31 -04:00
|
|
|
# TODO: Should we try multiple of these at a time?
|
|
|
|
for dom in domains:
|
2015-05-12 05:35:45 -04:00
|
|
|
try:
|
2019-12-10 11:54:34 -05:00
|
|
|
await self.backfill(
|
2018-05-22 14:02:48 -04:00
|
|
|
dom, room_id, limit=100, extremities=extremities
|
2015-05-12 05:35:45 -04:00
|
|
|
)
|
2016-04-12 07:04:19 -04:00
|
|
|
# If this succeeded then we probably already have the
|
|
|
|
# appropriate stuff.
|
2016-04-12 07:48:30 -04:00
|
|
|
# TODO: We can probably do something more intelligent here.
|
2019-07-23 09:00:55 -04:00
|
|
|
return True
|
2016-03-07 15:13:10 -05:00
|
|
|
except SynapseError as e:
|
2020-05-22 06:39:20 -04:00
|
|
|
logger.info("Failed to backfill from %s because %s", dom, e)
|
|
|
|
continue
|
|
|
|
except HttpResponseException as e:
|
|
|
|
if 400 <= e.code < 500:
|
|
|
|
raise e.to_synapse_error()
|
|
|
|
|
2015-05-12 09:09:54 -04:00
|
|
|
logger.info("Failed to backfill from %s because %s", dom, e)
|
2015-05-12 05:35:45 -04:00
|
|
|
continue
|
|
|
|
except CodeMessageException as e:
|
|
|
|
if 400 <= e.code < 500:
|
|
|
|
raise
|
|
|
|
|
2015-05-12 09:09:54 -04:00
|
|
|
logger.info("Failed to backfill from %s because %s", dom, e)
|
2015-05-12 05:35:45 -04:00
|
|
|
continue
|
|
|
|
except NotRetryingDestination as e:
|
2018-09-06 10:22:23 -04:00
|
|
|
logger.info(str(e))
|
2015-05-12 05:35:45 -04:00
|
|
|
continue
|
2019-07-30 08:19:22 -04:00
|
|
|
except RequestSendFailed as e:
|
2020-10-23 12:38:40 -04:00
|
|
|
logger.info("Failed to get backfill from %s because %s", dom, e)
|
2019-07-30 08:19:22 -04:00
|
|
|
continue
|
2018-01-22 13:11:18 -05:00
|
|
|
except FederationDeniedError as e:
|
|
|
|
logger.info(e)
|
|
|
|
continue
|
2015-05-12 05:35:45 -04:00
|
|
|
except Exception as e:
|
2015-05-12 09:09:54 -04:00
|
|
|
logger.exception("Failed to backfill from %s because %s", dom, e)
|
2015-05-12 05:35:45 -04:00
|
|
|
continue
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return False
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-12-10 11:54:34 -05:00
|
|
|
success = await try_backfill(likely_domains)
|
2015-05-11 13:01:31 -04:00
|
|
|
if success:
|
2019-07-23 09:00:55 -04:00
|
|
|
return True
|
2015-05-11 13:01:31 -04:00
|
|
|
|
|
|
|
# Huh, well *those* domains didn't work out. Lets try some domains
|
|
|
|
# from the time.
|
|
|
|
|
|
|
|
tried_domains = set(likely_domains)
|
2015-05-12 11:19:42 -04:00
|
|
|
tried_domains.add(self.server_name)
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2018-07-21 01:47:18 -04:00
|
|
|
event_ids = list(extremities.keys())
|
2015-05-12 08:58:14 -04:00
|
|
|
|
2017-01-17 12:07:15 -05:00
|
|
|
logger.debug("calling resolve_state_groups in _maybe_backfill")
|
2019-07-03 10:07:04 -04:00
|
|
|
resolve = preserve_fn(self.state_handler.resolve_state_groups_for_events)
|
2019-12-10 11:54:34 -05:00
|
|
|
states = await make_deferred_yieldable(
|
2017-10-06 17:14:24 -04:00
|
|
|
defer.gatherResults(
|
2018-01-27 03:48:41 -05:00
|
|
|
[resolve(room_id, [e]) for e in event_ids], consumeErrors=True
|
2019-06-20 05:32:02 -04:00
|
|
|
)
|
2017-10-06 17:14:24 -04:00
|
|
|
)
|
2018-05-22 14:00:48 -04:00
|
|
|
|
|
|
|
# dict[str, dict[tuple, str]], a map from event_id to state map of
|
|
|
|
# event_ids.
|
2017-01-13 08:21:04 -05:00
|
|
|
states = dict(zip(event_ids, [s.state for s in states]))
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-12-10 11:54:34 -05:00
|
|
|
state_map = await self.store.get_events(
|
2020-06-15 07:03:36 -04:00
|
|
|
[e_id for ids in states.values() for e_id in ids.values()],
|
2016-08-25 08:28:31 -04:00
|
|
|
get_prev_content=False,
|
|
|
|
)
|
|
|
|
states = {
|
|
|
|
key: {
|
|
|
|
k: state_map[e_id]
|
2020-06-15 07:03:36 -04:00
|
|
|
for k, e_id in state_dict.items()
|
2016-08-25 08:28:31 -04:00
|
|
|
if e_id in state_map
|
2018-07-21 01:47:18 -04:00
|
|
|
}
|
2020-06-15 07:03:36 -04:00
|
|
|
for key, state_dict in states.items()
|
2016-08-25 08:28:31 -04:00
|
|
|
}
|
|
|
|
|
2015-05-11 13:01:31 -04:00
|
|
|
for e_id, _ in sorted_extremeties_tuple:
|
2021-04-06 07:21:57 -04:00
|
|
|
likely_extremeties_domains = get_domains_from_state(states[e_id])
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-12-10 11:54:34 -05:00
|
|
|
success = await try_backfill(
|
2021-04-06 07:21:57 -04:00
|
|
|
[
|
|
|
|
dom
|
|
|
|
for dom, _ in likely_extremeties_domains
|
|
|
|
if dom not in tried_domains
|
|
|
|
]
|
2015-05-11 13:01:31 -04:00
|
|
|
)
|
|
|
|
if success:
|
2019-07-23 09:00:55 -04:00
|
|
|
return True
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
tried_domains.update(dom for dom, _ in likely_extremeties_domains)
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return False
|
2015-05-11 13:01:31 -04:00
|
|
|
|
2019-12-16 07:26:28 -05:00
|
|
|
async def _get_events_and_persist(
|
|
|
|
self, destination: str, room_id: str, events: Iterable[str]
|
2021-04-06 07:21:57 -04:00
|
|
|
) -> None:
|
2019-12-16 07:26:28 -05:00
|
|
|
"""Fetch the given events from a server, and persist them as outliers.
|
|
|
|
|
2020-07-10 13:15:35 -04:00
|
|
|
This function *does not* recursively get missing auth events of the
|
|
|
|
newly fetched events. Callers must include in the `events` argument
|
|
|
|
any missing events from the auth chain.
|
|
|
|
|
2019-12-16 07:26:28 -05:00
|
|
|
Logs a warning if we can't find the given event.
|
|
|
|
"""
|
|
|
|
|
2020-01-31 09:07:31 -05:00
|
|
|
room_version = await self.store.get_room_version(room_id)
|
2019-12-16 07:26:28 -05:00
|
|
|
|
2021-07-16 13:22:36 -04:00
|
|
|
event_map: Dict[str, EventBase] = {}
|
2019-12-16 07:26:28 -05:00
|
|
|
|
|
|
|
async def get_event(event_id: str):
|
|
|
|
with nested_logging_context(event_id):
|
|
|
|
try:
|
|
|
|
event = await self.federation_client.get_pdu(
|
|
|
|
[destination],
|
|
|
|
event_id,
|
|
|
|
room_version,
|
|
|
|
outlier=True,
|
|
|
|
)
|
|
|
|
if event is None:
|
|
|
|
logger.warning(
|
|
|
|
"Server %s didn't return event %s",
|
|
|
|
destination,
|
|
|
|
event_id,
|
|
|
|
)
|
|
|
|
return
|
|
|
|
|
2020-07-10 13:15:35 -04:00
|
|
|
event_map[event.event_id] = event
|
2019-12-16 07:26:28 -05:00
|
|
|
|
|
|
|
except Exception as e:
|
|
|
|
logger.warning(
|
|
|
|
"Error fetching missing state/auth event %s: %s %s",
|
|
|
|
event_id,
|
|
|
|
type(e),
|
|
|
|
e,
|
|
|
|
)
|
|
|
|
|
|
|
|
await concurrently_execute(get_event, events, 5)
|
|
|
|
|
2020-07-10 13:15:35 -04:00
|
|
|
# Make a map of auth events for each event. We do this after fetching
|
|
|
|
# all the events as some of the events' auth events will be in the list
|
|
|
|
# of requested events.
|
|
|
|
|
|
|
|
auth_events = [
|
|
|
|
aid
|
|
|
|
for event in event_map.values()
|
|
|
|
for aid in event.auth_event_ids()
|
|
|
|
if aid not in event_map
|
|
|
|
]
|
|
|
|
persisted_events = await self.store.get_events(
|
|
|
|
auth_events,
|
|
|
|
allow_rejected=True,
|
|
|
|
)
|
|
|
|
|
|
|
|
event_infos = []
|
|
|
|
for event in event_map.values():
|
|
|
|
auth = {}
|
|
|
|
for auth_event_id in event.auth_event_ids():
|
|
|
|
ae = persisted_events.get(auth_event_id) or event_map.get(auth_event_id)
|
|
|
|
if ae:
|
|
|
|
auth[(ae.type, ae.state_key)] = ae
|
|
|
|
else:
|
|
|
|
logger.info("Missing auth event %s", auth_event_id)
|
|
|
|
|
|
|
|
event_infos.append(_NewEventInfo(event, None, auth))
|
|
|
|
|
2021-06-08 05:37:01 -04:00
|
|
|
if event_infos:
|
|
|
|
await self._auth_and_persist_events(
|
|
|
|
destination,
|
|
|
|
room_id,
|
|
|
|
event_infos,
|
|
|
|
)
|
2019-12-16 07:26:28 -05:00
|
|
|
|
2021-08-19 13:05:12 -04:00
|
|
|
async def _process_pulled_events(
|
|
|
|
self, origin: str, events: Iterable[EventBase]
|
|
|
|
) -> None:
|
|
|
|
"""Process a batch of events we have pulled from a remote server
|
|
|
|
|
|
|
|
Pulls in any events required to auth the events, persists the received events,
|
|
|
|
and notifies clients, if appropriate.
|
|
|
|
|
|
|
|
Assumes the events have already had their signatures and hashes checked.
|
|
|
|
|
|
|
|
Params:
|
|
|
|
origin: The server we received these events from
|
|
|
|
events: The received events.
|
|
|
|
"""
|
|
|
|
|
|
|
|
# We want to sort these by depth so we process them and
|
|
|
|
# tell clients about them in order.
|
|
|
|
sorted_events = sorted(events, key=lambda x: x.depth)
|
|
|
|
|
|
|
|
for ev in sorted_events:
|
|
|
|
with nested_logging_context(ev.event_id):
|
|
|
|
await self._process_pulled_event(origin, ev)
|
|
|
|
|
|
|
|
async def _process_pulled_event(self, origin: str, event: EventBase) -> None:
|
|
|
|
"""Process a single event that we have pulled from a remote server
|
|
|
|
|
|
|
|
Pulls in any events required to auth the event, persists the received event,
|
|
|
|
and notifies clients, if appropriate.
|
|
|
|
|
|
|
|
Assumes the event has already had its signatures and hashes checked.
|
|
|
|
|
|
|
|
This is somewhat equivalent to on_receive_pdu, but applies somewhat different
|
|
|
|
logic in the case that we are missing prev_events (in particular, it just
|
|
|
|
requests the state at that point, rather than triggering a get_missing_events) -
|
|
|
|
so is appropriate when we have pulled the event from a remote server, rather
|
|
|
|
than having it pushed to us.
|
|
|
|
|
|
|
|
Params:
|
|
|
|
origin: The server we received this event from
|
|
|
|
events: The received event
|
|
|
|
"""
|
|
|
|
logger.info("Processing pulled event %s", event)
|
|
|
|
|
|
|
|
# these should not be outliers.
|
|
|
|
assert not event.internal_metadata.is_outlier()
|
|
|
|
|
|
|
|
event_id = event.event_id
|
|
|
|
|
|
|
|
existing = await self.store.get_event(
|
|
|
|
event_id, allow_none=True, allow_rejected=True
|
|
|
|
)
|
|
|
|
if existing:
|
|
|
|
if not existing.internal_metadata.is_outlier():
|
|
|
|
logger.info(
|
|
|
|
"Ignoring received event %s which we have already seen",
|
|
|
|
event_id,
|
|
|
|
)
|
|
|
|
return
|
|
|
|
logger.info("De-outliering event %s", event_id)
|
|
|
|
|
|
|
|
try:
|
|
|
|
self._sanity_check_event(event)
|
|
|
|
except SynapseError as err:
|
|
|
|
logger.warning("Event %s failed sanity check: %s", event_id, err)
|
|
|
|
return
|
|
|
|
|
|
|
|
try:
|
|
|
|
state = await self._resolve_state_at_missing_prevs(origin, event)
|
|
|
|
await self._process_received_pdu(origin, event, state=state)
|
|
|
|
except FederationError as e:
|
|
|
|
if e.code == 403:
|
|
|
|
logger.warning("Pulled event %s failed history check.", event_id)
|
|
|
|
else:
|
|
|
|
raise
|
|
|
|
|
2021-08-19 12:31:40 -04:00
|
|
|
async def _resolve_state_at_missing_prevs(
|
|
|
|
self, dest: str, event: EventBase
|
|
|
|
) -> Optional[Iterable[EventBase]]:
|
|
|
|
"""Calculate the state at an event with missing prev_events.
|
|
|
|
|
|
|
|
This is used when we have pulled a batch of events from a remote server, and
|
|
|
|
still don't have all the prev_events.
|
|
|
|
|
|
|
|
If we already have all the prev_events for `event`, this method does nothing.
|
|
|
|
|
|
|
|
Otherwise, the missing prevs become new backwards extremities, and we fall back
|
|
|
|
to asking the remote server for the state after each missing `prev_event`,
|
|
|
|
and resolving across them.
|
|
|
|
|
|
|
|
That's ok provided we then resolve the state against other bits of the DAG
|
|
|
|
before using it - in other words, that the received event `event` is not going
|
|
|
|
to become the only forwards_extremity in the room (which will ensure that you
|
|
|
|
can't just take over a room by sending an event, withholding its prev_events,
|
|
|
|
and declaring yourself to be an admin in the subsequent state request).
|
|
|
|
|
|
|
|
In other words: we should only call this method if `event` has been *pulled*
|
|
|
|
as part of a batch of missing prev events, or similar.
|
|
|
|
|
|
|
|
Params:
|
|
|
|
dest: the remote server to ask for state at the missing prevs. Typically,
|
|
|
|
this will be the server we got `event` from.
|
|
|
|
event: an event to check for missing prevs.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
if we already had all the prev events, `None`. Otherwise, returns a list of
|
|
|
|
the events in the state at `event`.
|
|
|
|
"""
|
|
|
|
room_id = event.room_id
|
|
|
|
event_id = event.event_id
|
|
|
|
|
|
|
|
prevs = set(event.prev_event_ids())
|
|
|
|
seen = await self.store.have_events_in_timeline(prevs)
|
|
|
|
missing_prevs = prevs - seen
|
|
|
|
|
|
|
|
if not missing_prevs:
|
|
|
|
return None
|
|
|
|
|
|
|
|
logger.info(
|
|
|
|
"Event %s is missing prev_events %s: calculating state for a "
|
|
|
|
"backwards extremity",
|
|
|
|
event_id,
|
|
|
|
shortstr(missing_prevs),
|
|
|
|
)
|
|
|
|
# Calculate the state after each of the previous events, and
|
|
|
|
# resolve them to find the correct state at the current event.
|
|
|
|
event_map = {event_id: event}
|
|
|
|
try:
|
|
|
|
# Get the state of the events we know about
|
|
|
|
ours = await self.state_store.get_state_groups_ids(room_id, seen)
|
|
|
|
|
|
|
|
# state_maps is a list of mappings from (type, state_key) to event_id
|
|
|
|
state_maps: List[StateMap[str]] = list(ours.values())
|
|
|
|
|
|
|
|
# we don't need this any more, let's delete it.
|
|
|
|
del ours
|
|
|
|
|
|
|
|
# Ask the remote server for the states we don't
|
|
|
|
# know about
|
|
|
|
for p in missing_prevs:
|
|
|
|
logger.info("Requesting state after missing prev_event %s", p)
|
|
|
|
|
|
|
|
with nested_logging_context(p):
|
|
|
|
# note that if any of the missing prevs share missing state or
|
|
|
|
# auth events, the requests to fetch those events are deduped
|
|
|
|
# by the get_pdu_cache in federation_client.
|
|
|
|
remote_state = await self._get_state_after_missing_prev_event(
|
|
|
|
dest, room_id, p
|
|
|
|
)
|
|
|
|
|
|
|
|
remote_state_map = {
|
|
|
|
(x.type, x.state_key): x.event_id for x in remote_state
|
|
|
|
}
|
|
|
|
state_maps.append(remote_state_map)
|
|
|
|
|
|
|
|
for x in remote_state:
|
|
|
|
event_map[x.event_id] = x
|
|
|
|
|
|
|
|
room_version = await self.store.get_room_version_id(room_id)
|
|
|
|
state_map = await self._state_resolution_handler.resolve_events_with_store(
|
|
|
|
room_id,
|
|
|
|
room_version,
|
|
|
|
state_maps,
|
|
|
|
event_map,
|
|
|
|
state_res_store=StateResolutionStore(self.store),
|
|
|
|
)
|
|
|
|
|
|
|
|
# We need to give _process_received_pdu the actual state events
|
|
|
|
# rather than event ids, so generate that now.
|
|
|
|
|
|
|
|
# First though we need to fetch all the events that are in
|
|
|
|
# state_map, so we can build up the state below.
|
|
|
|
evs = await self.store.get_events(
|
|
|
|
list(state_map.values()),
|
|
|
|
get_prev_content=False,
|
|
|
|
redact_behaviour=EventRedactBehaviour.AS_IS,
|
|
|
|
)
|
|
|
|
event_map.update(evs)
|
|
|
|
|
|
|
|
state = [event_map[e] for e in state_map.values()]
|
|
|
|
except Exception:
|
|
|
|
logger.warning(
|
|
|
|
"Error attempting to resolve state at missing prev_events",
|
|
|
|
exc_info=True,
|
|
|
|
)
|
|
|
|
raise FederationError(
|
|
|
|
"ERROR",
|
|
|
|
403,
|
|
|
|
"We can't get valid state history.",
|
|
|
|
affected=event_id,
|
|
|
|
)
|
|
|
|
return state
|
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
def _sanity_check_event(self, ev: EventBase) -> None:
|
2018-04-17 18:41:12 -04:00
|
|
|
"""
|
|
|
|
Do some early sanity checks of a received event
|
|
|
|
|
|
|
|
In particular, checks it doesn't have an excessive number of
|
|
|
|
prev_events or auth_events, which could cause a huge state resolution
|
|
|
|
or cascade of event fetches.
|
|
|
|
|
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
ev: event to be checked
|
2018-04-17 18:41:12 -04:00
|
|
|
|
|
|
|
Raises:
|
|
|
|
SynapseError if the event does not pass muster
|
|
|
|
"""
|
2018-11-05 08:35:15 -05:00
|
|
|
if len(ev.prev_event_ids()) > 20:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning(
|
2018-04-17 18:41:12 -04:00
|
|
|
"Rejecting event %s which has %i prev_events",
|
2018-11-05 08:35:15 -05:00
|
|
|
ev.event_id,
|
|
|
|
len(ev.prev_event_ids()),
|
2018-04-17 18:41:12 -04:00
|
|
|
)
|
2020-06-16 08:51:47 -04:00
|
|
|
raise SynapseError(HTTPStatus.BAD_REQUEST, "Too many prev_events")
|
2018-04-17 18:41:12 -04:00
|
|
|
|
2018-11-05 08:35:15 -05:00
|
|
|
if len(ev.auth_event_ids()) > 10:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning(
|
2018-04-17 18:41:12 -04:00
|
|
|
"Rejecting event %s which has %i auth_events",
|
2018-11-05 08:35:15 -05:00
|
|
|
ev.event_id,
|
|
|
|
len(ev.auth_event_ids()),
|
2018-04-17 18:41:12 -04:00
|
|
|
)
|
2020-06-16 08:51:47 -04:00
|
|
|
raise SynapseError(HTTPStatus.BAD_REQUEST, "Too many auth_events")
|
2018-04-17 18:41:12 -04:00
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def send_invite(self, target_host: str, event: EventBase) -> EventBase:
|
2014-11-12 11:20:21 -05:00
|
|
|
"""Sends the invite to the remote server for signing.
|
|
|
|
|
|
|
|
Invites must be signed by the invitee's server before distribution.
|
|
|
|
"""
|
2021-07-15 05:35:46 -04:00
|
|
|
try:
|
|
|
|
pdu = await self.federation_client.send_invite(
|
|
|
|
destination=target_host,
|
|
|
|
room_id=event.room_id,
|
|
|
|
event_id=event.event_id,
|
|
|
|
pdu=event,
|
|
|
|
)
|
|
|
|
except RequestSendFailed:
|
|
|
|
raise SynapseError(502, f"Can't connect to server {target_host}")
|
2014-11-07 08:41:00 -05:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return pdu
|
2014-11-07 08:41:00 -05:00
|
|
|
|
2020-02-03 11:06:46 -05:00
|
|
|
async def on_event_auth(self, event_id: str) -> List[EventBase]:
|
|
|
|
event = await self.store.get_event(event_id)
|
|
|
|
auth = await self.store.get_auth_chain(
|
2021-03-10 09:57:59 -05:00
|
|
|
event.room_id, list(event.auth_event_ids()), include_given=True
|
2017-05-24 09:22:41 -04:00
|
|
|
)
|
2020-02-03 11:06:46 -05:00
|
|
|
return list(auth)
|
2014-11-07 10:35:53 -05:00
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
async def do_invite_join(
|
|
|
|
self, target_hosts: Iterable[str], room_id: str, joinee: str, content: JsonDict
|
2020-05-22 09:21:54 -04:00
|
|
|
) -> Tuple[str, int]:
|
2014-11-12 11:20:21 -05:00
|
|
|
"""Attempts to join the `joinee` to the room `room_id` via the
|
2019-11-01 06:28:09 -04:00
|
|
|
servers contained in `target_hosts`.
|
2014-11-12 11:20:21 -05:00
|
|
|
|
|
|
|
This first triggers a /make_join/ request that returns a partial
|
|
|
|
event that we can fill out and sign. This is then sent to the
|
|
|
|
remote server via /send_join/ which responds with the state at that
|
|
|
|
event and the auth_chains.
|
|
|
|
|
|
|
|
We suspend processing of any received events from this room until we
|
|
|
|
have finished processing the join.
|
2019-11-01 06:28:09 -04:00
|
|
|
|
|
|
|
Args:
|
2020-02-03 11:13:13 -05:00
|
|
|
target_hosts: List of servers to attempt to join the room with.
|
2019-11-01 06:28:09 -04:00
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
room_id: The ID of the room to join.
|
2019-11-01 06:28:09 -04:00
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
joinee: The User ID of the joining user.
|
2019-11-01 06:28:09 -04:00
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
content: The event content to use for the join event.
|
2014-11-12 11:20:21 -05:00
|
|
|
"""
|
2020-05-22 11:11:35 -04:00
|
|
|
# TODO: We should be able to call this on workers, but the upgrading of
|
|
|
|
# room stuff after join currently doesn't work on workers.
|
|
|
|
assert self.config.worker.worker_app is None
|
|
|
|
|
2014-11-25 06:31:18 -05:00
|
|
|
logger.debug("Joining %s to %s", joinee, room_id)
|
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
origin, event, room_version_obj = await self._make_and_verify_event(
|
2015-02-05 08:43:28 -05:00
|
|
|
target_hosts,
|
2014-10-17 10:04:17 -04:00
|
|
|
room_id,
|
2015-10-01 12:49:52 -04:00
|
|
|
joinee,
|
2015-11-12 11:19:55 -05:00
|
|
|
"join",
|
|
|
|
content,
|
2018-08-06 08:45:37 -04:00
|
|
|
params={"ver": KNOWN_ROOM_VERSIONS},
|
2014-08-20 09:42:36 -04:00
|
|
|
)
|
|
|
|
|
2017-03-14 07:26:57 -04:00
|
|
|
# This shouldn't happen, because the RoomMemberHandler has a
|
|
|
|
# linearizer lock which only allows one operation per user per room
|
|
|
|
# at a time - so this is just paranoia.
|
|
|
|
assert room_id not in self.room_queues
|
|
|
|
|
2014-10-29 12:59:24 -04:00
|
|
|
self.room_queues[room_id] = []
|
2017-03-14 07:26:57 -04:00
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
await self._clean_room_for_join(room_id)
|
2017-03-14 07:26:57 -04:00
|
|
|
|
2014-10-29 12:59:24 -04:00
|
|
|
try:
|
2015-02-05 08:43:28 -05:00
|
|
|
# Try the host we successfully got a response to /make_join/
|
|
|
|
# request first.
|
2020-07-01 11:21:02 -04:00
|
|
|
host_list = list(target_hosts)
|
2015-02-06 05:53:18 -05:00
|
|
|
try:
|
2020-07-01 11:21:02 -04:00
|
|
|
host_list.remove(origin)
|
|
|
|
host_list.insert(0, origin)
|
2015-02-06 05:53:18 -05:00
|
|
|
except ValueError:
|
|
|
|
pass
|
2020-01-27 09:30:57 -05:00
|
|
|
|
2020-02-03 11:13:13 -05:00
|
|
|
ret = await self.federation_client.send_join(
|
2020-07-01 11:21:02 -04:00
|
|
|
host_list, event, room_version_obj
|
2019-01-23 15:21:33 -05:00
|
|
|
)
|
2014-10-17 13:56:42 -04:00
|
|
|
|
2021-07-26 12:17:00 -04:00
|
|
|
event = ret.event
|
|
|
|
origin = ret.origin
|
|
|
|
state = ret.state
|
|
|
|
auth_chain = ret.auth_chain
|
2014-11-27 11:02:26 -05:00
|
|
|
auth_chain.sort(key=lambda e: e.depth)
|
2014-08-20 09:42:36 -04:00
|
|
|
|
2014-11-25 06:31:18 -05:00
|
|
|
logger.debug("do_invite_join auth_chain: %s", auth_chain)
|
|
|
|
logger.debug("do_invite_join state: %s", state)
|
2014-10-17 13:56:42 -04:00
|
|
|
|
2015-12-10 12:08:21 -05:00
|
|
|
logger.debug("do_invite_join event: %s", event)
|
2014-10-29 12:59:24 -04:00
|
|
|
|
2020-02-24 10:46:41 -05:00
|
|
|
# if this is the first time we've joined this room, it's time to add
|
|
|
|
# a row to `rooms` with the correct room version. If there's already a
|
|
|
|
# row there, we should override it, since it may have been populated
|
|
|
|
# based on an invite request which lied about the room version.
|
|
|
|
#
|
|
|
|
# federation_client.send_join has already checked that the room
|
|
|
|
# version in the received create event is the same as room_version_obj,
|
|
|
|
# so we can rely on it now.
|
|
|
|
#
|
|
|
|
await self.store.upsert_room_on_join(
|
|
|
|
room_id=room_id,
|
|
|
|
room_version=room_version_obj,
|
|
|
|
)
|
2014-10-29 12:59:24 -04:00
|
|
|
|
2020-05-22 09:21:54 -04:00
|
|
|
max_stream_id = await self._persist_auth_tree(
|
2020-09-14 05:16:41 -04:00
|
|
|
origin, room_id, auth_chain, state, event, room_version_obj
|
2020-01-27 09:30:57 -05:00
|
|
|
)
|
2014-10-29 12:59:24 -04:00
|
|
|
|
2020-05-22 09:21:54 -04:00
|
|
|
# We wait here until this instance has seen the events come down
|
|
|
|
# replication (if we're using replication) as the below uses caches.
|
|
|
|
await self._replication.wait_for_stream_position(
|
2020-09-14 05:16:41 -04:00
|
|
|
self.config.worker.events_shard_config.get_instance(room_id),
|
|
|
|
"events",
|
|
|
|
max_stream_id,
|
2020-05-22 09:21:54 -04:00
|
|
|
)
|
|
|
|
|
2019-11-01 06:28:09 -04:00
|
|
|
# Check whether this room is the result of an upgrade of a room we already know
|
|
|
|
# about. If so, migrate over user information
|
2020-02-03 11:13:13 -05:00
|
|
|
predecessor = await self.store.get_room_predecessor(room_id)
|
2019-12-11 08:07:25 -05:00
|
|
|
if not predecessor or not isinstance(predecessor.get("room_id"), str):
|
2020-05-22 09:21:54 -04:00
|
|
|
return event.event_id, max_stream_id
|
2019-11-01 06:28:09 -04:00
|
|
|
old_room_id = predecessor["room_id"]
|
|
|
|
logger.debug(
|
|
|
|
"Found predecessor for %s during remote join: %s", room_id, old_room_id
|
|
|
|
)
|
|
|
|
|
|
|
|
# We retrieve the room member handler here as to not cause a cyclic dependency
|
|
|
|
member_handler = self.hs.get_room_member_handler()
|
2020-02-03 11:13:13 -05:00
|
|
|
await member_handler.transfer_room_state_on_room_upgrade(
|
2019-11-01 06:28:09 -04:00
|
|
|
old_room_id, room_id
|
|
|
|
)
|
|
|
|
|
2014-11-25 06:31:18 -05:00
|
|
|
logger.debug("Finished joining %s to %s", joinee, room_id)
|
2020-05-22 09:21:54 -04:00
|
|
|
return event.event_id, max_stream_id
|
2014-10-29 12:59:24 -04:00
|
|
|
finally:
|
|
|
|
room_queue = self.room_queues[room_id]
|
|
|
|
del self.room_queues[room_id]
|
2014-10-17 13:56:42 -04:00
|
|
|
|
2017-03-14 07:26:57 -04:00
|
|
|
# we don't need to wait for the queued events to be processed -
|
|
|
|
# it's just a best-effort thing at this point. We do want to do
|
|
|
|
# them roughly in order, though, otherwise we'll end up making
|
|
|
|
# lots of requests for missing prev_events which we do actually
|
2020-07-24 10:53:25 -04:00
|
|
|
# have. Hence we fire off the background task, but don't wait for it.
|
2014-12-10 10:55:03 -05:00
|
|
|
|
2019-07-03 10:07:04 -04:00
|
|
|
run_in_background(self._handle_queued_pdus, room_queue)
|
2014-10-17 13:56:42 -04:00
|
|
|
|
2021-06-09 14:39:51 -04:00
|
|
|
@log_function
|
|
|
|
async def do_knock(
|
|
|
|
self,
|
|
|
|
target_hosts: List[str],
|
|
|
|
room_id: str,
|
|
|
|
knockee: str,
|
|
|
|
content: JsonDict,
|
|
|
|
) -> Tuple[str, int]:
|
|
|
|
"""Sends the knock to the remote server.
|
|
|
|
|
|
|
|
This first triggers a make_knock request that returns a partial
|
|
|
|
event that we can fill out and sign. This is then sent to the
|
|
|
|
remote server via send_knock.
|
|
|
|
|
|
|
|
Knock events must be signed by the knockee's server before distributing.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
target_hosts: A list of hosts that we want to try knocking through.
|
|
|
|
room_id: The ID of the room to knock on.
|
|
|
|
knockee: The ID of the user who is knocking.
|
|
|
|
content: The content of the knock event.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
A tuple of (event ID, stream ID).
|
|
|
|
|
|
|
|
Raises:
|
|
|
|
SynapseError: If the chosen remote server returns a 3xx/4xx code.
|
|
|
|
RuntimeError: If no servers were reachable.
|
|
|
|
"""
|
|
|
|
logger.debug("Knocking on room %s on behalf of user %s", room_id, knockee)
|
|
|
|
|
|
|
|
# Inform the remote server of the room versions we support
|
|
|
|
supported_room_versions = list(KNOWN_ROOM_VERSIONS.keys())
|
|
|
|
|
|
|
|
# Ask the remote server to create a valid knock event for us. Once received,
|
|
|
|
# we sign the event
|
2021-07-16 13:22:36 -04:00
|
|
|
params: Dict[str, Iterable[str]] = {"ver": supported_room_versions}
|
2021-06-09 14:39:51 -04:00
|
|
|
origin, event, event_format_version = await self._make_and_verify_event(
|
|
|
|
target_hosts, room_id, knockee, Membership.KNOCK, content, params=params
|
|
|
|
)
|
|
|
|
|
|
|
|
# Record the room ID and its version so that we have a record of the room
|
|
|
|
await self._maybe_store_room_on_outlier_membership(
|
|
|
|
room_id=event.room_id, room_version=event_format_version
|
|
|
|
)
|
|
|
|
|
|
|
|
# Initially try the host that we successfully called /make_knock on
|
|
|
|
try:
|
|
|
|
target_hosts.remove(origin)
|
|
|
|
target_hosts.insert(0, origin)
|
|
|
|
except ValueError:
|
|
|
|
pass
|
|
|
|
|
|
|
|
# Send the signed event back to the room, and potentially receive some
|
|
|
|
# further information about the room in the form of partial state events
|
|
|
|
stripped_room_state = await self.federation_client.send_knock(
|
|
|
|
target_hosts, event
|
|
|
|
)
|
|
|
|
|
|
|
|
# Store any stripped room state events in the "unsigned" key of the event.
|
|
|
|
# This is a bit of a hack and is cribbing off of invites. Basically we
|
|
|
|
# store the room state here and retrieve it again when this event appears
|
|
|
|
# in the invitee's sync stream. It is stripped out for all other local users.
|
|
|
|
event.unsigned["knock_room_state"] = stripped_room_state["knock_state_events"]
|
|
|
|
|
|
|
|
context = await self.state_handler.compute_event_context(event)
|
|
|
|
stream_id = await self.persist_events_and_notify(
|
|
|
|
event.room_id, [(event, context)]
|
|
|
|
)
|
|
|
|
return event.event_id, stream_id
|
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def _handle_queued_pdus(
|
|
|
|
self, room_queue: List[Tuple[EventBase, str]]
|
|
|
|
) -> None:
|
2017-03-14 07:26:57 -04:00
|
|
|
"""Process PDUs which got queued up while we were busy send_joining.
|
|
|
|
|
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
room_queue: list of PDUs to be processed and the servers that sent them
|
2017-03-14 07:26:57 -04:00
|
|
|
"""
|
|
|
|
for p, origin in room_queue:
|
|
|
|
try:
|
|
|
|
logger.info(
|
2021-08-16 08:19:02 -04:00
|
|
|
"Processing queued PDU %s which was received while we were joining",
|
|
|
|
p,
|
2017-03-14 07:26:57 -04:00
|
|
|
)
|
2019-07-03 10:07:04 -04:00
|
|
|
with nested_logging_context(p.event_id):
|
2021-08-19 13:05:12 -04:00
|
|
|
await self.on_receive_pdu(origin, p)
|
2017-03-14 07:26:57 -04:00
|
|
|
except Exception as e:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning(
|
2017-03-14 07:26:57 -04:00
|
|
|
"Error handling queued PDU %s from %s: %s", p.event_id, origin, e
|
|
|
|
)
|
|
|
|
|
2020-02-03 10:35:30 -05:00
|
|
|
async def on_make_join_request(
|
|
|
|
self, origin: str, room_id: str, user_id: str
|
|
|
|
) -> EventBase:
|
2014-11-12 11:20:21 -05:00
|
|
|
"""We've received a /make_join/ request, so we create a partial
|
2015-10-20 06:58:58 -04:00
|
|
|
join event for the room and return that. We do *not* persist or
|
2014-11-12 11:20:21 -05:00
|
|
|
process it until the other server has signed it and sent it back.
|
2019-07-26 05:08:22 -04:00
|
|
|
|
|
|
|
Args:
|
2020-02-03 10:35:30 -05:00
|
|
|
origin: The (verified) server name of the requesting server.
|
|
|
|
room_id: Room to create join event in
|
|
|
|
user_id: The user to create the join for
|
2014-11-12 11:20:21 -05:00
|
|
|
"""
|
2019-07-26 05:08:22 -04:00
|
|
|
if get_domain_from_id(user_id) != origin:
|
|
|
|
logger.info(
|
|
|
|
"Got /make_join request for user %r from different origin %s, ignoring",
|
|
|
|
user_id,
|
|
|
|
origin,
|
|
|
|
)
|
|
|
|
raise SynapseError(403, "User not from origin", Codes.FORBIDDEN)
|
|
|
|
|
2020-07-16 10:17:31 -04:00
|
|
|
# checking the room version will check that we've actually heard of the room
|
|
|
|
# (and return a 404 otherwise)
|
2021-07-26 12:17:00 -04:00
|
|
|
room_version = await self.store.get_room_version(room_id)
|
2019-01-23 15:21:33 -05:00
|
|
|
|
2020-07-16 10:17:31 -04:00
|
|
|
# now check that we are *still* in the room
|
2021-07-01 14:25:37 -04:00
|
|
|
is_in_room = await self._event_auth_handler.check_host_in_room(
|
|
|
|
room_id, self.server_name
|
|
|
|
)
|
2020-07-16 10:17:31 -04:00
|
|
|
if not is_in_room:
|
|
|
|
logger.info(
|
|
|
|
"Got /make_join request for room %s we are no longer in",
|
|
|
|
room_id,
|
|
|
|
)
|
|
|
|
raise NotFoundError("Not an active room on this server")
|
|
|
|
|
|
|
|
event_content = {"membership": Membership.JOIN}
|
|
|
|
|
2021-07-26 12:17:00 -04:00
|
|
|
# If the current room is using restricted join rules, additional information
|
|
|
|
# may need to be included in the event content in order to efficiently
|
|
|
|
# validate the event.
|
|
|
|
#
|
|
|
|
# Note that this requires the /send_join request to come back to the
|
|
|
|
# same server.
|
|
|
|
if room_version.msc3083_join_rules:
|
|
|
|
state_ids = await self.store.get_current_state_ids(room_id)
|
|
|
|
if await self._event_auth_handler.has_restricted_join_rules(
|
|
|
|
state_ids, room_version
|
|
|
|
):
|
|
|
|
prev_member_event_id = state_ids.get((EventTypes.Member, user_id), None)
|
|
|
|
# If the user is invited or joined to the room already, then
|
|
|
|
# no additional info is needed.
|
|
|
|
include_auth_user_id = True
|
|
|
|
if prev_member_event_id:
|
|
|
|
prev_member_event = await self.store.get_event(prev_member_event_id)
|
|
|
|
include_auth_user_id = prev_member_event.membership not in (
|
|
|
|
Membership.JOIN,
|
|
|
|
Membership.INVITE,
|
|
|
|
)
|
|
|
|
|
|
|
|
if include_auth_user_id:
|
|
|
|
event_content[
|
|
|
|
"join_authorised_via_users_server"
|
|
|
|
] = await self._event_auth_handler.get_user_which_could_invite(
|
|
|
|
room_id,
|
|
|
|
state_ids,
|
|
|
|
)
|
|
|
|
|
2019-01-23 15:21:33 -05:00
|
|
|
builder = self.event_builder_factory.new(
|
2021-07-26 12:17:00 -04:00
|
|
|
room_version.identifier,
|
2019-01-23 15:21:33 -05:00
|
|
|
{
|
|
|
|
"type": EventTypes.Member,
|
|
|
|
"content": event_content,
|
|
|
|
"room_id": room_id,
|
|
|
|
"sender": user_id,
|
|
|
|
"state_key": user_id,
|
|
|
|
},
|
|
|
|
)
|
2014-12-04 10:50:01 -05:00
|
|
|
|
2016-04-13 06:11:46 -04:00
|
|
|
try:
|
2020-02-03 10:35:30 -05:00
|
|
|
event, context = await self.event_creation_handler.create_new_client_event(
|
2016-04-13 06:11:46 -04:00
|
|
|
builder=builder
|
|
|
|
)
|
2020-10-13 10:44:54 -04:00
|
|
|
except SynapseError as e:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning("Failed to create join to %s because %s", room_id, e)
|
2020-10-13 10:44:54 -04:00
|
|
|
raise
|
2019-06-12 05:31:37 -04:00
|
|
|
|
2021-07-26 12:17:00 -04:00
|
|
|
# Ensure the user can even join the room.
|
|
|
|
await self._check_join_restrictions(context, event)
|
|
|
|
|
2016-07-15 04:29:54 -04:00
|
|
|
# The remote hasn't signed it yet, obviously. We'll do the full checks
|
|
|
|
# when we get the event back in `on_send_join_request`
|
2021-07-01 14:25:37 -04:00
|
|
|
await self._event_auth_handler.check_from_context(
|
2021-07-26 12:17:00 -04:00
|
|
|
room_version.identifier, event, context, do_sig_check=False
|
2019-01-25 13:31:41 -05:00
|
|
|
)
|
2014-10-17 14:37:41 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return event
|
2014-10-16 11:56:51 -04:00
|
|
|
|
2020-02-03 10:33:42 -05:00
|
|
|
async def on_invite_request(
|
2020-01-30 17:13:02 -05:00
|
|
|
self, origin: str, event: EventBase, room_version: RoomVersion
|
2021-04-06 07:21:57 -04:00
|
|
|
) -> EventBase:
|
2014-11-12 11:20:21 -05:00
|
|
|
"""We've got an invite event. Process and persist it. Sign it.
|
|
|
|
|
|
|
|
Respond with the now signed event.
|
|
|
|
"""
|
2017-10-05 09:02:28 -04:00
|
|
|
if event.state_key is None:
|
|
|
|
raise SynapseError(400, "The invite event did not have a state key")
|
|
|
|
|
2020-02-03 10:33:42 -05:00
|
|
|
is_blocked = await self.store.is_room_blocked(event.room_id)
|
2017-06-19 07:36:28 -04:00
|
|
|
if is_blocked:
|
|
|
|
raise SynapseError(403, "This room has been blocked on this server")
|
|
|
|
|
2017-09-19 11:08:14 -04:00
|
|
|
if self.hs.config.block_non_admin_invites:
|
|
|
|
raise SynapseError(403, "This server does not accept room invites")
|
|
|
|
|
2020-12-11 14:05:15 -05:00
|
|
|
if not await self.spam_checker.user_may_invite(
|
2017-10-05 09:02:28 -04:00
|
|
|
event.sender, event.state_key, event.room_id
|
|
|
|
):
|
2017-10-03 09:04:10 -04:00
|
|
|
raise SynapseError(
|
2017-10-05 09:02:28 -04:00
|
|
|
403, "This user is not permitted to send invites to this server/user"
|
2017-10-03 09:04:10 -04:00
|
|
|
)
|
2017-10-03 08:53:09 -04:00
|
|
|
|
2017-06-30 11:20:30 -04:00
|
|
|
membership = event.content.get("membership")
|
|
|
|
if event.type != EventTypes.Member or membership != Membership.INVITE:
|
|
|
|
raise SynapseError(400, "The event was not an m.room.member invite event")
|
|
|
|
|
|
|
|
sender_domain = get_domain_from_id(event.sender)
|
|
|
|
if sender_domain != origin:
|
|
|
|
raise SynapseError(
|
|
|
|
400, "The invite event was not from the server sending it"
|
|
|
|
)
|
|
|
|
|
|
|
|
if not self.is_mine_id(event.state_key):
|
|
|
|
raise SynapseError(400, "The invite event must be for this server")
|
|
|
|
|
2018-05-18 06:18:39 -04:00
|
|
|
# block any attempts to invite the server notices mxid
|
|
|
|
if event.state_key == self._server_notices_mxid:
|
2020-06-16 08:51:47 -04:00
|
|
|
raise SynapseError(HTTPStatus.FORBIDDEN, "Cannot invite this user")
|
2018-05-18 06:18:39 -04:00
|
|
|
|
2021-01-29 11:38:29 -05:00
|
|
|
# We retrieve the room member handler here as to not cause a cyclic dependency
|
|
|
|
member_handler = self.hs.get_room_member_handler()
|
2021-02-03 05:17:37 -05:00
|
|
|
# We don't rate limit based on room ID, as that should be done by
|
|
|
|
# sending server.
|
2021-03-30 07:06:09 -04:00
|
|
|
await member_handler.ratelimit_invite(None, None, event.state_key)
|
2021-01-29 11:38:29 -05:00
|
|
|
|
2020-02-26 11:58:33 -05:00
|
|
|
# keep a record of the room version, if we don't yet know it.
|
|
|
|
# (this may get overwritten if we later get a different room version in a
|
|
|
|
# join dance).
|
2020-11-13 11:24:04 -05:00
|
|
|
await self._maybe_store_room_on_outlier_membership(
|
2020-02-26 11:58:33 -05:00
|
|
|
room_id=event.room_id, room_version=room_version
|
|
|
|
)
|
|
|
|
|
2014-12-05 11:20:48 -05:00
|
|
|
event.internal_metadata.outlier = True
|
2019-01-24 12:33:19 -05:00
|
|
|
event.internal_metadata.out_of_band_membership = True
|
2014-11-07 08:41:00 -05:00
|
|
|
|
|
|
|
event.signatures.update(
|
|
|
|
compute_event_signature(
|
2020-01-31 08:47:43 -05:00
|
|
|
room_version,
|
|
|
|
event.get_pdu_json(),
|
|
|
|
self.hs.hostname,
|
2020-07-08 12:51:56 -04:00
|
|
|
self.hs.signing_key,
|
2014-11-07 08:41:00 -05:00
|
|
|
)
|
|
|
|
)
|
|
|
|
|
2020-02-03 10:33:42 -05:00
|
|
|
context = await self.state_handler.compute_event_context(event)
|
2020-09-14 05:16:41 -04:00
|
|
|
await self.persist_events_and_notify(event.room_id, [(event, context)])
|
2014-11-07 08:41:00 -05:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return event
|
2014-11-07 08:41:00 -05:00
|
|
|
|
2020-02-03 11:19:18 -05:00
|
|
|
async def do_remotely_reject_invite(
|
|
|
|
self, target_hosts: Iterable[str], room_id: str, user_id: str, content: JsonDict
|
2020-05-22 09:21:54 -04:00
|
|
|
) -> Tuple[EventBase, int]:
|
2020-02-03 11:19:18 -05:00
|
|
|
origin, event, room_version = await self._make_and_verify_event(
|
2019-12-11 08:07:25 -05:00
|
|
|
target_hosts, room_id, user_id, "leave", content=content
|
2017-04-20 20:24:17 -04:00
|
|
|
)
|
2017-06-09 08:05:05 -04:00
|
|
|
# Mark as outlier as we don't have any state for this event; we're not
|
|
|
|
# even in the room.
|
2017-06-09 05:08:18 -04:00
|
|
|
event.internal_metadata.outlier = True
|
2019-01-24 12:33:19 -05:00
|
|
|
event.internal_metadata.out_of_band_membership = True
|
2015-10-20 06:58:58 -04:00
|
|
|
|
2020-10-23 12:38:40 -04:00
|
|
|
# Try the host that we successfully called /make_leave/ on first for
|
2017-04-07 09:39:32 -04:00
|
|
|
# the /send_leave/ request.
|
2020-07-01 11:21:02 -04:00
|
|
|
host_list = list(target_hosts)
|
2015-10-20 06:58:58 -04:00
|
|
|
try:
|
2020-07-01 11:21:02 -04:00
|
|
|
host_list.remove(origin)
|
|
|
|
host_list.insert(0, origin)
|
2015-10-20 06:58:58 -04:00
|
|
|
except ValueError:
|
|
|
|
pass
|
|
|
|
|
2020-07-01 11:21:02 -04:00
|
|
|
await self.federation_client.send_leave(host_list, event)
|
2016-03-15 09:24:31 -04:00
|
|
|
|
2020-02-03 11:19:18 -05:00
|
|
|
context = await self.state_handler.compute_event_context(event)
|
2020-09-14 05:16:41 -04:00
|
|
|
stream_id = await self.persist_events_and_notify(
|
|
|
|
event.room_id, [(event, context)]
|
|
|
|
)
|
2016-03-15 09:24:31 -04:00
|
|
|
|
2020-05-22 09:21:54 -04:00
|
|
|
return event, stream_id
|
2015-10-20 06:58:58 -04:00
|
|
|
|
2020-02-03 11:22:30 -05:00
|
|
|
async def _make_and_verify_event(
|
|
|
|
self,
|
|
|
|
target_hosts: Iterable[str],
|
|
|
|
room_id: str,
|
|
|
|
user_id: str,
|
|
|
|
membership: str,
|
2021-04-08 17:38:54 -04:00
|
|
|
content: JsonDict,
|
2020-07-01 11:21:02 -04:00
|
|
|
params: Optional[Dict[str, Union[str, Iterable[str]]]] = None,
|
2020-02-03 11:22:30 -05:00
|
|
|
) -> Tuple[str, EventBase, RoomVersion]:
|
2020-01-27 09:30:57 -05:00
|
|
|
(
|
|
|
|
origin,
|
|
|
|
event,
|
|
|
|
room_version,
|
2020-02-03 11:22:30 -05:00
|
|
|
) = await self.federation_client.make_membership_event(
|
2018-08-06 08:45:37 -04:00
|
|
|
target_hosts, room_id, user_id, membership, content, params=params
|
2015-10-20 06:58:58 -04:00
|
|
|
)
|
|
|
|
|
2019-01-23 15:21:33 -05:00
|
|
|
logger.debug("Got response to make_%s: %s", membership, event)
|
2015-10-20 06:58:58 -04:00
|
|
|
|
|
|
|
# We should assert some things.
|
|
|
|
# FIXME: Do this in a nicer way
|
|
|
|
assert event.type == EventTypes.Member
|
|
|
|
assert event.user_id == user_id
|
|
|
|
assert event.state_key == user_id
|
|
|
|
assert event.room_id == room_id
|
2020-01-27 09:30:57 -05:00
|
|
|
return origin, event, room_version
|
2015-10-20 06:58:58 -04:00
|
|
|
|
2020-02-03 10:40:41 -05:00
|
|
|
async def on_make_leave_request(
|
|
|
|
self, origin: str, room_id: str, user_id: str
|
|
|
|
) -> EventBase:
|
2015-10-20 06:58:58 -04:00
|
|
|
"""We've received a /make_leave/ request, so we create a partial
|
2018-07-25 17:44:41 -04:00
|
|
|
leave event for the room and return that. We do *not* persist or
|
2015-10-20 06:58:58 -04:00
|
|
|
process it until the other server has signed it and sent it back.
|
2019-07-26 05:08:22 -04:00
|
|
|
|
|
|
|
Args:
|
2020-02-03 10:40:41 -05:00
|
|
|
origin: The (verified) server name of the requesting server.
|
|
|
|
room_id: Room to create leave event in
|
|
|
|
user_id: The user to create the leave for
|
2015-10-20 06:58:58 -04:00
|
|
|
"""
|
2019-07-26 05:08:22 -04:00
|
|
|
if get_domain_from_id(user_id) != origin:
|
|
|
|
logger.info(
|
|
|
|
"Got /make_leave request for user %r from different origin %s, ignoring",
|
|
|
|
user_id,
|
|
|
|
origin,
|
|
|
|
)
|
|
|
|
raise SynapseError(403, "User not from origin", Codes.FORBIDDEN)
|
|
|
|
|
2020-02-03 10:40:41 -05:00
|
|
|
room_version = await self.store.get_room_version_id(room_id)
|
2019-01-23 15:21:33 -05:00
|
|
|
builder = self.event_builder_factory.new(
|
|
|
|
room_version,
|
|
|
|
{
|
|
|
|
"type": EventTypes.Member,
|
|
|
|
"content": {"membership": Membership.LEAVE},
|
|
|
|
"room_id": room_id,
|
|
|
|
"sender": user_id,
|
|
|
|
"state_key": user_id,
|
|
|
|
},
|
|
|
|
)
|
2015-10-20 06:58:58 -04:00
|
|
|
|
2020-02-03 10:40:41 -05:00
|
|
|
event, context = await self.event_creation_handler.create_new_client_event(
|
2015-10-20 06:58:58 -04:00
|
|
|
builder=builder
|
|
|
|
)
|
|
|
|
|
2016-04-13 06:11:46 -04:00
|
|
|
try:
|
2016-07-15 04:29:54 -04:00
|
|
|
# The remote hasn't signed it yet, obviously. We'll do the full checks
|
|
|
|
# when we get the event back in `on_send_leave_request`
|
2021-07-01 14:25:37 -04:00
|
|
|
await self._event_auth_handler.check_from_context(
|
2019-01-25 13:31:41 -05:00
|
|
|
room_version, event, context, do_sig_check=False
|
|
|
|
)
|
2016-04-13 06:11:46 -04:00
|
|
|
except AuthError as e:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning("Failed to create new leave %r because %s", event, e)
|
2016-04-13 06:11:46 -04:00
|
|
|
raise e
|
2015-10-20 06:58:58 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return event
|
2015-10-20 06:58:58 -04:00
|
|
|
|
2021-06-09 14:39:51 -04:00
|
|
|
@log_function
|
|
|
|
async def on_make_knock_request(
|
|
|
|
self, origin: str, room_id: str, user_id: str
|
|
|
|
) -> EventBase:
|
|
|
|
"""We've received a make_knock request, so we create a partial
|
|
|
|
knock event for the room and return that. We do *not* persist or
|
|
|
|
process it until the other server has signed it and sent it back.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
origin: The (verified) server name of the requesting server.
|
|
|
|
room_id: The room to create the knock event in.
|
|
|
|
user_id: The user to create the knock for.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
The partial knock event.
|
|
|
|
"""
|
|
|
|
if get_domain_from_id(user_id) != origin:
|
|
|
|
logger.info(
|
2021-06-15 07:45:14 -04:00
|
|
|
"Get /make_knock request for user %r from different origin %s, ignoring",
|
2021-06-09 14:39:51 -04:00
|
|
|
user_id,
|
|
|
|
origin,
|
|
|
|
)
|
|
|
|
raise SynapseError(403, "User not from origin", Codes.FORBIDDEN)
|
|
|
|
|
|
|
|
room_version = await self.store.get_room_version_id(room_id)
|
|
|
|
|
|
|
|
builder = self.event_builder_factory.new(
|
|
|
|
room_version,
|
|
|
|
{
|
|
|
|
"type": EventTypes.Member,
|
|
|
|
"content": {"membership": Membership.KNOCK},
|
|
|
|
"room_id": room_id,
|
|
|
|
"sender": user_id,
|
|
|
|
"state_key": user_id,
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
event, context = await self.event_creation_handler.create_new_client_event(
|
|
|
|
builder=builder
|
|
|
|
)
|
|
|
|
|
2021-07-20 06:39:46 -04:00
|
|
|
event_allowed, _ = await self.third_party_event_rules.check_event_allowed(
|
2021-06-09 14:39:51 -04:00
|
|
|
event, context
|
|
|
|
)
|
|
|
|
if not event_allowed:
|
|
|
|
logger.warning("Creation of knock %s forbidden by third-party rules", event)
|
|
|
|
raise SynapseError(
|
|
|
|
403, "This event is not allowed in this context", Codes.FORBIDDEN
|
|
|
|
)
|
|
|
|
|
|
|
|
try:
|
|
|
|
# The remote hasn't signed it yet, obviously. We'll do the full checks
|
|
|
|
# when we get the event back in `on_send_knock_request`
|
2021-07-01 14:25:37 -04:00
|
|
|
await self._event_auth_handler.check_from_context(
|
2021-06-09 14:39:51 -04:00
|
|
|
room_version, event, context, do_sig_check=False
|
|
|
|
)
|
|
|
|
except AuthError as e:
|
|
|
|
logger.warning("Failed to create new knock %r because %s", event, e)
|
|
|
|
raise e
|
|
|
|
|
|
|
|
return event
|
|
|
|
|
|
|
|
@log_function
|
2021-06-24 10:30:49 -04:00
|
|
|
async def on_send_membership_event(
|
2021-06-09 14:39:51 -04:00
|
|
|
self, origin: str, event: EventBase
|
2021-07-26 12:17:00 -04:00
|
|
|
) -> Tuple[EventBase, EventContext]:
|
2021-06-09 14:39:51 -04:00
|
|
|
"""
|
2021-06-24 11:00:08 -04:00
|
|
|
We have received a join/leave/knock event for a room via send_join/leave/knock.
|
2021-06-24 10:30:49 -04:00
|
|
|
|
|
|
|
Verify that event and send it into the room on the remote homeserver's behalf.
|
2021-06-09 14:39:51 -04:00
|
|
|
|
2021-06-24 11:00:08 -04:00
|
|
|
This is quite similar to on_receive_pdu, with the following principal
|
|
|
|
differences:
|
|
|
|
* only membership events are permitted (and only events with
|
|
|
|
sender==state_key -- ie, no kicks or bans)
|
|
|
|
* *We* send out the event on behalf of the remote server.
|
|
|
|
* We enforce the membership restrictions of restricted rooms.
|
|
|
|
* Rejected events result in an exception rather than being stored.
|
|
|
|
|
|
|
|
There are also other differences, however it is not clear if these are by
|
|
|
|
design or omission. In particular, we do not attempt to backfill any missing
|
|
|
|
prev_events.
|
|
|
|
|
2021-06-09 14:39:51 -04:00
|
|
|
Args:
|
2021-06-24 10:30:49 -04:00
|
|
|
origin: The homeserver of the remote (joining/invited/knocking) user.
|
|
|
|
event: The member event that has been signed by the remote homeserver.
|
2021-06-09 14:39:51 -04:00
|
|
|
|
|
|
|
Returns:
|
2021-07-26 12:17:00 -04:00
|
|
|
The event and context of the event after inserting it into the room graph.
|
2021-06-24 11:00:08 -04:00
|
|
|
|
|
|
|
Raises:
|
|
|
|
SynapseError if the event is not accepted into the room
|
2021-06-09 14:39:51 -04:00
|
|
|
"""
|
|
|
|
logger.debug(
|
2021-06-24 10:30:49 -04:00
|
|
|
"on_send_membership_event: Got event: %s, signatures: %s",
|
2021-06-09 14:39:51 -04:00
|
|
|
event.event_id,
|
|
|
|
event.signatures,
|
|
|
|
)
|
|
|
|
|
|
|
|
if get_domain_from_id(event.sender) != origin:
|
|
|
|
logger.info(
|
2021-06-24 10:30:49 -04:00
|
|
|
"Got send_membership request for user %r from different origin %s",
|
2021-06-09 14:39:51 -04:00
|
|
|
event.sender,
|
|
|
|
origin,
|
|
|
|
)
|
|
|
|
raise SynapseError(403, "User not from origin", Codes.FORBIDDEN)
|
|
|
|
|
2021-06-24 10:30:49 -04:00
|
|
|
if event.sender != event.state_key:
|
|
|
|
raise SynapseError(400, "state_key and sender must match", Codes.BAD_JSON)
|
|
|
|
|
2021-06-24 11:00:08 -04:00
|
|
|
assert not event.internal_metadata.outlier
|
2021-06-09 14:39:51 -04:00
|
|
|
|
2021-06-23 07:54:50 -04:00
|
|
|
# Send this event on behalf of the other server.
|
|
|
|
#
|
|
|
|
# The remote server isn't a full participant in the room at this point, so
|
|
|
|
# may not have an up-to-date list of the other homeservers participating in
|
|
|
|
# the room, so we send it on their behalf.
|
|
|
|
event.internal_metadata.send_on_behalf_of = origin
|
|
|
|
|
2021-06-09 14:39:51 -04:00
|
|
|
context = await self.state_handler.compute_event_context(event)
|
2021-06-24 11:00:08 -04:00
|
|
|
context = await self._check_event_auth(origin, event, context)
|
|
|
|
if context.rejected:
|
|
|
|
raise SynapseError(
|
|
|
|
403, f"{event.membership} event was rejected", Codes.FORBIDDEN
|
|
|
|
)
|
2021-06-09 14:39:51 -04:00
|
|
|
|
2021-06-24 10:30:49 -04:00
|
|
|
# for joins, we need to check the restrictions of restricted rooms
|
|
|
|
if event.membership == Membership.JOIN:
|
|
|
|
await self._check_join_restrictions(context, event)
|
|
|
|
|
|
|
|
# for knock events, we run the third-party event rules. It's not entirely clear
|
|
|
|
# why we don't do this for other sorts of membership events.
|
|
|
|
if event.membership == Membership.KNOCK:
|
2021-07-20 06:39:46 -04:00
|
|
|
event_allowed, _ = await self.third_party_event_rules.check_event_allowed(
|
2021-06-24 10:30:49 -04:00
|
|
|
event, context
|
2021-06-09 14:39:51 -04:00
|
|
|
)
|
2021-06-24 10:30:49 -04:00
|
|
|
if not event_allowed:
|
|
|
|
logger.info("Sending of knock %s forbidden by third-party rules", event)
|
|
|
|
raise SynapseError(
|
|
|
|
403, "This event is not allowed in this context", Codes.FORBIDDEN
|
|
|
|
)
|
2021-06-09 14:39:51 -04:00
|
|
|
|
2021-06-24 11:00:08 -04:00
|
|
|
# all looks good, we can persist the event.
|
|
|
|
await self._run_push_actions_and_persist_event(event, context)
|
2021-07-26 12:17:00 -04:00
|
|
|
return event, context
|
2021-06-09 14:39:51 -04:00
|
|
|
|
2021-06-24 10:30:49 -04:00
|
|
|
async def _check_join_restrictions(
|
|
|
|
self, context: EventContext, event: EventBase
|
|
|
|
) -> None:
|
|
|
|
"""Check that restrictions in restricted join rules are matched
|
|
|
|
|
|
|
|
Called when we receive a join event via send_join.
|
|
|
|
|
|
|
|
Raises an auth error if the restrictions are not matched.
|
|
|
|
"""
|
|
|
|
prev_state_ids = await context.get_prev_state_ids()
|
|
|
|
|
|
|
|
# Check if the user is already in the room or invited to the room.
|
|
|
|
user_id = event.state_key
|
|
|
|
prev_member_event_id = prev_state_ids.get((EventTypes.Member, user_id), None)
|
|
|
|
prev_member_event = None
|
|
|
|
if prev_member_event_id:
|
|
|
|
prev_member_event = await self.store.get_event(prev_member_event_id)
|
|
|
|
|
|
|
|
# Check if the member should be allowed access via membership in a space.
|
|
|
|
await self._event_auth_handler.check_restricted_join_rules(
|
|
|
|
prev_state_ids,
|
|
|
|
event.room_version,
|
|
|
|
user_id,
|
|
|
|
prev_member_event,
|
|
|
|
)
|
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
async def get_state_for_pdu(self, room_id: str, event_id: str) -> List[EventBase]:
|
2016-09-02 09:19:22 -04:00
|
|
|
"""Returns the state at the event. i.e. not including said event."""
|
2018-08-02 06:53:52 -04:00
|
|
|
|
2020-08-18 16:20:49 -04:00
|
|
|
event = await self.store.get_event(event_id, check_room_id=room_id)
|
2018-08-02 06:53:52 -04:00
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
state_groups = await self.state_store.get_state_groups(room_id, [event_id])
|
2014-10-17 10:04:17 -04:00
|
|
|
|
|
|
|
if state_groups:
|
2020-06-15 07:03:36 -04:00
|
|
|
_, state = list(state_groups.items()).pop()
|
2014-11-11 09:16:41 -05:00
|
|
|
results = {(e.type, e.state_key): e for e in state}
|
2014-10-30 07:53:35 -04:00
|
|
|
|
2018-08-02 08:23:48 -04:00
|
|
|
if event.is_state():
|
2014-10-30 07:53:35 -04:00
|
|
|
# Get previous state
|
2014-12-11 10:56:01 -05:00
|
|
|
if "replaces_state" in event.unsigned:
|
|
|
|
prev_id = event.unsigned["replaces_state"]
|
|
|
|
if prev_id != event.event_id:
|
2020-04-24 14:36:38 -04:00
|
|
|
prev_event = await self.store.get_event(prev_id)
|
2014-12-11 10:56:01 -05:00
|
|
|
results[(event.type, event.state_key)] = prev_event
|
2014-10-30 07:53:35 -04:00
|
|
|
else:
|
|
|
|
del results[(event.type, event.state_key)]
|
|
|
|
|
2018-05-31 05:03:47 -04:00
|
|
|
res = list(results.values())
|
2019-07-23 09:00:55 -04:00
|
|
|
return res
|
2014-10-17 10:04:17 -04:00
|
|
|
else:
|
2019-07-23 09:00:55 -04:00
|
|
|
return []
|
2014-10-17 10:04:17 -04:00
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
async def get_state_ids_for_pdu(self, room_id: str, event_id: str) -> List[str]:
|
2016-09-02 09:19:22 -04:00
|
|
|
"""Returns the state at the event. i.e. not including said event."""
|
2020-08-18 16:20:49 -04:00
|
|
|
event = await self.store.get_event(event_id, check_room_id=room_id)
|
2018-08-02 06:53:52 -04:00
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
state_groups = await self.state_store.get_state_groups_ids(room_id, [event_id])
|
2016-09-02 05:49:43 -04:00
|
|
|
|
|
|
|
if state_groups:
|
2018-09-06 10:22:23 -04:00
|
|
|
_, state = list(state_groups.items()).pop()
|
2016-09-02 05:49:43 -04:00
|
|
|
results = state
|
|
|
|
|
2018-08-02 08:23:48 -04:00
|
|
|
if event.is_state():
|
2016-09-02 05:49:43 -04:00
|
|
|
# Get previous state
|
|
|
|
if "replaces_state" in event.unsigned:
|
|
|
|
prev_id = event.unsigned["replaces_state"]
|
|
|
|
if prev_id != event.event_id:
|
|
|
|
results[(event.type, event.state_key)] = prev_id
|
|
|
|
else:
|
2017-02-28 05:01:19 -05:00
|
|
|
results.pop((event.type, event.state_key), None)
|
2016-09-02 05:49:43 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return list(results.values())
|
2016-09-02 05:49:43 -04:00
|
|
|
else:
|
2019-07-23 09:00:55 -04:00
|
|
|
return []
|
2016-09-02 05:49:43 -04:00
|
|
|
|
2014-10-31 05:59:02 -04:00
|
|
|
@log_function
|
2020-04-24 14:36:38 -04:00
|
|
|
async def on_backfill_request(
|
|
|
|
self, origin: str, room_id: str, pdu_list: List[str], limit: int
|
|
|
|
) -> List[EventBase]:
|
2021-07-01 14:25:37 -04:00
|
|
|
in_room = await self._event_auth_handler.check_host_in_room(room_id, origin)
|
2014-11-10 06:59:51 -05:00
|
|
|
if not in_room:
|
|
|
|
raise AuthError(403, "Host not in room.")
|
2014-10-31 05:59:02 -04:00
|
|
|
|
2020-02-06 13:25:24 -05:00
|
|
|
# Synapse asks for 100 events per backfill request. Do not allow more.
|
|
|
|
limit = min(limit, 100)
|
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
events = await self.store.get_backfill_events(room_id, pdu_list, limit)
|
2014-10-31 05:59:02 -04:00
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
events = await filter_events_for_server(self.storage, origin, events)
|
2015-07-03 12:52:57 -04:00
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return events
|
2014-10-31 05:59:02 -04:00
|
|
|
|
2014-10-31 06:47:34 -04:00
|
|
|
@log_function
|
2020-04-24 14:36:38 -04:00
|
|
|
async def get_persisted_pdu(
|
|
|
|
self, origin: str, event_id: str
|
|
|
|
) -> Optional[EventBase]:
|
2018-06-07 11:18:57 -04:00
|
|
|
"""Get an event from the database for the given server.
|
|
|
|
|
|
|
|
Args:
|
2020-04-24 14:36:38 -04:00
|
|
|
origin: hostname of server which is requesting the event; we
|
2018-06-07 11:18:57 -04:00
|
|
|
will check that the server is allowed to see it.
|
2020-04-24 14:36:38 -04:00
|
|
|
event_id: id of the event being requested
|
2014-10-31 06:47:34 -04:00
|
|
|
|
|
|
|
Returns:
|
2020-04-24 14:36:38 -04:00
|
|
|
None if we know nothing about the event; otherwise the (possibly-redacted) event.
|
2018-06-07 11:18:57 -04:00
|
|
|
|
|
|
|
Raises:
|
|
|
|
AuthError if the server is not currently in the room
|
2014-10-31 06:47:34 -04:00
|
|
|
"""
|
2020-04-24 14:36:38 -04:00
|
|
|
event = await self.store.get_event(
|
2015-02-03 05:40:14 -05:00
|
|
|
event_id, allow_none=True, allow_rejected=True
|
2014-10-31 06:47:34 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
if event:
|
2021-07-01 14:25:37 -04:00
|
|
|
in_room = await self._event_auth_handler.check_host_in_room(
|
|
|
|
event.room_id, origin
|
|
|
|
)
|
2018-06-07 11:18:57 -04:00
|
|
|
if not in_room:
|
|
|
|
raise AuthError(403, "Host not in room.")
|
2016-08-10 08:22:20 -04:00
|
|
|
|
2020-04-24 14:36:38 -04:00
|
|
|
events = await filter_events_for_server(self.storage, origin, [event])
|
2018-06-07 11:18:57 -04:00
|
|
|
event = events[0]
|
2019-07-23 09:00:55 -04:00
|
|
|
return event
|
2014-10-31 06:47:34 -04:00
|
|
|
else:
|
2019-07-23 09:00:55 -04:00
|
|
|
return None
|
2014-10-31 06:47:34 -04:00
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def get_min_depth_for_context(self, context: str) -> int:
|
2020-08-28 07:54:27 -04:00
|
|
|
return await self.store.get_min_depth(context)
|
2014-10-31 06:47:34 -04:00
|
|
|
|
2021-04-14 12:35:28 -04:00
|
|
|
async def _auth_and_persist_event(
|
2021-04-06 07:21:57 -04:00
|
|
|
self,
|
|
|
|
origin: str,
|
|
|
|
event: EventBase,
|
2021-04-14 12:35:28 -04:00
|
|
|
context: EventContext,
|
2021-04-06 07:21:57 -04:00
|
|
|
state: Optional[Iterable[EventBase]] = None,
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map: Optional[StateMap[EventBase]] = None,
|
2021-04-06 07:21:57 -04:00
|
|
|
backfilled: bool = False,
|
2021-04-23 07:05:51 -04:00
|
|
|
) -> None:
|
2021-04-14 12:35:28 -04:00
|
|
|
"""
|
|
|
|
Process an event by performing auth checks and then persisting to the database.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
origin: The host the event originates from.
|
|
|
|
event: The event itself.
|
|
|
|
context:
|
|
|
|
The event context.
|
|
|
|
|
|
|
|
state:
|
|
|
|
The state events used to check the event for soft-fail. If this is
|
|
|
|
not provided the current state events will be used.
|
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map:
|
|
|
|
A map of (type, state_key) => event for the event's claimed auth_events.
|
|
|
|
Possibly incomplete, and possibly including events that are not yet
|
|
|
|
persisted, or authed, or in the right room.
|
|
|
|
|
|
|
|
Only populated where we may not already have persisted these events -
|
|
|
|
for example, when populating outliers.
|
|
|
|
|
2021-04-14 12:35:28 -04:00
|
|
|
backfilled: True if the event was backfilled.
|
|
|
|
"""
|
|
|
|
context = await self._check_event_auth(
|
|
|
|
origin,
|
|
|
|
event,
|
|
|
|
context,
|
|
|
|
state=state,
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map=claimed_auth_event_map,
|
2021-04-14 12:35:28 -04:00
|
|
|
backfilled=backfilled,
|
2015-06-25 12:18:19 -04:00
|
|
|
)
|
|
|
|
|
2021-06-24 11:00:08 -04:00
|
|
|
await self._run_push_actions_and_persist_event(event, context, backfilled)
|
|
|
|
|
|
|
|
async def _run_push_actions_and_persist_event(
|
|
|
|
self, event: EventBase, context: EventContext, backfilled: bool = False
|
|
|
|
):
|
|
|
|
"""Run the push actions for a received event, and persist it.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
event: The event itself.
|
|
|
|
context: The event context.
|
|
|
|
backfilled: True if the event was backfilled.
|
|
|
|
"""
|
2018-02-20 06:36:56 -05:00
|
|
|
try:
|
2019-11-05 17:13:37 -05:00
|
|
|
if (
|
|
|
|
not event.internal_metadata.is_outlier()
|
|
|
|
and not backfilled
|
|
|
|
and not context.rejected
|
2021-08-17 08:13:42 -04:00
|
|
|
and (await self.store.get_min_depth(event.room_id)) <= event.depth
|
2019-11-05 17:13:37 -05:00
|
|
|
):
|
2020-02-03 10:48:33 -05:00
|
|
|
await self.action_generator.handle_push_actions_for_event(
|
2018-02-20 06:36:56 -05:00
|
|
|
event, context
|
|
|
|
)
|
2016-02-09 11:19:15 -05:00
|
|
|
|
2020-02-03 10:48:33 -05:00
|
|
|
await self.persist_events_and_notify(
|
2020-09-14 05:16:41 -04:00
|
|
|
event.room_id, [(event, context)], backfilled=backfilled
|
2018-02-20 06:36:56 -05:00
|
|
|
)
|
2020-07-27 08:35:56 -04:00
|
|
|
except Exception:
|
|
|
|
run_in_background(
|
|
|
|
self.store.remove_push_actions_from_staging, event.event_id
|
|
|
|
)
|
|
|
|
raise
|
2015-06-25 12:18:19 -04:00
|
|
|
|
2021-04-14 12:35:28 -04:00
|
|
|
async def _auth_and_persist_events(
|
2019-12-05 10:02:35 -05:00
|
|
|
self,
|
|
|
|
origin: str,
|
2020-09-14 05:16:41 -04:00
|
|
|
room_id: str,
|
2021-06-08 05:37:01 -04:00
|
|
|
event_infos: Collection[_NewEventInfo],
|
2019-12-05 10:02:35 -05:00
|
|
|
backfilled: bool = False,
|
2020-02-03 10:43:51 -05:00
|
|
|
) -> None:
|
2016-04-12 07:48:30 -04:00
|
|
|
"""Creates the appropriate contexts and persists events. The events
|
|
|
|
should not depend on one another, e.g. this should be used to persist
|
|
|
|
a bunch of outliers, but not a chunk of individual events that depend
|
|
|
|
on each other for state calculations.
|
2018-08-01 08:39:14 -04:00
|
|
|
|
|
|
|
Notifies about the events where appropriate.
|
2016-04-12 07:48:30 -04:00
|
|
|
"""
|
2018-09-27 06:25:34 -04:00
|
|
|
|
2021-06-08 05:37:01 -04:00
|
|
|
if not event_infos:
|
|
|
|
return
|
|
|
|
|
2020-02-03 10:43:51 -05:00
|
|
|
async def prep(ev_info: _NewEventInfo):
|
2019-12-05 10:02:35 -05:00
|
|
|
event = ev_info.event
|
2019-07-03 10:07:04 -04:00
|
|
|
with nested_logging_context(suffix=event.event_id):
|
2021-04-14 12:35:28 -04:00
|
|
|
res = await self.state_handler.compute_event_context(
|
|
|
|
event, old_state=ev_info.state
|
|
|
|
)
|
|
|
|
res = await self._check_event_auth(
|
2015-06-25 12:18:19 -04:00
|
|
|
origin,
|
2018-09-27 06:25:34 -04:00
|
|
|
event,
|
2021-04-14 12:35:28 -04:00
|
|
|
res,
|
2019-12-05 10:02:35 -05:00
|
|
|
state=ev_info.state,
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map=ev_info.claimed_auth_event_map,
|
2019-02-12 05:31:21 -05:00
|
|
|
backfilled=backfilled,
|
2015-06-25 12:18:19 -04:00
|
|
|
)
|
2019-07-23 09:00:55 -04:00
|
|
|
return res
|
2018-09-27 06:25:34 -04:00
|
|
|
|
2020-02-03 10:43:51 -05:00
|
|
|
contexts = await make_deferred_yieldable(
|
2018-09-27 06:25:34 -04:00
|
|
|
defer.gatherResults(
|
2019-07-03 10:07:04 -04:00
|
|
|
[run_in_background(prep, ev_info) for ev_info in event_infos],
|
2017-10-06 17:14:24 -04:00
|
|
|
consumeErrors=True,
|
2016-08-23 10:23:39 -04:00
|
|
|
)
|
2019-06-20 05:32:02 -04:00
|
|
|
)
|
2015-06-25 12:18:19 -04:00
|
|
|
|
2020-02-03 10:43:51 -05:00
|
|
|
await self.persist_events_and_notify(
|
2020-09-14 05:16:41 -04:00
|
|
|
room_id,
|
2015-06-25 12:18:19 -04:00
|
|
|
[
|
2019-12-05 10:02:35 -05:00
|
|
|
(ev_info.event, context)
|
2018-07-21 01:47:18 -04:00
|
|
|
for ev_info, context in zip(event_infos, contexts)
|
2015-06-25 12:18:19 -04:00
|
|
|
],
|
|
|
|
backfilled=backfilled,
|
2014-12-10 05:06:12 -05:00
|
|
|
)
|
|
|
|
|
2020-02-03 11:14:58 -05:00
|
|
|
async def _persist_auth_tree(
|
2020-01-27 09:30:57 -05:00
|
|
|
self,
|
|
|
|
origin: str,
|
2020-09-14 05:16:41 -04:00
|
|
|
room_id: str,
|
2020-01-27 09:30:57 -05:00
|
|
|
auth_events: List[EventBase],
|
|
|
|
state: List[EventBase],
|
|
|
|
event: EventBase,
|
|
|
|
room_version: RoomVersion,
|
2020-05-22 09:21:54 -04:00
|
|
|
) -> int:
|
2015-10-06 10:58:21 -04:00
|
|
|
"""Checks the auth chain is valid (and passes auth checks) for the
|
|
|
|
state and event. Then persists the auth chain and state atomically.
|
2018-08-01 08:39:14 -04:00
|
|
|
Persists the event separately. Notifies about the persisted events
|
|
|
|
where appropriate.
|
2015-10-06 10:58:21 -04:00
|
|
|
|
2016-07-29 06:17:04 -04:00
|
|
|
Will attempt to fetch missing auth events.
|
|
|
|
|
2016-07-29 05:45:05 -04:00
|
|
|
Args:
|
2020-01-27 09:30:57 -05:00
|
|
|
origin: Where the events came from
|
2020-09-14 05:16:41 -04:00
|
|
|
room_id,
|
2020-01-27 09:30:57 -05:00
|
|
|
auth_events
|
|
|
|
state
|
|
|
|
event
|
|
|
|
room_version: The room version we expect this room to have, and
|
|
|
|
will raise if it doesn't match the version in the create event.
|
2015-10-06 10:58:21 -04:00
|
|
|
"""
|
|
|
|
events_to_context = {}
|
|
|
|
for e in itertools.chain(auth_events, state):
|
|
|
|
e.internal_metadata.outlier = True
|
2020-02-03 11:14:58 -05:00
|
|
|
ctx = await self.state_handler.compute_event_context(e)
|
2016-03-31 10:32:24 -04:00
|
|
|
events_to_context[e.event_id] = ctx
|
2015-10-06 10:58:21 -04:00
|
|
|
|
|
|
|
event_map = {
|
2016-07-28 11:08:33 -04:00
|
|
|
e.event_id: e for e in itertools.chain(auth_events, state, [event])
|
2015-10-06 10:58:21 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
create_event = None
|
|
|
|
for e in auth_events:
|
|
|
|
if (e.type, e.state_key) == (EventTypes.Create, ""):
|
|
|
|
create_event = e
|
|
|
|
break
|
|
|
|
|
2019-01-24 13:31:23 -05:00
|
|
|
if create_event is None:
|
|
|
|
# If the state doesn't have a create event then the room is
|
|
|
|
# invalid, and it would fail auth checks anyway.
|
|
|
|
raise SynapseError(400, "No create event in state")
|
|
|
|
|
2020-01-27 09:30:57 -05:00
|
|
|
room_version_id = create_event.content.get(
|
2019-04-01 05:24:38 -04:00
|
|
|
"room_version", RoomVersions.V1.identifier
|
|
|
|
)
|
2019-01-23 12:19:58 -05:00
|
|
|
|
2020-01-27 09:30:57 -05:00
|
|
|
if room_version.identifier != room_version_id:
|
|
|
|
raise SynapseError(400, "Room version mismatch")
|
|
|
|
|
2016-07-28 11:08:33 -04:00
|
|
|
missing_auth_events = set()
|
|
|
|
for e in itertools.chain(auth_events, state, [event]):
|
2018-11-05 08:35:15 -05:00
|
|
|
for e_id in e.auth_event_ids():
|
2016-07-28 11:08:33 -04:00
|
|
|
if e_id not in event_map:
|
|
|
|
missing_auth_events.add(e_id)
|
|
|
|
|
|
|
|
for e_id in missing_auth_events:
|
2020-02-03 11:14:58 -05:00
|
|
|
m_ev = await self.federation_client.get_pdu(
|
2020-01-31 09:07:31 -05:00
|
|
|
[origin],
|
|
|
|
e_id,
|
|
|
|
room_version=room_version,
|
|
|
|
outlier=True,
|
|
|
|
timeout=10000,
|
2016-07-28 11:08:33 -04:00
|
|
|
)
|
|
|
|
if m_ev and m_ev.event_id == e_id:
|
|
|
|
event_map[e_id] = m_ev
|
|
|
|
else:
|
|
|
|
logger.info("Failed to find auth event %r", e_id)
|
|
|
|
|
2015-10-06 10:58:21 -04:00
|
|
|
for e in itertools.chain(auth_events, state, [event]):
|
|
|
|
auth_for_e = {
|
|
|
|
(event_map[e_id].type, event_map[e_id].state_key): event_map[e_id]
|
2018-11-05 08:35:15 -05:00
|
|
|
for e_id in e.auth_event_ids()
|
2016-07-28 11:08:33 -04:00
|
|
|
if e_id in event_map
|
2015-10-06 10:58:21 -04:00
|
|
|
}
|
|
|
|
if create_event:
|
|
|
|
auth_for_e[(EventTypes.Create, "")] = create_event
|
|
|
|
|
|
|
|
try:
|
2019-10-18 13:43:36 -04:00
|
|
|
event_auth.check(room_version, e, auth_events=auth_for_e)
|
2016-01-27 12:02:10 -05:00
|
|
|
except SynapseError as err:
|
|
|
|
# we may get SynapseErrors here as well as AuthErrors. For
|
|
|
|
# instance, there are a couple of (ancient) events in some
|
|
|
|
# rooms whose senders do not have the correct sigil; these
|
|
|
|
# cause SynapseErrors in auth.check. We don't want to give up
|
|
|
|
# the attempt to federate altogether in such cases.
|
|
|
|
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning("Rejecting %s because %s", e.event_id, err.msg)
|
2015-10-06 10:58:21 -04:00
|
|
|
|
|
|
|
if e == event:
|
|
|
|
raise
|
|
|
|
events_to_context[e.event_id].rejected = RejectedReason.AUTH_ERROR
|
|
|
|
|
2021-06-08 05:37:01 -04:00
|
|
|
if auth_events or state:
|
|
|
|
await self.persist_events_and_notify(
|
|
|
|
room_id,
|
|
|
|
[
|
|
|
|
(e, events_to_context[e.event_id])
|
|
|
|
for e in itertools.chain(auth_events, state)
|
|
|
|
],
|
|
|
|
)
|
2015-10-06 10:58:21 -04:00
|
|
|
|
2020-02-03 11:14:58 -05:00
|
|
|
new_event_context = await self.state_handler.compute_event_context(
|
2016-03-31 10:32:24 -04:00
|
|
|
event, old_state=state
|
2015-10-06 10:58:21 -04:00
|
|
|
)
|
|
|
|
|
2020-09-14 05:16:41 -04:00
|
|
|
return await self.persist_events_and_notify(
|
|
|
|
room_id, [(event, new_event_context)]
|
|
|
|
)
|
2015-10-06 10:58:21 -04:00
|
|
|
|
2020-02-03 11:16:31 -05:00
|
|
|
async def _check_for_soft_fail(
|
2021-06-17 09:59:45 -04:00
|
|
|
self,
|
|
|
|
event: EventBase,
|
|
|
|
state: Optional[Iterable[EventBase]],
|
|
|
|
backfilled: bool,
|
|
|
|
origin: str,
|
2020-02-03 11:16:31 -05:00
|
|
|
) -> None:
|
|
|
|
"""Checks if we should soft fail the event; if so, marks the event as
|
2019-03-08 06:26:33 -05:00
|
|
|
such.
|
|
|
|
|
|
|
|
Args:
|
2019-12-05 10:02:35 -05:00
|
|
|
event
|
|
|
|
state: The state at the event if we don't have all the event's prev events
|
|
|
|
backfilled: Whether the event is from backfill
|
2021-06-17 09:59:45 -04:00
|
|
|
origin: The host the event originates from.
|
2019-03-08 06:26:33 -05:00
|
|
|
"""
|
2019-02-12 05:31:21 -05:00
|
|
|
# For new (non-backfilled and non-outlier) events we check if the event
|
|
|
|
# passes auth based on the current state. If it doesn't then we
|
|
|
|
# "soft-fail" the event.
|
2020-07-01 11:41:19 -04:00
|
|
|
if backfilled or event.internal_metadata.is_outlier():
|
|
|
|
return
|
2019-02-12 05:31:21 -05:00
|
|
|
|
2020-09-03 10:38:32 -04:00
|
|
|
extrem_ids_list = await self.store.get_latest_event_ids_in_room(event.room_id)
|
|
|
|
extrem_ids = set(extrem_ids_list)
|
2020-07-01 11:41:19 -04:00
|
|
|
prev_event_ids = set(event.prev_event_ids())
|
2019-02-12 05:31:21 -05:00
|
|
|
|
2020-07-01 11:41:19 -04:00
|
|
|
if extrem_ids == prev_event_ids:
|
|
|
|
# If they're the same then the current state is the same as the
|
|
|
|
# state at the event, so no point rechecking auth for soft fail.
|
|
|
|
return
|
|
|
|
|
|
|
|
room_version = await self.store.get_room_version_id(event.room_id)
|
|
|
|
room_version_obj = KNOWN_ROOM_VERSIONS[room_version]
|
|
|
|
|
|
|
|
# Calculate the "current state".
|
|
|
|
if state is not None:
|
|
|
|
# If we're explicitly given the state then we won't have all the
|
|
|
|
# prev events, and so we have a gap in the graph. In this case
|
|
|
|
# we want to be a little careful as we might have been down for
|
|
|
|
# a while and have an incorrect view of the current state,
|
|
|
|
# however we still want to do checks as gaps are easy to
|
|
|
|
# maliciously manufacture.
|
|
|
|
#
|
|
|
|
# So we use a "current state" that is actually a state
|
|
|
|
# resolution across the current forward extremities and the
|
|
|
|
# given state at the event. This should correctly handle cases
|
|
|
|
# like bans, especially with state res v2.
|
|
|
|
|
2020-09-29 10:57:36 -04:00
|
|
|
state_sets_d = await self.state_store.get_state_groups(
|
2020-07-01 11:41:19 -04:00
|
|
|
event.room_id, extrem_ids
|
|
|
|
)
|
2021-07-16 13:22:36 -04:00
|
|
|
state_sets: List[Iterable[EventBase]] = list(state_sets_d.values())
|
2020-07-01 11:41:19 -04:00
|
|
|
state_sets.append(state)
|
2020-08-24 14:25:27 -04:00
|
|
|
current_states = await self.state_handler.resolve_events(
|
2020-07-01 11:41:19 -04:00
|
|
|
room_version, state_sets, event
|
|
|
|
)
|
2021-07-16 13:22:36 -04:00
|
|
|
current_state_ids: StateMap[str] = {
|
2020-08-28 07:28:53 -04:00
|
|
|
k: e.event_id for k, e in current_states.items()
|
2021-07-16 13:22:36 -04:00
|
|
|
}
|
2020-07-01 11:41:19 -04:00
|
|
|
else:
|
|
|
|
current_state_ids = await self.state_handler.get_current_state_ids(
|
|
|
|
event.room_id, latest_event_ids=extrem_ids
|
2019-05-21 11:10:54 -04:00
|
|
|
)
|
|
|
|
|
2020-07-01 11:41:19 -04:00
|
|
|
logger.debug(
|
|
|
|
"Doing soft-fail check for %s: state %s",
|
|
|
|
event.event_id,
|
|
|
|
current_state_ids,
|
|
|
|
)
|
2019-02-12 05:31:21 -05:00
|
|
|
|
2020-07-01 11:41:19 -04:00
|
|
|
# Now check if event pass auth against said current state
|
2021-07-26 12:17:00 -04:00
|
|
|
auth_types = auth_types_for_event(room_version_obj, event)
|
2020-08-24 14:25:27 -04:00
|
|
|
current_state_ids_list = [
|
|
|
|
e for k, e in current_state_ids.items() if k in auth_types
|
|
|
|
]
|
2019-02-12 05:31:21 -05:00
|
|
|
|
2020-08-24 14:25:27 -04:00
|
|
|
auth_events_map = await self.store.get_events(current_state_ids_list)
|
2020-07-01 11:41:19 -04:00
|
|
|
current_auth_events = {
|
2020-08-18 16:20:49 -04:00
|
|
|
(e.type, e.state_key): e for e in auth_events_map.values()
|
2020-07-01 11:41:19 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
try:
|
|
|
|
event_auth.check(room_version_obj, event, auth_events=current_auth_events)
|
|
|
|
except AuthError as e:
|
2021-06-17 09:59:45 -04:00
|
|
|
logger.warning(
|
|
|
|
"Soft-failing %r (from %s) because %s",
|
|
|
|
event,
|
|
|
|
e,
|
|
|
|
origin,
|
|
|
|
extra={
|
|
|
|
"room_id": event.room_id,
|
|
|
|
"mxid": event.sender,
|
|
|
|
"hs": origin,
|
|
|
|
},
|
|
|
|
)
|
2021-06-11 05:12:35 -04:00
|
|
|
soft_failed_event_counter.inc()
|
2020-07-01 11:41:19 -04:00
|
|
|
event.internal_metadata.soft_failed = True
|
2019-02-12 05:31:21 -05:00
|
|
|
|
2020-02-03 14:15:08 -05:00
|
|
|
async def on_get_missing_events(
|
2021-04-06 07:21:57 -04:00
|
|
|
self,
|
|
|
|
origin: str,
|
|
|
|
room_id: str,
|
|
|
|
earliest_events: List[str],
|
|
|
|
latest_events: List[str],
|
|
|
|
limit: int,
|
|
|
|
) -> List[EventBase]:
|
2021-07-01 14:25:37 -04:00
|
|
|
in_room = await self._event_auth_handler.check_host_in_room(room_id, origin)
|
2015-02-23 08:58:02 -05:00
|
|
|
if not in_room:
|
|
|
|
raise AuthError(403, "Host not in room.")
|
|
|
|
|
2020-02-06 13:25:24 -05:00
|
|
|
# Only allow up to 20 events to be retrieved per request.
|
2015-02-23 08:58:02 -05:00
|
|
|
limit = min(limit, 20)
|
|
|
|
|
2020-02-03 14:15:08 -05:00
|
|
|
missing_events = await self.store.get_missing_events(
|
2015-02-23 08:58:02 -05:00
|
|
|
room_id=room_id,
|
|
|
|
earliest_events=earliest_events,
|
|
|
|
latest_events=latest_events,
|
|
|
|
limit=limit,
|
|
|
|
)
|
|
|
|
|
2020-02-03 14:15:08 -05:00
|
|
|
missing_events = await filter_events_for_server(
|
2019-10-23 12:25:54 -04:00
|
|
|
self.storage, origin, missing_events
|
2018-06-08 06:34:46 -04:00
|
|
|
)
|
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return missing_events
|
2015-02-23 08:58:02 -05:00
|
|
|
|
2021-04-14 12:35:28 -04:00
|
|
|
async def _check_event_auth(
|
2020-02-03 10:51:24 -05:00
|
|
|
self,
|
|
|
|
origin: str,
|
|
|
|
event: EventBase,
|
|
|
|
context: EventContext,
|
2021-06-24 11:00:08 -04:00
|
|
|
state: Optional[Iterable[EventBase]] = None,
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map: Optional[StateMap[EventBase]] = None,
|
2021-06-24 11:00:08 -04:00
|
|
|
backfilled: bool = False,
|
2020-02-03 10:51:24 -05:00
|
|
|
) -> EventContext:
|
2017-11-07 11:43:00 -05:00
|
|
|
"""
|
2021-04-14 12:35:28 -04:00
|
|
|
Checks whether an event should be rejected (for failing auth checks).
|
2017-11-07 11:43:00 -05:00
|
|
|
|
|
|
|
Args:
|
2021-04-14 12:35:28 -04:00
|
|
|
origin: The host the event originates from.
|
|
|
|
event: The event itself.
|
2020-02-03 10:51:24 -05:00
|
|
|
context:
|
2021-04-14 12:35:28 -04:00
|
|
|
The event context.
|
|
|
|
|
|
|
|
state:
|
|
|
|
The state events used to check the event for soft-fail. If this is
|
|
|
|
not provided the current state events will be used.
|
2019-05-23 06:17:42 -04:00
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
claimed_auth_event_map:
|
|
|
|
A map of (type, state_key) => event for the event's claimed auth_events.
|
|
|
|
Possibly incomplete, and possibly including events that are not yet
|
|
|
|
persisted, or authed, or in the right room.
|
2019-05-23 06:17:42 -04:00
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
Only populated where we may not already have persisted these events -
|
|
|
|
for example, when populating outliers, or the state for a backwards
|
|
|
|
extremity.
|
2021-04-14 12:35:28 -04:00
|
|
|
|
|
|
|
backfilled: True if the event was backfilled.
|
|
|
|
|
2019-05-23 06:17:42 -04:00
|
|
|
Returns:
|
2021-04-14 12:35:28 -04:00
|
|
|
The updated context object.
|
2019-05-23 06:17:42 -04:00
|
|
|
"""
|
2020-02-03 10:51:24 -05:00
|
|
|
room_version = await self.store.get_room_version_id(event.room_id)
|
2020-01-28 09:18:29 -05:00
|
|
|
room_version_obj = KNOWN_ROOM_VERSIONS[room_version]
|
2019-05-23 06:17:42 -04:00
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
if claimed_auth_event_map:
|
|
|
|
# if we have a copy of the auth events from the event, use that as the
|
|
|
|
# basis for auth.
|
|
|
|
auth_events = claimed_auth_event_map
|
|
|
|
else:
|
|
|
|
# otherwise, we calculate what the auth events *should* be, and use that
|
2021-04-14 12:35:28 -04:00
|
|
|
prev_state_ids = await context.get_prev_state_ids()
|
2021-07-01 14:25:37 -04:00
|
|
|
auth_events_ids = self._event_auth_handler.compute_auth_events(
|
2021-04-14 12:35:28 -04:00
|
|
|
event, prev_state_ids, for_verification=True
|
|
|
|
)
|
|
|
|
auth_events_x = await self.store.get_events(auth_events_ids)
|
|
|
|
auth_events = {(e.type, e.state_key): e for e in auth_events_x.values()}
|
|
|
|
|
2019-06-03 04:56:45 -04:00
|
|
|
try:
|
2021-08-06 08:54:23 -04:00
|
|
|
(
|
|
|
|
context,
|
|
|
|
auth_events_for_auth,
|
|
|
|
) = await self._update_auth_events_and_context_for_auth(
|
2019-06-03 04:56:45 -04:00
|
|
|
origin, event, context, auth_events
|
|
|
|
)
|
|
|
|
except Exception:
|
|
|
|
# We don't really mind if the above fails, so lets not fail
|
2019-06-05 06:31:27 -04:00
|
|
|
# processing if it does. However, it really shouldn't fail so
|
|
|
|
# let's still log as an exception since we'll still want to fix
|
|
|
|
# any bugs.
|
|
|
|
logger.exception(
|
|
|
|
"Failed to double check auth events for %s with remote. "
|
|
|
|
"Ignoring failure and continuing processing of event.",
|
|
|
|
event.event_id,
|
|
|
|
)
|
2021-08-06 08:54:23 -04:00
|
|
|
auth_events_for_auth = auth_events
|
2019-06-03 04:56:45 -04:00
|
|
|
|
2019-05-23 06:17:42 -04:00
|
|
|
try:
|
2021-08-06 08:54:23 -04:00
|
|
|
event_auth.check(room_version_obj, event, auth_events=auth_events_for_auth)
|
2019-05-23 06:17:42 -04:00
|
|
|
except AuthError as e:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning("Failed auth resolution for %r because %s", event, e)
|
2019-11-01 12:19:09 -04:00
|
|
|
context.rejected = RejectedReason.AUTH_ERROR
|
|
|
|
|
2021-04-14 12:35:28 -04:00
|
|
|
if not context.rejected:
|
2021-06-17 09:59:45 -04:00
|
|
|
await self._check_for_soft_fail(event, state, backfilled, origin=origin)
|
2021-04-14 12:35:28 -04:00
|
|
|
|
|
|
|
if event.type == EventTypes.GuestAccess and not context.rejected:
|
|
|
|
await self.maybe_kick_guest_users(event)
|
|
|
|
|
|
|
|
# If we are going to send this event over federation we precaclculate
|
|
|
|
# the joined hosts.
|
|
|
|
if event.internal_metadata.get_send_on_behalf_of():
|
2021-05-05 11:53:22 -04:00
|
|
|
await self.event_creation_handler.cache_joined_hosts_for_event(
|
|
|
|
event, context
|
|
|
|
)
|
2021-04-14 12:35:28 -04:00
|
|
|
|
2019-11-01 12:19:09 -04:00
|
|
|
return context
|
2019-05-23 06:17:42 -04:00
|
|
|
|
2020-02-03 10:53:30 -05:00
|
|
|
async def _update_auth_events_and_context_for_auth(
|
|
|
|
self,
|
|
|
|
origin: str,
|
|
|
|
event: EventBase,
|
|
|
|
context: EventContext,
|
2021-08-06 08:54:23 -04:00
|
|
|
input_auth_events: StateMap[EventBase],
|
|
|
|
) -> Tuple[EventContext, StateMap[EventBase]]:
|
2021-04-14 12:35:28 -04:00
|
|
|
"""Helper for _check_event_auth. See there for docs.
|
2019-05-23 06:17:42 -04:00
|
|
|
|
2019-06-03 04:56:45 -04:00
|
|
|
Checks whether a given event has the expected auth events. If it
|
|
|
|
doesn't then we talk to the remote server to compare state to see if
|
|
|
|
we can come to a consensus (e.g. if one server missed some valid
|
|
|
|
state).
|
|
|
|
|
2020-02-03 10:53:30 -05:00
|
|
|
This attempts to resolve any potential divergence of state between
|
2019-06-03 04:56:45 -04:00
|
|
|
servers, but is not essential and so failures should not block further
|
|
|
|
processing of the event.
|
|
|
|
|
2019-05-23 06:17:42 -04:00
|
|
|
Args:
|
2020-02-03 10:53:30 -05:00
|
|
|
origin:
|
|
|
|
event:
|
|
|
|
context:
|
2019-11-08 07:18:20 -05:00
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
input_auth_events:
|
2019-11-08 07:18:20 -05:00
|
|
|
Map from (event_type, state_key) to event
|
|
|
|
|
|
|
|
Normally, our calculated auth_events based on the state of the room
|
|
|
|
at the event's position in the DAG, though occasionally (eg if the
|
|
|
|
event is an outlier), may be the auth events claimed by the remote
|
|
|
|
server.
|
|
|
|
|
2017-11-07 11:43:00 -05:00
|
|
|
Returns:
|
2021-08-06 08:54:23 -04:00
|
|
|
updated context, updated auth event map
|
2017-11-07 11:43:00 -05:00
|
|
|
"""
|
2021-08-06 08:54:23 -04:00
|
|
|
# take a copy of input_auth_events before we modify it.
|
|
|
|
auth_events: MutableStateMap[EventBase] = dict(input_auth_events)
|
|
|
|
|
2018-11-05 08:35:15 -05:00
|
|
|
event_auth_events = set(event.auth_event_ids())
|
2015-06-25 12:18:19 -04:00
|
|
|
|
2019-11-08 07:18:20 -05:00
|
|
|
# missing_auth is the set of the event's auth_events which we don't yet have
|
|
|
|
# in auth_events.
|
2019-05-23 06:17:42 -04:00
|
|
|
missing_auth = event_auth_events.difference(
|
|
|
|
e.event_id for e in auth_events.values()
|
|
|
|
)
|
|
|
|
|
2019-11-08 07:18:20 -05:00
|
|
|
# if we have missing events, we need to fetch those events from somewhere.
|
|
|
|
#
|
|
|
|
# we start by checking if they are in the store, and then try calling /event_auth/.
|
2019-05-23 06:17:42 -04:00
|
|
|
if missing_auth:
|
2021-06-01 07:04:47 -04:00
|
|
|
have_events = await self.store.have_seen_events(event.room_id, missing_auth)
|
2019-12-04 12:27:32 -05:00
|
|
|
logger.debug("Events %s are in the store", have_events)
|
|
|
|
missing_auth.difference_update(have_events)
|
2015-06-25 12:18:19 -04:00
|
|
|
|
2015-01-28 11:16:53 -05:00
|
|
|
if missing_auth:
|
2015-01-29 11:50:23 -05:00
|
|
|
# If we don't have all the auth events, we need to get them.
|
2019-05-23 06:17:42 -04:00
|
|
|
logger.info("auth_events contains unknown events: %s", missing_auth)
|
2015-02-03 08:57:54 -05:00
|
|
|
try:
|
2019-06-03 04:56:45 -04:00
|
|
|
try:
|
2020-02-03 10:53:30 -05:00
|
|
|
remote_auth_chain = await self.federation_client.get_event_auth(
|
2019-06-03 04:56:45 -04:00
|
|
|
origin, event.room_id, event.event_id
|
|
|
|
)
|
2020-07-01 11:21:02 -04:00
|
|
|
except RequestSendFailed as e1:
|
2019-06-03 04:56:45 -04:00
|
|
|
# The other side isn't around or doesn't implement the
|
|
|
|
# endpoint, so lets just bail out.
|
2020-07-01 11:21:02 -04:00
|
|
|
logger.info("Failed to get event auth from remote: %s", e1)
|
2021-08-06 08:54:23 -04:00
|
|
|
return context, auth_events
|
2015-01-29 11:50:23 -05:00
|
|
|
|
2020-02-03 10:53:30 -05:00
|
|
|
seen_remotes = await self.store.have_seen_events(
|
2021-06-01 07:04:47 -04:00
|
|
|
event.room_id, [e.event_id for e in remote_auth_chain]
|
2015-02-03 08:57:54 -05:00
|
|
|
)
|
2015-01-30 11:51:58 -05:00
|
|
|
|
2015-02-03 08:57:54 -05:00
|
|
|
for e in remote_auth_chain:
|
2018-04-17 13:30:53 -04:00
|
|
|
if e.event_id in seen_remotes:
|
2015-02-03 08:57:54 -05:00
|
|
|
continue
|
2015-01-30 11:51:58 -05:00
|
|
|
|
2015-02-03 08:57:54 -05:00
|
|
|
if e.event_id == event.event_id:
|
|
|
|
continue
|
2015-01-30 11:51:58 -05:00
|
|
|
|
2015-02-03 08:57:54 -05:00
|
|
|
try:
|
2018-11-05 08:35:15 -05:00
|
|
|
auth_ids = e.auth_event_ids()
|
2015-02-03 08:57:54 -05:00
|
|
|
auth = {
|
|
|
|
(e.type, e.state_key): e
|
|
|
|
for e in remote_auth_chain
|
2015-10-02 08:11:49 -04:00
|
|
|
if e.event_id in auth_ids or e.type == EventTypes.Create
|
2015-02-03 08:57:54 -05:00
|
|
|
}
|
|
|
|
e.internal_metadata.outlier = True
|
2015-01-30 11:51:58 -05:00
|
|
|
|
2015-02-03 08:57:54 -05:00
|
|
|
logger.debug(
|
2021-04-14 12:35:28 -04:00
|
|
|
"_check_event_auth %s missing_auth: %s",
|
|
|
|
event.event_id,
|
|
|
|
e.event_id,
|
|
|
|
)
|
2021-07-28 11:46:37 -04:00
|
|
|
missing_auth_event_context = (
|
|
|
|
await self.state_handler.compute_event_context(e)
|
|
|
|
)
|
2021-04-14 12:35:28 -04:00
|
|
|
await self._auth_and_persist_event(
|
2021-08-06 08:54:23 -04:00
|
|
|
origin,
|
|
|
|
e,
|
|
|
|
missing_auth_event_context,
|
|
|
|
claimed_auth_event_map=auth,
|
2015-02-03 08:57:54 -05:00
|
|
|
)
|
2015-01-30 11:51:58 -05:00
|
|
|
|
2015-02-03 08:57:54 -05:00
|
|
|
if e.event_id in event_auth_events:
|
|
|
|
auth_events[(e.type, e.state_key)] = e
|
|
|
|
except AuthError:
|
|
|
|
pass
|
2015-02-06 09:16:50 -05:00
|
|
|
|
2017-10-23 10:52:32 -04:00
|
|
|
except Exception:
|
2015-02-03 08:57:54 -05:00
|
|
|
logger.exception("Failed to get auth chain")
|
2015-01-29 11:50:23 -05:00
|
|
|
|
2019-05-23 06:17:42 -04:00
|
|
|
if event.internal_metadata.is_outlier():
|
2019-11-08 07:18:20 -05:00
|
|
|
# XXX: given that, for an outlier, we'll be working with the
|
|
|
|
# event's *claimed* auth events rather than those we calculated:
|
|
|
|
# (a) is there any point in this test, since different_auth below will
|
|
|
|
# obviously be empty
|
|
|
|
# (b) alternatively, why don't we do it earlier?
|
2019-05-23 06:17:42 -04:00
|
|
|
logger.info("Skipping auth_event fetch for outlier")
|
2021-08-06 08:54:23 -04:00
|
|
|
return context, auth_events
|
2019-05-23 06:17:42 -04:00
|
|
|
|
|
|
|
different_auth = event_auth_events.difference(
|
|
|
|
e.event_id for e in auth_events.values()
|
|
|
|
)
|
2015-01-29 11:50:23 -05:00
|
|
|
|
2019-05-23 06:17:42 -04:00
|
|
|
if not different_auth:
|
2021-08-06 08:54:23 -04:00
|
|
|
return context, auth_events
|
2019-01-25 13:31:41 -05:00
|
|
|
|
2019-05-23 06:17:42 -04:00
|
|
|
logger.info(
|
|
|
|
"auth_events refers to events which are not in our calculated auth "
|
|
|
|
"chain: %s",
|
|
|
|
different_auth,
|
|
|
|
)
|
|
|
|
|
2019-12-04 12:27:32 -05:00
|
|
|
# XXX: currently this checks for redactions but I'm not convinced that is
|
|
|
|
# necessary?
|
2020-02-03 10:53:30 -05:00
|
|
|
different_events = await self.store.get_events_as_list(different_auth)
|
2019-05-23 06:17:42 -04:00
|
|
|
|
2019-12-05 09:14:45 -05:00
|
|
|
for d in different_events:
|
|
|
|
if d.room_id != event.room_id:
|
|
|
|
logger.warning(
|
|
|
|
"Event %s refers to auth_event %s which is in a different room",
|
|
|
|
event.event_id,
|
|
|
|
d.event_id,
|
|
|
|
)
|
|
|
|
|
|
|
|
# don't attempt to resolve the claimed auth events against our own
|
|
|
|
# in this case: just use our own auth events.
|
|
|
|
#
|
|
|
|
# XXX: should we reject the event in this case? It feels like we should,
|
|
|
|
# but then shouldn't we also do so if we've failed to fetch any of the
|
|
|
|
# auth events?
|
2021-08-06 08:54:23 -04:00
|
|
|
return context, auth_events
|
2015-02-13 09:20:05 -05:00
|
|
|
|
2019-12-05 09:14:45 -05:00
|
|
|
# now we state-resolve between our own idea of the auth events, and the remote's
|
|
|
|
# idea of them.
|
|
|
|
|
|
|
|
local_state = auth_events.values()
|
|
|
|
remote_auth_events = dict(auth_events)
|
|
|
|
remote_auth_events.update({(d.type, d.state_key): d for d in different_events})
|
|
|
|
remote_state = remote_auth_events.values()
|
|
|
|
|
2020-02-03 10:53:30 -05:00
|
|
|
room_version = await self.store.get_room_version_id(event.room_id)
|
|
|
|
new_state = await self.state_handler.resolve_events(
|
2019-12-05 09:14:45 -05:00
|
|
|
room_version, (local_state, remote_state), event
|
2019-12-04 12:27:32 -05:00
|
|
|
)
|
2015-02-13 09:20:05 -05:00
|
|
|
|
2019-12-04 12:27:32 -05:00
|
|
|
logger.info(
|
|
|
|
"After state res: updating auth_events with new state %s",
|
|
|
|
{
|
|
|
|
(d.type, d.state_key): d.event_id
|
|
|
|
for d in new_state.values()
|
|
|
|
if auth_events.get((d.type, d.state_key)) != d
|
|
|
|
},
|
|
|
|
)
|
2015-02-13 09:20:05 -05:00
|
|
|
|
2019-12-04 12:27:32 -05:00
|
|
|
auth_events.update(new_state)
|
2015-02-13 09:20:05 -05:00
|
|
|
|
2020-02-03 10:53:30 -05:00
|
|
|
context = await self._update_context_for_auth_events(
|
2019-12-04 12:27:32 -05:00
|
|
|
event, context, auth_events
|
|
|
|
)
|
2015-02-06 10:16:26 -05:00
|
|
|
|
2021-08-06 08:54:23 -04:00
|
|
|
return context, auth_events
|
2019-11-01 12:19:09 -04:00
|
|
|
|
2020-02-03 10:55:35 -05:00
|
|
|
async def _update_context_for_auth_events(
|
|
|
|
self, event: EventBase, context: EventContext, auth_events: StateMap[EventBase]
|
|
|
|
) -> EventContext:
|
2018-02-06 09:31:24 -05:00
|
|
|
"""Update the state_ids in an event context after auth event resolution,
|
|
|
|
storing the changes as a new state group.
|
2017-11-07 11:43:00 -05:00
|
|
|
|
|
|
|
Args:
|
2020-02-03 10:55:35 -05:00
|
|
|
event: The event we're handling the context for
|
2018-02-06 09:31:24 -05:00
|
|
|
|
2020-02-03 10:55:35 -05:00
|
|
|
context: initial event context
|
2017-11-07 11:43:00 -05:00
|
|
|
|
2020-02-03 10:55:35 -05:00
|
|
|
auth_events: Events to update in the event context.
|
2017-11-07 11:43:00 -05:00
|
|
|
|
2019-11-01 12:19:09 -04:00
|
|
|
Returns:
|
2020-02-03 10:55:35 -05:00
|
|
|
new event context
|
2017-11-07 11:43:00 -05:00
|
|
|
"""
|
2019-10-11 11:05:21 -04:00
|
|
|
# exclude the state key of the new event from the current_state in the context.
|
|
|
|
if event.is_state():
|
2021-07-16 13:22:36 -04:00
|
|
|
event_key: Optional[Tuple[str, str]] = (event.type, event.state_key)
|
2019-10-11 11:05:21 -04:00
|
|
|
else:
|
|
|
|
event_key = None
|
2017-11-07 11:43:00 -05:00
|
|
|
state_updates = {
|
2020-06-15 07:03:36 -04:00
|
|
|
k: a.event_id for k, a in auth_events.items() if k != event_key
|
2017-11-07 11:43:00 -05:00
|
|
|
}
|
2019-10-11 11:05:21 -04:00
|
|
|
|
2020-02-03 10:55:35 -05:00
|
|
|
current_state_ids = await context.get_current_state_ids()
|
2020-07-27 13:40:22 -04:00
|
|
|
current_state_ids = dict(current_state_ids) # type: ignore
|
2018-07-23 08:02:09 -04:00
|
|
|
|
|
|
|
current_state_ids.update(state_updates)
|
|
|
|
|
2020-02-03 10:55:35 -05:00
|
|
|
prev_state_ids = await context.get_prev_state_ids()
|
2018-07-23 08:02:09 -04:00
|
|
|
prev_state_ids = dict(prev_state_ids)
|
|
|
|
|
2020-06-15 07:03:36 -04:00
|
|
|
prev_state_ids.update({k: a.event_id for k, a in auth_events.items()})
|
2018-07-23 08:02:09 -04:00
|
|
|
|
2018-07-23 17:06:50 -04:00
|
|
|
# create a new state group as a delta from the existing one.
|
|
|
|
prev_group = context.state_group
|
2020-02-03 10:55:35 -05:00
|
|
|
state_group = await self.state_store.store_state_group(
|
2018-02-06 09:31:24 -05:00
|
|
|
event.event_id,
|
|
|
|
event.room_id,
|
2018-07-23 17:06:50 -04:00
|
|
|
prev_group=prev_group,
|
|
|
|
delta_ids=state_updates,
|
2018-07-23 08:02:09 -04:00
|
|
|
current_state_ids=current_state_ids,
|
|
|
|
)
|
|
|
|
|
2019-11-01 12:19:09 -04:00
|
|
|
return EventContext.with_state(
|
2018-07-23 08:02:09 -04:00
|
|
|
state_group=state_group,
|
2019-11-06 05:01:39 -05:00
|
|
|
state_group_before_event=context.state_group_before_event,
|
2018-07-23 08:02:09 -04:00
|
|
|
current_state_ids=current_state_ids,
|
|
|
|
prev_state_ids=prev_state_ids,
|
2018-07-23 17:06:50 -04:00
|
|
|
prev_group=prev_group,
|
|
|
|
delta_ids=state_updates,
|
2018-02-06 09:31:24 -05:00
|
|
|
)
|
2017-11-07 11:43:00 -05:00
|
|
|
|
2020-02-03 11:00:46 -05:00
|
|
|
async def construct_auth_difference(
|
|
|
|
self, local_auth: Iterable[EventBase], remote_auth: Iterable[EventBase]
|
|
|
|
) -> Dict:
|
2015-01-28 11:16:53 -05:00
|
|
|
"""Given a local and remote auth chain, find the differences. This
|
|
|
|
assumes that we have already processed all events in remote_auth
|
|
|
|
|
|
|
|
Params:
|
2021-04-06 07:21:57 -04:00
|
|
|
local_auth
|
|
|
|
remote_auth
|
2015-01-28 11:16:53 -05:00
|
|
|
|
|
|
|
Returns:
|
|
|
|
dict
|
|
|
|
"""
|
|
|
|
|
2015-01-29 11:50:23 -05:00
|
|
|
logger.debug("construct_auth_difference Start!")
|
|
|
|
|
2015-01-28 11:16:53 -05:00
|
|
|
# TODO: Make sure we are OK with local_auth or remote_auth having more
|
|
|
|
# auth events in them than strictly necessary.
|
|
|
|
|
|
|
|
def sort_fun(ev):
|
|
|
|
return ev.depth, ev.event_id
|
|
|
|
|
2015-01-29 11:50:23 -05:00
|
|
|
logger.debug("construct_auth_difference after sort_fun!")
|
|
|
|
|
2015-01-28 11:16:53 -05:00
|
|
|
# We find the differences by starting at the "bottom" of each list
|
|
|
|
# and iterating up on both lists. The lists are ordered by depth and
|
|
|
|
# then event_id, we iterate up both lists until we find the event ids
|
|
|
|
# don't match. Then we look at depth/event_id to see which side is
|
|
|
|
# missing that event, and iterate only up that list. Repeat.
|
|
|
|
|
|
|
|
remote_list = list(remote_auth)
|
|
|
|
remote_list.sort(key=sort_fun)
|
|
|
|
|
|
|
|
local_list = list(local_auth)
|
|
|
|
local_list.sort(key=sort_fun)
|
|
|
|
|
|
|
|
local_iter = iter(local_list)
|
|
|
|
remote_iter = iter(remote_list)
|
|
|
|
|
2015-01-29 11:50:23 -05:00
|
|
|
logger.debug("construct_auth_difference before get_next!")
|
2015-01-28 11:16:53 -05:00
|
|
|
|
|
|
|
def get_next(it, opt=None):
|
2015-01-29 11:50:23 -05:00
|
|
|
try:
|
2018-05-05 16:47:18 -04:00
|
|
|
return next(it)
|
2017-10-23 10:52:32 -04:00
|
|
|
except Exception:
|
2015-01-29 11:50:23 -05:00
|
|
|
return opt
|
|
|
|
|
|
|
|
current_local = get_next(local_iter)
|
|
|
|
current_remote = get_next(remote_iter)
|
|
|
|
|
|
|
|
logger.debug("construct_auth_difference before while")
|
2015-01-28 11:16:53 -05:00
|
|
|
|
|
|
|
missing_remotes = []
|
|
|
|
missing_locals = []
|
2015-01-30 05:48:47 -05:00
|
|
|
while current_local or current_remote:
|
2015-01-28 11:16:53 -05:00
|
|
|
if current_remote is None:
|
|
|
|
missing_locals.append(current_local)
|
|
|
|
current_local = get_next(local_iter)
|
|
|
|
continue
|
|
|
|
|
|
|
|
if current_local is None:
|
|
|
|
missing_remotes.append(current_remote)
|
|
|
|
current_remote = get_next(remote_iter)
|
|
|
|
continue
|
|
|
|
|
|
|
|
if current_local.event_id == current_remote.event_id:
|
|
|
|
current_local = get_next(local_iter)
|
|
|
|
current_remote = get_next(remote_iter)
|
|
|
|
continue
|
|
|
|
|
|
|
|
if current_local.depth < current_remote.depth:
|
|
|
|
missing_locals.append(current_local)
|
|
|
|
current_local = get_next(local_iter)
|
|
|
|
continue
|
|
|
|
|
|
|
|
if current_local.depth > current_remote.depth:
|
|
|
|
missing_remotes.append(current_remote)
|
|
|
|
current_remote = get_next(remote_iter)
|
|
|
|
continue
|
|
|
|
|
|
|
|
# They have the same depth, so we fall back to the event_id order
|
|
|
|
if current_local.event_id < current_remote.event_id:
|
|
|
|
missing_locals.append(current_local)
|
|
|
|
current_local = get_next(local_iter)
|
|
|
|
|
|
|
|
if current_local.event_id > current_remote.event_id:
|
|
|
|
missing_remotes.append(current_remote)
|
|
|
|
current_remote = get_next(remote_iter)
|
|
|
|
continue
|
|
|
|
|
2015-01-29 11:50:23 -05:00
|
|
|
logger.debug("construct_auth_difference after while")
|
|
|
|
|
2015-01-28 11:16:53 -05:00
|
|
|
# missing locals should be sent to the server
|
|
|
|
# We should find why we are missing remotes, as they will have been
|
|
|
|
# rejected.
|
|
|
|
|
|
|
|
# Remove events from missing_remotes if they are referencing a missing
|
|
|
|
# remote. We only care about the "root" rejected ones.
|
|
|
|
missing_remote_ids = [e.event_id for e in missing_remotes]
|
|
|
|
base_remote_rejected = list(missing_remotes)
|
|
|
|
for e in missing_remotes:
|
2018-11-05 08:35:15 -05:00
|
|
|
for e_id in e.auth_event_ids():
|
2015-01-28 11:16:53 -05:00
|
|
|
if e_id in missing_remote_ids:
|
2015-02-06 05:53:18 -05:00
|
|
|
try:
|
|
|
|
base_remote_rejected.remove(e)
|
|
|
|
except ValueError:
|
|
|
|
pass
|
2015-01-28 11:16:53 -05:00
|
|
|
|
|
|
|
reason_map = {}
|
|
|
|
|
|
|
|
for e in base_remote_rejected:
|
2020-02-03 11:00:46 -05:00
|
|
|
reason = await self.store.get_rejection_reason(e.event_id)
|
2015-01-28 11:16:53 -05:00
|
|
|
if reason is None:
|
2015-02-06 09:16:50 -05:00
|
|
|
# TODO: e is not in the current state, so we should
|
|
|
|
# construct some proof of that.
|
|
|
|
continue
|
2015-01-28 11:16:53 -05:00
|
|
|
|
|
|
|
reason_map[e.event_id] = reason
|
|
|
|
|
2015-01-29 11:50:23 -05:00
|
|
|
logger.debug("construct_auth_difference returning")
|
|
|
|
|
2019-07-23 09:00:55 -04:00
|
|
|
return {
|
|
|
|
"auth_chain": local_auth,
|
|
|
|
"rejects": {
|
|
|
|
e.event_id: {"reason": reason_map[e.event_id], "proof": None}
|
|
|
|
for e in base_remote_rejected
|
|
|
|
},
|
|
|
|
"missing": [e.event_id for e in missing_locals],
|
|
|
|
}
|
2015-11-05 11:43:19 -05:00
|
|
|
|
|
|
|
@log_function
|
2020-05-01 10:15:36 -04:00
|
|
|
async def exchange_third_party_invite(
|
2021-04-06 07:21:57 -04:00
|
|
|
self, sender_user_id: str, target_user_id: str, room_id: str, signed: JsonDict
|
|
|
|
) -> None:
|
2015-12-17 12:09:51 -05:00
|
|
|
third_party_invite = {"signed": signed}
|
|
|
|
|
2015-11-05 11:43:19 -05:00
|
|
|
event_dict = {
|
|
|
|
"type": EventTypes.Member,
|
|
|
|
"content": {
|
|
|
|
"membership": Membership.INVITE,
|
2015-12-17 12:09:51 -05:00
|
|
|
"third_party_invite": third_party_invite,
|
2015-11-05 11:43:19 -05:00
|
|
|
},
|
|
|
|
"room_id": room_id,
|
2016-02-23 10:11:25 -05:00
|
|
|
"sender": sender_user_id,
|
|
|
|
"state_key": target_user_id,
|
2015-11-05 11:43:19 -05:00
|
|
|
}
|
|
|
|
|
2021-07-01 14:25:37 -04:00
|
|
|
if await self._event_auth_handler.check_host_in_room(room_id, self.hs.hostname):
|
2020-05-01 10:15:36 -04:00
|
|
|
room_version = await self.store.get_room_version_id(room_id)
|
2019-01-23 15:21:33 -05:00
|
|
|
builder = self.event_builder_factory.new(room_version, event_dict)
|
|
|
|
|
2019-01-28 12:00:14 -05:00
|
|
|
EventValidator().validate_builder(builder)
|
2020-05-01 10:15:36 -04:00
|
|
|
event, context = await self.event_creation_handler.create_new_client_event(
|
2016-05-11 04:09:20 -04:00
|
|
|
builder=builder
|
|
|
|
)
|
2015-12-17 12:31:20 -05:00
|
|
|
|
2020-05-01 10:15:36 -04:00
|
|
|
event, context = await self.add_display_name_to_third_party_invite(
|
2019-01-23 15:21:33 -05:00
|
|
|
room_version, event_dict, event, context
|
2015-12-17 12:31:20 -05:00
|
|
|
)
|
|
|
|
|
2019-11-04 12:09:22 -05:00
|
|
|
EventValidator().validate_new(event, self.config)
|
2019-01-28 12:00:14 -05:00
|
|
|
|
2019-01-29 11:15:16 -05:00
|
|
|
# We need to tell the transaction queue to send this out, even
|
|
|
|
# though the sender isn't a local user.
|
|
|
|
event.internal_metadata.send_on_behalf_of = self.hs.hostname
|
|
|
|
|
2016-04-13 06:11:46 -04:00
|
|
|
try:
|
2021-07-01 14:25:37 -04:00
|
|
|
await self._event_auth_handler.check_from_context(
|
|
|
|
room_version, event, context
|
|
|
|
)
|
2016-04-13 06:11:46 -04:00
|
|
|
except AuthError as e:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning("Denying new third party invite %r because %s", event, e)
|
2016-04-13 06:11:46 -04:00
|
|
|
raise e
|
|
|
|
|
2020-05-01 10:15:36 -04:00
|
|
|
await self._check_signature(event, context)
|
2019-11-01 06:28:09 -04:00
|
|
|
|
|
|
|
# We retrieve the room member handler here as to not cause a cyclic dependency
|
2018-03-01 05:54:37 -05:00
|
|
|
member_handler = self.hs.get_room_member_handler()
|
2020-05-01 10:15:36 -04:00
|
|
|
await member_handler.send_membership_event(None, event, context)
|
2015-11-05 11:43:19 -05:00
|
|
|
else:
|
2020-02-21 07:15:07 -05:00
|
|
|
destinations = {x.split(":", 1)[-1] for x in (sender_user_id, room_id)}
|
2021-07-15 05:35:46 -04:00
|
|
|
|
|
|
|
try:
|
|
|
|
await self.federation_client.forward_third_party_invite(
|
|
|
|
destinations, room_id, event_dict
|
|
|
|
)
|
|
|
|
except (RequestSendFailed, HttpResponseException):
|
|
|
|
raise SynapseError(502, "Failed to forward third party invite")
|
2015-11-05 11:43:19 -05:00
|
|
|
|
2020-02-03 11:02:50 -05:00
|
|
|
async def on_exchange_third_party_invite_request(
|
2020-11-19 05:05:33 -05:00
|
|
|
self, event_dict: JsonDict
|
2020-02-03 11:02:50 -05:00
|
|
|
) -> None:
|
2017-09-19 07:18:01 -04:00
|
|
|
"""Handle an exchange_third_party_invite request from a remote server
|
|
|
|
|
|
|
|
The remote server will call this when it wants to turn a 3pid invite
|
|
|
|
into a normal m.room.member invite.
|
|
|
|
|
2019-09-11 05:37:17 -04:00
|
|
|
Args:
|
2020-11-19 05:05:33 -05:00
|
|
|
event_dict: Dictionary containing the event body.
|
2019-09-11 05:37:17 -04:00
|
|
|
|
2017-09-19 07:18:01 -04:00
|
|
|
"""
|
2020-11-19 05:05:33 -05:00
|
|
|
assert_params_in_dict(event_dict, ["room_id"])
|
|
|
|
room_version = await self.store.get_room_version_id(event_dict["room_id"])
|
2019-01-23 15:21:33 -05:00
|
|
|
|
|
|
|
# NB: event_dict has a particular specced format we might need to fudge
|
|
|
|
# if we change event formats too much.
|
|
|
|
builder = self.event_builder_factory.new(room_version, event_dict)
|
2015-11-05 11:43:19 -05:00
|
|
|
|
2020-02-03 11:02:50 -05:00
|
|
|
event, context = await self.event_creation_handler.create_new_client_event(
|
2015-11-05 11:43:19 -05:00
|
|
|
builder=builder
|
|
|
|
)
|
2020-02-03 11:02:50 -05:00
|
|
|
event, context = await self.add_display_name_to_third_party_invite(
|
2019-01-23 15:21:33 -05:00
|
|
|
room_version, event_dict, event, context
|
2015-12-17 12:31:20 -05:00
|
|
|
)
|
|
|
|
|
2016-04-13 06:11:46 -04:00
|
|
|
try:
|
2021-07-01 14:25:37 -04:00
|
|
|
await self._event_auth_handler.check_from_context(
|
|
|
|
room_version, event, context
|
|
|
|
)
|
2016-04-13 06:11:46 -04:00
|
|
|
except AuthError as e:
|
2019-10-31 06:23:24 -04:00
|
|
|
logger.warning("Denying third party invite %r because %s", event, e)
|
2016-04-13 06:11:46 -04:00
|
|
|
raise e
|
2020-02-03 11:02:50 -05:00
|
|
|
await self._check_signature(event, context)
|
2015-11-05 11:43:19 -05:00
|
|
|
|
2019-01-29 11:15:16 -05:00
|
|
|
# We need to tell the transaction queue to send this out, even
|
|
|
|
# though the sender isn't a local user.
|
|
|
|
event.internal_metadata.send_on_behalf_of = get_domain_from_id(event.sender)
|
|
|
|
|
2019-11-01 06:28:09 -04:00
|
|
|
# We retrieve the room member handler here as to not cause a cyclic dependency
|
2018-03-01 05:54:37 -05:00
|
|
|
member_handler = self.hs.get_room_member_handler()
|
2020-02-03 11:02:50 -05:00
|
|
|
await member_handler.send_membership_event(None, event, context)
|
2015-11-05 11:43:19 -05:00
|
|
|
|
2020-05-11 15:12:46 -04:00
|
|
|
async def add_display_name_to_third_party_invite(
|
2021-04-06 07:21:57 -04:00
|
|
|
self,
|
|
|
|
room_version: str,
|
|
|
|
event_dict: JsonDict,
|
|
|
|
event: EventBase,
|
|
|
|
context: EventContext,
|
|
|
|
) -> Tuple[EventBase, EventContext]:
|
2015-12-17 12:31:20 -05:00
|
|
|
key = (
|
|
|
|
EventTypes.ThirdPartyInvite,
|
|
|
|
event.content["third_party_invite"]["signed"]["token"],
|
|
|
|
)
|
2016-08-25 12:32:22 -04:00
|
|
|
original_invite = None
|
2020-05-11 15:12:46 -04:00
|
|
|
prev_state_ids = await context.get_prev_state_ids()
|
2018-07-23 08:00:22 -04:00
|
|
|
original_invite_id = prev_state_ids.get(key)
|
2016-08-25 12:32:22 -04:00
|
|
|
if original_invite_id:
|
2020-05-11 15:12:46 -04:00
|
|
|
original_invite = await self.store.get_event(
|
2016-08-25 12:32:22 -04:00
|
|
|
original_invite_id, allow_none=True
|
|
|
|
)
|
2016-09-22 05:56:53 -04:00
|
|
|
if original_invite:
|
2019-10-02 06:16:38 -04:00
|
|
|
# If the m.room.third_party_invite event's content is empty, it means the
|
2019-10-04 06:16:19 -04:00
|
|
|
# invite has been revoked. In this case, we don't have to raise an error here
|
|
|
|
# because the auth check will fail on the invite (because it's not able to
|
|
|
|
# fetch public keys from the m.room.third_party_invite event's content, which
|
2019-10-04 06:21:24 -04:00
|
|
|
# is empty).
|
2019-10-04 06:16:19 -04:00
|
|
|
display_name = original_invite.content.get("display_name")
|
2019-10-04 06:18:28 -04:00
|
|
|
event_dict["content"]["third_party_invite"]["display_name"] = display_name
|
2016-09-22 05:56:53 -04:00
|
|
|
else:
|
2015-12-17 12:31:20 -05:00
|
|
|
logger.info(
|
2016-09-22 05:56:53 -04:00
|
|
|
"Could not find invite event for third_party_invite: %r", event_dict
|
2015-12-17 12:31:20 -05:00
|
|
|
)
|
2016-09-22 06:59:46 -04:00
|
|
|
# We don't discard here as this is not the appropriate place to do
|
|
|
|
# auth checks. If we need the invite and don't have it then the
|
|
|
|
# auth check code will explode appropriately.
|
2015-12-17 12:31:20 -05:00
|
|
|
|
2019-01-23 15:21:33 -05:00
|
|
|
builder = self.event_builder_factory.new(room_version, event_dict)
|
2019-01-28 12:00:14 -05:00
|
|
|
EventValidator().validate_builder(builder)
|
2020-05-11 15:12:46 -04:00
|
|
|
event, context = await self.event_creation_handler.create_new_client_event(
|
2018-01-15 11:52:07 -05:00
|
|
|
builder=builder
|
|
|
|
)
|
2019-11-19 09:07:39 -05:00
|
|
|
EventValidator().validate_new(event, self.config)
|
2019-07-23 09:00:55 -04:00
|
|
|
return (event, context)
|
2015-12-17 12:31:20 -05:00
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def _check_signature(self, event: EventBase, context: EventContext) -> None:
|
2016-02-23 10:11:25 -05:00
|
|
|
"""
|
|
|
|
Checks that the signature in the event is consistent with its invite.
|
|
|
|
|
2016-04-01 11:08:59 -04:00
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
event: The m.room.member event to check
|
|
|
|
context:
|
2016-04-01 11:08:59 -04:00
|
|
|
|
|
|
|
Raises:
|
|
|
|
AuthError: if signature didn't match any keys, or key has been
|
2016-02-23 10:11:25 -05:00
|
|
|
revoked,
|
2016-04-01 11:08:59 -04:00
|
|
|
SynapseError: if a transient error meant a key couldn't be checked
|
2016-02-23 10:11:25 -05:00
|
|
|
for revocation.
|
|
|
|
"""
|
|
|
|
signed = event.content["third_party_invite"]["signed"]
|
|
|
|
token = signed["token"]
|
2015-11-05 11:43:19 -05:00
|
|
|
|
2020-05-11 15:12:46 -04:00
|
|
|
prev_state_ids = await context.get_prev_state_ids()
|
2018-07-23 08:00:22 -04:00
|
|
|
invite_event_id = prev_state_ids.get((EventTypes.ThirdPartyInvite, token))
|
2015-11-05 11:43:19 -05:00
|
|
|
|
2016-08-25 12:32:22 -04:00
|
|
|
invite_event = None
|
|
|
|
if invite_event_id:
|
2020-05-11 15:12:46 -04:00
|
|
|
invite_event = await self.store.get_event(invite_event_id, allow_none=True)
|
2016-08-25 12:32:22 -04:00
|
|
|
|
2016-02-23 10:11:25 -05:00
|
|
|
if not invite_event:
|
|
|
|
raise AuthError(403, "Could not find invite")
|
|
|
|
|
2019-06-18 17:51:24 -04:00
|
|
|
logger.debug("Checking auth on event %r", event.content)
|
|
|
|
|
2021-07-16 13:22:36 -04:00
|
|
|
last_exception: Optional[Exception] = None
|
2020-07-01 11:21:02 -04:00
|
|
|
|
2019-06-18 17:51:24 -04:00
|
|
|
# for each public key in the 3pid invite event
|
2021-07-01 14:25:37 -04:00
|
|
|
for public_key_object in event_auth.get_public_keys(invite_event):
|
2016-02-23 10:11:25 -05:00
|
|
|
try:
|
2019-06-18 17:51:24 -04:00
|
|
|
# for each sig on the third_party_invite block of the actual invite
|
2016-02-23 10:11:25 -05:00
|
|
|
for server, signature_block in signed["signatures"].items():
|
2021-04-20 06:50:49 -04:00
|
|
|
for key_name in signature_block.keys():
|
2016-02-23 10:11:25 -05:00
|
|
|
if not key_name.startswith("ed25519:"):
|
|
|
|
continue
|
|
|
|
|
2019-06-18 17:51:24 -04:00
|
|
|
logger.debug(
|
|
|
|
"Attempting to verify sig with key %s from %r "
|
|
|
|
"against pubkey %r",
|
|
|
|
key_name,
|
|
|
|
server,
|
|
|
|
public_key_object,
|
2016-02-23 10:11:25 -05:00
|
|
|
)
|
2019-06-18 17:51:24 -04:00
|
|
|
|
|
|
|
try:
|
|
|
|
public_key = public_key_object["public_key"]
|
|
|
|
verify_key = decode_verify_key_bytes(
|
|
|
|
key_name, decode_base64(public_key)
|
|
|
|
)
|
|
|
|
verify_signed_json(signed, server, verify_key)
|
|
|
|
logger.debug(
|
|
|
|
"Successfully verified sig with key %s from %r "
|
|
|
|
"against pubkey %r",
|
|
|
|
key_name,
|
|
|
|
server,
|
|
|
|
public_key_object,
|
|
|
|
)
|
|
|
|
except Exception:
|
|
|
|
logger.info(
|
|
|
|
"Failed to verify sig with key %s from %r "
|
|
|
|
"against pubkey %r",
|
|
|
|
key_name,
|
|
|
|
server,
|
|
|
|
public_key_object,
|
|
|
|
)
|
|
|
|
raise
|
|
|
|
try:
|
|
|
|
if "key_validity_url" in public_key_object:
|
2020-05-11 15:12:46 -04:00
|
|
|
await self._check_key_revocation(
|
2019-06-18 17:51:24 -04:00
|
|
|
public_key, public_key_object["key_validity_url"]
|
|
|
|
)
|
|
|
|
except Exception:
|
|
|
|
logger.info(
|
|
|
|
"Failed to query key_validity_url %s",
|
2016-02-23 10:11:25 -05:00
|
|
|
public_key_object["key_validity_url"],
|
|
|
|
)
|
2019-06-18 17:51:24 -04:00
|
|
|
raise
|
2016-02-23 10:11:25 -05:00
|
|
|
return
|
|
|
|
except Exception as e:
|
|
|
|
last_exception = e
|
2020-07-01 11:21:02 -04:00
|
|
|
|
|
|
|
if last_exception is None:
|
|
|
|
# we can only get here if get_public_keys() returned an empty list
|
|
|
|
# TODO: make this better
|
|
|
|
raise RuntimeError("no public key in invite event")
|
|
|
|
|
2016-02-23 10:11:25 -05:00
|
|
|
raise last_exception
|
|
|
|
|
2021-04-06 07:21:57 -04:00
|
|
|
async def _check_key_revocation(self, public_key: str, url: str) -> None:
|
2016-02-23 10:11:25 -05:00
|
|
|
"""
|
|
|
|
Checks whether public_key has been revoked.
|
|
|
|
|
2016-04-01 11:08:59 -04:00
|
|
|
Args:
|
2021-04-06 07:21:57 -04:00
|
|
|
public_key: base-64 encoded public key.
|
|
|
|
url: Key revocation URL.
|
2016-02-23 10:11:25 -05:00
|
|
|
|
2016-04-01 11:08:59 -04:00
|
|
|
Raises:
|
|
|
|
AuthError: if they key has been revoked.
|
|
|
|
SynapseError: if a transient error meant a key couldn't be checked
|
2016-02-23 10:11:25 -05:00
|
|
|
for revocation.
|
|
|
|
"""
|
2015-11-05 11:43:19 -05:00
|
|
|
try:
|
2020-05-11 15:12:46 -04:00
|
|
|
response = await self.http_client.get_json(url, {"public_key": public_key})
|
2015-11-05 11:43:19 -05:00
|
|
|
except Exception:
|
|
|
|
raise SynapseError(502, "Third party certificate could not be checked")
|
|
|
|
if "valid" not in response or not response["valid"]:
|
|
|
|
raise AuthError(403, "Third party certificate was invalid")
|
2018-07-25 11:00:38 -04:00
|
|
|
|
2020-02-03 11:24:07 -05:00
|
|
|
async def persist_events_and_notify(
|
|
|
|
self,
|
2020-09-14 05:16:41 -04:00
|
|
|
room_id: str,
|
2020-02-03 11:24:07 -05:00
|
|
|
event_and_contexts: Sequence[Tuple[EventBase, EventContext]],
|
|
|
|
backfilled: bool = False,
|
2020-05-22 09:21:54 -04:00
|
|
|
) -> int:
|
2018-07-25 11:00:38 -04:00
|
|
|
"""Persists events and tells the notifier/pushers about them, if
|
|
|
|
necessary.
|
|
|
|
|
|
|
|
Args:
|
2020-09-14 05:16:41 -04:00
|
|
|
room_id: The room ID of events being persisted.
|
|
|
|
event_and_contexts: Sequence of events with their associated
|
|
|
|
context that should be persisted. All events must belong to
|
|
|
|
the same room.
|
2020-02-03 11:24:07 -05:00
|
|
|
backfilled: Whether these events are a result of
|
2018-07-25 11:00:38 -04:00
|
|
|
backfilling or not
|
2021-06-08 05:37:01 -04:00
|
|
|
|
|
|
|
Returns:
|
|
|
|
The stream ID after which all events have been persisted.
|
2018-07-25 11:00:38 -04:00
|
|
|
"""
|
2021-06-08 05:37:01 -04:00
|
|
|
if not event_and_contexts:
|
|
|
|
return self.store.get_current_events_token()
|
|
|
|
|
2020-09-14 05:16:41 -04:00
|
|
|
instance = self.config.worker.events_shard_config.get_instance(room_id)
|
|
|
|
if instance != self._instance_name:
|
2021-06-04 05:35:47 -04:00
|
|
|
# Limit the number of events sent over replication. We choose 200
|
|
|
|
# here as that is what we default to in `max_request_body_size(..)`
|
|
|
|
for batch in batch_iter(event_and_contexts, 200):
|
2021-05-27 12:10:58 -04:00
|
|
|
result = await self._send_events(
|
|
|
|
instance_name=instance,
|
|
|
|
store=self.store,
|
|
|
|
room_id=room_id,
|
|
|
|
event_and_contexts=batch,
|
|
|
|
backfilled=backfilled,
|
|
|
|
)
|
2020-05-22 09:21:54 -04:00
|
|
|
return result["max_stream_id"]
|
2018-07-25 11:32:05 -04:00
|
|
|
else:
|
2020-09-29 10:57:36 -04:00
|
|
|
assert self.storage.persistence
|
2020-10-13 07:07:56 -04:00
|
|
|
|
|
|
|
# Note that this returns the events that were persisted, which may not be
|
|
|
|
# the same as were passed in if some were deduplicated due to transaction IDs.
|
|
|
|
events, max_stream_token = await self.storage.persistence.persist_events(
|
2018-07-25 11:32:05 -04:00
|
|
|
event_and_contexts, backfilled=backfilled
|
|
|
|
)
|
2018-07-25 11:00:38 -04:00
|
|
|
|
2019-12-03 14:19:45 -05:00
|
|
|
if self._ephemeral_messages_enabled:
|
2020-10-13 07:07:56 -04:00
|
|
|
for event in events:
|
2019-12-03 14:19:45 -05:00
|
|
|
# If there's an expiry timestamp on the event, schedule its expiry.
|
|
|
|
self._message_handler.maybe_schedule_expiry(event)
|
|
|
|
|
2018-07-25 11:32:05 -04:00
|
|
|
if not backfilled: # Never notify for backfilled events
|
2020-10-13 07:07:56 -04:00
|
|
|
for event in events:
|
2020-09-24 08:24:17 -04:00
|
|
|
await self._notify_persisted_event(event, max_stream_token)
|
2018-07-25 11:00:38 -04:00
|
|
|
|
2020-09-24 08:24:17 -04:00
|
|
|
return max_stream_token.stream
|
2020-05-22 09:21:54 -04:00
|
|
|
|
2020-02-03 11:25:41 -05:00
|
|
|
async def _notify_persisted_event(
|
2020-09-24 08:24:17 -04:00
|
|
|
self, event: EventBase, max_stream_token: RoomStreamToken
|
2020-02-03 11:25:41 -05:00
|
|
|
) -> None:
|
2018-07-25 11:00:38 -04:00
|
|
|
"""Checks to see if notifier/pushers should be notified about the
|
|
|
|
event or not.
|
|
|
|
|
|
|
|
Args:
|
2020-02-03 11:25:41 -05:00
|
|
|
event:
|
|
|
|
max_stream_id: The max_stream_id returned by persist_events
|
2018-07-25 11:00:38 -04:00
|
|
|
"""
|
|
|
|
|
|
|
|
extra_users = []
|
|
|
|
if event.type == EventTypes.Member:
|
|
|
|
target_user_id = event.state_key
|
|
|
|
|
|
|
|
# We notify for memberships if its an invite for one of our
|
|
|
|
# users
|
|
|
|
if event.internal_metadata.is_outlier():
|
|
|
|
if event.membership != Membership.INVITE:
|
|
|
|
if not self.is_mine_id(target_user_id):
|
|
|
|
return
|
|
|
|
|
|
|
|
target_user = UserID.from_string(target_user_id)
|
|
|
|
extra_users.append(target_user)
|
|
|
|
elif event.internal_metadata.is_outlier():
|
|
|
|
return
|
|
|
|
|
2020-10-05 09:43:14 -04:00
|
|
|
# the event has been persisted so it should have a stream ordering.
|
|
|
|
assert event.internal_metadata.stream_ordering
|
|
|
|
|
2020-09-24 08:24:17 -04:00
|
|
|
event_pos = PersistedEventPosition(
|
|
|
|
self._instance_name, event.internal_metadata.stream_ordering
|
|
|
|
)
|
2018-07-25 11:00:38 -04:00
|
|
|
self.notifier.on_new_room_event(
|
2020-09-24 08:24:17 -04:00
|
|
|
event, event_pos, max_stream_token, extra_users=extra_users
|
2018-07-25 11:00:38 -04:00
|
|
|
)
|
|
|
|
|
2020-02-03 11:27:05 -05:00
|
|
|
async def _clean_room_for_join(self, room_id: str) -> None:
|
2018-08-09 05:29:48 -04:00
|
|
|
"""Called to clean up any data in DB for a given room, ready for the
|
|
|
|
server to join the room.
|
|
|
|
|
|
|
|
Args:
|
2020-02-03 11:27:05 -05:00
|
|
|
room_id
|
2018-08-09 05:29:48 -04:00
|
|
|
"""
|
|
|
|
if self.config.worker_app:
|
2020-02-03 11:27:05 -05:00
|
|
|
await self._clean_room_for_join_client(room_id)
|
2018-08-09 05:29:48 -04:00
|
|
|
else:
|
2020-02-03 11:27:05 -05:00
|
|
|
await self.store.clean_room_for_join(room_id)
|
2018-07-25 11:00:38 -04:00
|
|
|
|
2020-07-24 10:53:25 -04:00
|
|
|
async def get_room_complexity(
|
|
|
|
self, remote_room_hosts: List[str], room_id: str
|
|
|
|
) -> Optional[dict]:
|
2019-07-29 12:47:27 -04:00
|
|
|
"""
|
|
|
|
Fetch the complexity of a remote room over federation.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
remote_room_hosts (list[str]): The remote servers to ask.
|
|
|
|
room_id (str): The room ID to ask about.
|
|
|
|
|
|
|
|
Returns:
|
2020-07-24 10:53:25 -04:00
|
|
|
Dict contains the complexity
|
2019-07-29 12:47:27 -04:00
|
|
|
metric versions, while None means we could not fetch the complexity.
|
|
|
|
"""
|
|
|
|
|
|
|
|
for host in remote_room_hosts:
|
2020-05-11 15:12:46 -04:00
|
|
|
res = await self.federation_client.get_room_complexity(host, room_id)
|
2019-07-29 12:47:27 -04:00
|
|
|
|
|
|
|
# We got a result, return it.
|
|
|
|
if res:
|
2020-05-11 15:12:46 -04:00
|
|
|
return res
|
2019-07-29 12:47:27 -04:00
|
|
|
|
|
|
|
# We fell off the bottom, couldn't get the complexity from anyone. Oh
|
|
|
|
# well.
|
2020-05-11 15:12:46 -04:00
|
|
|
return None
|