Fix: Improve syntax & fix weird label logic

This commit is contained in:
Nelson Chan 2023-01-09 00:16:18 +08:00
parent 942b55ca03
commit dd82f36da3

View File

@ -143,36 +143,23 @@ router.get("/api/badge/:id/status", cache("5 minutes"), async (request, response
const heartbeat = await Monitor.getPreviousHeartbeat(requestedMonitorId); const heartbeat = await Monitor.getPreviousHeartbeat(requestedMonitorId);
const state = overrideValue !== undefined ? overrideValue : heartbeat.status; const state = overrideValue !== undefined ? overrideValue : heartbeat.status;
badgeValues.label = label ? label : ""; badgeValues.label = label ?? "";
switch (state) { switch (state) {
case 1: case 1:
badgeValues.color = upColor; badgeValues.color = upColor;
badgeValues.message = upLabel;
break; break;
case 3: case 3:
badgeValues.color = maintenanceColor; badgeValues.color = maintenanceColor;
badgeValues.message = maintenanceLabel;
break; break;
case 0: case 0:
badgeValues.color = downColor; badgeValues.color = downColor;
badgeValues.message = downLabel;
break; break;
default: default:
badgeValues.color = badgeConstants.naColor; badgeValues.color = badgeConstants.naColor;
} badgeValues.message = "N/A";
if (label !== undefined) {
badgeValues.message = label;
} else {
switch (state) {
case 1:
badgeValues.message = upLabel;
break;
case 3:
badgeValues.message = maintenanceLabel;
break;
case 0:
badgeValues.message = downLabel;
break;
default:
badgeValues.message = "N/A";
}
} }
} }