perf: only do one filter instead of 3 in editMonitor

This commit is contained in:
Peace 2023-01-28 14:28:34 +01:00
parent 9a46b50989
commit aee4c22dee
No known key found for this signature in database
GPG Key ID: 0EF6B46E172B739F

View File

@ -760,9 +760,13 @@ message HealthCheckResponse {
sortedMonitorList() { sortedMonitorList() {
let result = Object.values(this.$root.monitorList); let result = Object.values(this.$root.monitorList);
console.log(this.monitor.childrenIDs); console.log(this.monitor.childrenIDs);
result = result.filter(monitor => monitor.type === "group");
result = result.filter(monitor => monitor.id !== this.monitor.id); // Only groups, not itself, not a decendant
result = result.filter(monitor => !this.monitor.childrenIDs?.includes(monitor.id)); result = result.filter(
monitor => monitor.type === "group" &&
monitor.id !== this.monitor.id &&
!this.monitor.childrenIDs?.includes(monitor.id)
);
result.sort((m1, m2) => { result.sort((m1, m2) => {