From 9c56c9b346b678fb0e92e2c3344f7cdaa615ff21 Mon Sep 17 00:00:00 2001
From: Frank Elsinga <frank@elsinga.de>
Date: Sun, 3 Dec 2023 18:15:40 +0100
Subject: [PATCH] Fixed the buttons of `ActionsSelect` and `ActionsInput`
 having a default `type="submit"` (#4162)

* fixed the buttons having a default type="submit"

* fixed linting issue
---
 src/components/ActionInput.vue            | 2 +-
 src/components/ActionSelect.vue           | 2 +-
 src/components/settings/Notifications.vue | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/components/ActionInput.vue b/src/components/ActionInput.vue
index 44c9e586..a61e4f96 100644
--- a/src/components/ActionInput.vue
+++ b/src/components/ActionInput.vue
@@ -8,7 +8,7 @@
             :placeholder="placeholder"
             :disabled="!enabled"
         >
-        <button class="btn btn-outline-primary" @click="action()" :aria-label="actionAriaLabel">
+        <button type="button" class="btn btn-outline-primary" :aria-label="actionAriaLabel" @click="action()">
             <font-awesome-icon :icon="icon" />
         </button>
     </div>
diff --git a/src/components/ActionSelect.vue b/src/components/ActionSelect.vue
index b163cd3a..d47154f4 100644
--- a/src/components/ActionSelect.vue
+++ b/src/components/ActionSelect.vue
@@ -3,7 +3,7 @@
         <select :id="id" ref="select" v-model="model" class="form-select" :disabled="disabled" :required="required">
             <option v-for="option in options" :key="option" :value="option.value" :disabled="option.disabled">{{ option.label }}</option>
         </select>
-        <button class="btn btn-outline-primary" :class="{ disabled: actionDisabled }" :aria-label="actionAriaLabel" @click="action()">
+        <button type="button" class="btn btn-outline-primary" :class="{ disabled: actionDisabled }" :aria-label="actionAriaLabel" @click="action()">
             <font-awesome-icon :icon="icon" aria-hidden="true" />
         </button>
     </div>
diff --git a/src/components/settings/Notifications.vue b/src/components/settings/Notifications.vue
index af1e92de..9c0264a5 100644
--- a/src/components/settings/Notifications.vue
+++ b/src/components/settings/Notifications.vue
@@ -27,7 +27,7 @@
             <div class="mt-1 mb-3 ps-2 cert-exp-days col-12 col-xl-6">
                 <div v-for="day in settings.tlsExpiryNotifyDays" :key="day" class="d-flex align-items-center justify-content-between cert-exp-day-row py-2">
                     <span>{{ day }} {{ $tc("day", day) }}</span>
-                    <button type="button" class="btn-rm-expiry btn btn-outline-danger ms-2 py-1" @click="removeExpiryNotifDay(day)" :aria-label="$t('Remove the expiry notification')">
+                    <button type="button" class="btn-rm-expiry btn btn-outline-danger ms-2 py-1" :aria-label="$t('Remove the expiry notification')" @click="removeExpiryNotifDay(day)">
                         <font-awesome-icon icon="times" />
                     </button>
                 </div>