From 617ba49e6c270d3892a12e3aec2d02739a6134ca Mon Sep 17 00:00:00 2001 From: Louis Lam Date: Sun, 18 Sep 2022 22:40:53 +0800 Subject: [PATCH] Fix race condition of `selectedStatusPagesOptions` --- src/pages/EditMaintenance.vue | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/pages/EditMaintenance.vue b/src/pages/EditMaintenance.vue index 65f2d7241..f010ca8ec 100644 --- a/src/pages/EditMaintenance.vue +++ b/src/pages/EditMaintenance.vue @@ -138,13 +138,21 @@ export default { affectedMonitorsOptions: [], showOnAllPages: false, selectedStatusPages: [], - selectedStatusPagesOptions: [], dark: (this.$root.theme === "dark"), }; }, computed: { + selectedStatusPagesOptions() { + return Object.values(this.$root.statusPageList).map(statusPage => { + return { + id: statusPage.id, + name: statusPage.title + }; + }); + }, + pageName() { return this.$t((this.isAdd) ? "Schedule Maintenance" : "Edit Maintenance"); }, @@ -177,13 +185,6 @@ export default { }); } }); - - Object.values(this.$root.statusPageList).map(statusPage => { - this.selectedStatusPagesOptions.push({ - id: statusPage.id, - name: statusPage.title - }); - }); }, methods: { init() {