From 33bb9f1ade4d4f819434fb62b01807c12bbd2799 Mon Sep 17 00:00:00 2001
From: Nelson Chan <chakflying@hotmail.com>
Date: Tue, 14 Feb 2023 07:16:18 +0800
Subject: [PATCH] Feat: Add simple validation on input

---
 src/components/TagEditDialog.vue | 43 ++++++++++++++++++++++++++++++--
 src/components/settings/Tags.vue |  2 +-
 2 files changed, 42 insertions(+), 3 deletions(-)

diff --git a/src/components/TagEditDialog.vue b/src/components/TagEditDialog.vue
index b77e1286f..795589947 100644
--- a/src/components/TagEditDialog.vue
+++ b/src/components/TagEditDialog.vue
@@ -12,7 +12,17 @@
                     <div class="modal-body">
                         <div class="mb-3">
                             <label for="tag-name" class="form-label">{{ $t("Name") }}</label>
-                            <input id="tag-name" v-model="tag.name" type="text" class="form-control" required>
+                            <input
+                                id="tag-name"
+                                v-model="tag.name"
+                                type="text"
+                                class="form-control"
+                                :class="{'is-invalid': nameInvalid}"
+                                required
+                            >
+                            <div class="invalid-feedback">
+                                {{ $t("Tag with this name already exist.") }}
+                            </div>
                         </div>
 
                         <div class="mb-3">
@@ -112,7 +122,11 @@ export default {
         updated: {
             type: Function,
             default: () => {},
-        }
+        },
+        existingTags: {
+            type: Array,
+            default: () => [],
+        },
     },
     data() {
         return {
@@ -132,6 +146,7 @@ export default {
             removingMonitor: [],
             addingMonitor: [],
             selectedAddMonitor: null,
+            nameInvalid: false,
         };
     },
 
@@ -165,6 +180,11 @@ export default {
                 this.selectedColor.color = to;
             }
         },
+        "tag.name"(to, from) {
+            if (to != null) {
+                this.validate();
+            }
+        },
         selectedColor(to, from) {
             if (to != null) {
                 this.tag.color = to.color;
@@ -212,6 +232,20 @@ export default {
             this.addingMonitor = [];
         },
 
+        /**
+         * Check for existing tags of the same name, set invalid input
+         * @returns {boolean} True if editing tag is valid
+         */
+        validate() {
+            this.nameInvalid = false;
+            const sameName = this.existingTags.find((existingTag) => existingTag.name === this.tag.name);
+            if (sameName != null && sameName.id !== this.tag.id) {
+                this.nameInvalid = true;
+                return false;
+            }
+            return true;
+        },
+
         /**
          * Load tag information for display in the edit dialog
          * @param {Object} tag tag object to edit
@@ -243,6 +277,11 @@ export default {
             this.processing = true;
             let editResult = true;
 
+            if (!this.validate()) {
+                this.processing = false;
+                return;
+            }
+
             if (this.tag.id == null) {
                 await this.addTagAsync(this.tag).then((res) => {
                     if (!res.ok) {
diff --git a/src/components/settings/Tags.vue b/src/components/settings/Tags.vue
index d54d0c49e..71ad9b7bd 100644
--- a/src/components/settings/Tags.vue
+++ b/src/components/settings/Tags.vue
@@ -23,7 +23,7 @@
             </div>
         </div>
 
-        <TagEditDialog ref="tagEditDialog" :updated="tagsUpdated" />
+        <TagEditDialog ref="tagEditDialog" :updated="tagsUpdated" :existing-tags="tagsList" />
         <Confirm ref="confirmDelete" btn-style="btn-danger" :yes-text="$t('Yes')" :no-text="$t('No')" @yes="deleteTag">
             {{ $t("confirmDeleteTagMsg") }}
         </Confirm>