Infra-Mirrors/ots
1
0
Fork 0
mirror of https://github.com/Luzifer/ots.git synced 2024-12-19 20:44:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Return 404 on not existent secret

Browse Source 
Signed-off-by: Knut Ahlers <knut@ahlers.me>
This commit is contained in:
Knut Ahlers 2017-08-03 18:18:05 +02:00
parent 9c81f9223f
commit bcef1a1cce
No known key found for this signature in database
GPG Key ID: DC2729FDD34BE99E
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api.go
View File

@ -60,7 +60,11 @@ func (a apiServer) handleRead(res http.ResponseWriter, r *http.Request) {
secret, err := a.store.ReadAndDestroy(id) secret, err := a.store.ReadAndDestroy(id)
if err != nil { if err != nil {
a.jsonResponse(res, http.StatusInternalServerError, map[string]interface{}{ status := http.StatusInternalServerError
if err == errSecretNotFound {
status = http.StatusNotFound
}
a.jsonResponse(res, status, map[string]interface{}{
"success": false, "success": false,
"error": err.Error(), "error": err.Error(),
}) })

4
storage_redis.go
View File

@ -49,6 +49,10 @@ func (s storageRedis) ReadAndDestroy(id string) (string, error) {
return "", err return "", err
} }
if secret == nil {
return "", errSecretNotFound
}
_, err = s.conn.HDel(s.redisKey(), id) _, err = s.conn.HDel(s.redisKey(), id)
return string(secret), err return string(secret), err
} }