From dae223ca0f3bab4b2527fa7df11c4cd787ea0563 Mon Sep 17 00:00:00 2001 From: Simon Lepla Date: Sun, 1 Oct 2023 12:07:41 +0200 Subject: [PATCH] Fix "unrecognized arguments" issue in DirectAdmin DNS plugin --- readme-vars.yml | 1 + root/etc/s6-overlay/s6-rc.d/init-certbot-config/run | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/readme-vars.yml b/readme-vars.yml index 2a47611..3cd4ccc 100644 --- a/readme-vars.yml +++ b/readme-vars.yml @@ -153,6 +153,7 @@ app_setup_block: | # changelog changelogs: + - { date: "01.10.23:", desc: "Fix \"unrecognized arguments\" issue in DirectAdmin DNS plugin." } - { date: "28.08.23:", desc: "Add Namecheap DNS plugin." } - { date: "12.08.23:", desc: "Add FreeDNS plugin. Detect certbot DNS authenticators using CLI." } - { date: "07.08.23:", desc: "Add Bunny DNS Configuration." } diff --git a/root/etc/s6-overlay/s6-rc.d/init-certbot-config/run b/root/etc/s6-overlay/s6-rc.d/init-certbot-config/run index 0cfd62f..d9c11fe 100755 --- a/root/etc/s6-overlay/s6-rc.d/init-certbot-config/run +++ b/root/etc/s6-overlay/s6-rc.d/init-certbot-config/run @@ -304,7 +304,7 @@ if [[ "${VALIDATION}" = "dns" ]]; then sed -i "/^dns-${DNSPLUGIN}-propagation-seconds\b/d" /config/etc/letsencrypt/cli.ini fi # plugins that use old parameter naming convention - if [[ "${DNSPLUGIN}" =~ ^(cpanel|directadmin)$ ]]; then + if [[ "${DNSPLUGIN}" =~ ^(cpanel)$ ]]; then sed -i "/^dns-${DNSPLUGIN}-credentials\b/d" /config/etc/letsencrypt/cli.ini sed -i "/^dns-${DNSPLUGIN}-propagation-seconds\b/d" /config/etc/letsencrypt/cli.ini set_ini_value "authenticator" "${DNSPLUGIN}" /config/etc/letsencrypt/cli.ini