Commit Graph

152 Commits

Author SHA1 Message Date
El RIDO
4796c7ff02
Merge pull request #807 from PrivateBin/siftleft-scan
Add Shiftleft scan
2023-08-07 20:46:43 +02:00
rugk
a22b96b7fc
style: fix typo 2023-08-07 20:02:36 +02:00
rugk
204d1756c9 refactor: redirect support questions to discussions including form + more links
Discussions apparently onyl support forms see,
so I quickly used ChatGPT to convert the Markdown file into the YAMl format
and after telling the format it seems to have done that in a good eay:
https://chat.openai.com/share/99718495-28d0-4382-ab5e-6a4a733c1ccb

(maybe GitHub introduced that after end of 2021 hehe, so the LLM could not know that)
2023-08-07 17:59:07 +00:00
rugk
8deb68c2da chore: remove old issue template 2023-08-07 17:26:26 +00:00
rugk
1a37f7b865
Update and create new issue templates for better ctageorisation
[128 of 600 issues are just questions and support and this is getting out of hand IMHO](https://github.com/PrivateBin/PrivateBin/issues?q=is%3Aissue+is%3Aopen+label%3Aquestion%2Fsupport), so I thought we need to do something while of course IMHO keeping support in some sense that is vital to an open-source project.

Anyway, this here now:
* Converts the "one and only issue template" to multiple ones with the new GitHub way, see https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/
  Note this uses mostly the templates they have, modifies them to use proper headers (sorry but I don't get why they always want to use **bold text** as headers, when you have real markdown headings) and adjusts/ports the
* We could use even more elaborate issue forms, but that  was too much for me to do now and is also beta, so maybe when they have a visual editor for that or so 😉 https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

The aim:
* is to get support requests and stuff directly sorted and tagged, so they are out the way
* is to nudge people to improve the quality of issues/reports by providing a more useful template or their use case
* is to redirect people to the appropriate resource (give me a moment)
2023-08-07 19:24:13 +02:00
El RIDO
ecf100551d document change, raise minimum PHP version to 7.3, remove branch refresh 2023-07-23 10:04:57 +02:00
El RIDO
34264cb7f5
Merge branch 'master' into php8 2022-10-26 08:24:41 +02:00
El RIDO
ba4878056b
misleading documentation 2022-10-26 05:51:36 +02:00
El RIDO
ae6248e27e
handle github actions deprecation warnings
see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2022-10-26 05:48:51 +02:00
El RIDO
7b98d7381f
allow tests to be manually triggered 2022-10-26 05:30:37 +02:00
El RIDO
b890d768d1
enable use of PHP 8.2 2022-10-25 06:53:26 +02:00
El RIDO
8c2cc18b66
Merge branch 'master' into php8 2022-07-31 08:53:52 +02:00
rugk
48bb2fdf0f
Use NodeJs v16 for tests
So 14 worked, let's try 16. (Actually noticed fedora uses v16 not 14 which makes sense if you see the support time.)
2022-07-10 00:13:47 +02:00
El RIDO
b46b4300ec
Merge pull request #955 from PrivateBin/node14
chore: run tests with NodeJS 14
2022-07-09 17:45:23 +02:00
rugk
e536db9b7e
style: run tests via npm script insread of custom command
I.e. not call mocha directly but let the script defined in package.json do it's job.
2022-07-09 17:04:28 +02:00
rugk
9a476ac34d chore: switch to proper cache file now we have it, i.e. package-lock.json
as per https://github.com/actions/setup-node#caching-global-packages-data
2022-07-09 17:00:45 +02:00
rugk
79fd33d21f
chore: run tests with NodeJS 14
I expect no stuff to break or so, so let's just try to use the current recommend LTS version. (v14 will also die at some time, but Fedora e.g. still seems to use it for now by default. Likely we may upgrade soon even more.)

Ref https://nodejs.org/en/about/releases/
2022-07-09 16:57:06 +02:00
rugk
08946d1cab Use npm ci instead of npm install for tests in CI
So it uses the package-json.lock file actually.
2022-07-09 16:48:21 +02:00
El RIDO
9b132f4054
Merge pull request #941 from PrivateBin/dependabot/github_actions/actions/checkout-3
Bump actions/checkout from 2 to 3
2022-06-10 05:04:21 +02:00
El RIDO
e052dd9d83
Merge pull request #940 from PrivateBin/dependabot/github_actions/actions/cache-3
Bump actions/cache from 2 to 3
2022-06-10 05:03:19 +02:00
dependabot[bot]
b6f35fc8ab
Bump actions/checkout from 2 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-10 03:02:26 +00:00
El RIDO
9291e57ac6
Merge pull request #939 from PrivateBin/dependabot/github_actions/github/codeql-action-2
Bump github/codeql-action from 1 to 2
2022-06-10 05:02:04 +02:00
github-actions[bot]
d7e88b236e Merge remote-tracking branch 'origin/master' into php8 2022-06-10 02:59:39 +00:00
dependabot[bot]
be23ae2874
Bump actions/cache from 2 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-10 02:59:25 +00:00
dependabot[bot]
86794be1c4
Bump github/codeql-action from 1 to 2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v1...v2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-10 02:59:19 +00:00
dependabot[bot]
48a6bf4416
Bump actions/setup-node from 2 to 3
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-10 02:59:15 +00:00
rugk
3c8c32fbcb
Add/enable Dependabot to keep dependencies up-to-date
Enabled update checking via Dependabot for
* GitHub Actions for updates or in case you are going to use that (just my default)
* PHP aka Composer

We successfully use it [for our Docker container](https://github.com/PrivateBin/docker-nginx-fpm-alpine/blob/master/.github/dependabot.yml) and IMHO that has worked quite well, so IMHO, we can also use it here now.
2022-06-09 23:42:03 +02:00
El RIDO
2ad79ebf71
add php 8.1 unit tests 2022-06-01 20:50:38 +02:00
github-actions[bot]
b73f4be25e Merge remote-tracking branch 'origin/master' into php8 2022-04-30 07:23:22 +00:00
El RIDO
2c01892ee1
bump github/codeql-action from 1 to 2 2022-04-28 19:47:28 +02:00
github-actions[bot]
abd722d0e4 Merge remote-tracking branch 'origin/master' into php8 2022-04-14 04:20:29 +00:00
El RIDO
a15b395eaf
fix php8 refresh workflow
requires updating the commit action due to
https://github.com/github-actions-x/commit/issues/30
2022-04-14 06:19:19 +02:00
El RIDO
15a9b8d826
fix php8 refresh workflow
requires updating the commit action due to
https://github.com/github-actions-x/commit/issues/30
2022-04-14 06:17:10 +02:00
El RIDO
d2126d6dd6
fix php8 refresh workflow
requires updating the commit action due to
https://github.com/github-actions-x/commit/issues/30
2022-04-14 06:08:48 +02:00
github-actions[bot]
3a801bc238 Merge remote-tracking branch 'origin/master' into php8 2021-10-30 15:26:05 +00:00
El RIDO
b80b318e38
spaces 2021-10-30 17:23:09 +02:00
rugk
1fff4bf4d7
Also set author for merge commit
Follow-up of 41898282+github-actions[bot]@users.noreply.github.com again

In contrast to your suggestion, @elrido, I did use GitHubs bot account again. The mails won't spam anyone, and it's actually intended for such stuff.
Also, we get a proper avatar on GitHub's commit messages etc., and of course we know it is actually GitHubs (servers) that do this change.
2021-10-30 16:53:42 +02:00
rugk
aa6e2f7631
Set GitHub Bot as author for PHP8 merge commits 2021-10-23 15:04:54 +02:00
rugk
af852927a9
Fix PHP refresh pipeline merge
See https://github.com/PrivateBin/PrivateBin/pull/847#issuecomment-942580850

Now merging the origin as master is not yet pulled.
2021-10-13 20:07:45 +02:00
rugk
f6421c9c7c
Fix PHP8 pipeline
As per https://github.com/PrivateBin/PrivateBin/pull/843#issuecomment-939526915

Co-Authored-By: El RIDO <elrido@gmx.net>
2021-10-11 17:45:42 +02:00
El RIDO
3f469f715f
Merge branch 'master' into php8 2021-10-07 22:17:11 +02:00
rugk
c7cd450f9b
Remove useless boilerplate comments 2021-10-06 20:19:03 +02:00
rugk
a988be7431
Add CI for automatic PHP8 updates
Adds a simple CI for pushing the master branches changes to the php8 branch.

Useful/discussed for https://github.com/PrivateBin/PrivateBin/issues/707
2021-10-06 20:13:09 +02:00
El RIDO
51a590c3c7
Merge pull request #841 from PrivateBin/ci-problem-matchers
Setup CI problem matchers for PHP
2021-10-02 20:15:22 +02:00
rugk
f4e68fcc04
style: better YAML comments 2021-10-02 01:12:08 +02:00
rugk
f43a41c117
Update tests.yml 2021-10-02 01:07:57 +02:00
rugk
ab11fbeb47
Fix syntax error
Apparently in envs the OS etc. syntax is not supported, so we need to use it like this.
2021-10-02 01:01:24 +02:00
rugk
5f4fe52eab
Use package-json instead of package-lock.json
for cache
2021-10-02 00:56:44 +02:00
rugk
b80732f8e2
Add caching for NodeJS 2021-10-02 00:55:08 +02:00
rugk
a372ee92e9
Fix wrong cache key 2021-10-02 00:43:54 +02:00
rugk
e2ae0da4e1
Style cleanup adding newlines
Seems to be the unofficial GitHub Actions YAML style and arguably makes things a lot more readable if you have a lot of steps…
2021-10-02 00:41:54 +02:00
rugk
3f7bceb862
Also cache PHP extensions
See https://github.com/shivammathur/cache-extensions#workflow
2021-10-02 00:38:21 +02:00
rugk
507a10adc5
Use composer.json instead of composer.lock
In a cache
2021-10-02 00:32:57 +02:00
rugk
a8f7840d25
Only restore cache from current date then 2021-10-02 00:29:48 +02:00
rugk
3ba6483bf3
Try caching composer stuff
Especially the GCM stuff may be quite large, so caching may be a good idea.

I tried following https://github.com/shivammathur/setup-php#cache-composer-dependencies
2021-10-02 00:27:57 +02:00
El RIDO
197c4a34e8
fix snyk 2021-06-05 08:25:19 +02:00
El RIDO
7a3a306ddc
fix snyk 2021-06-05 08:22:50 +02:00
El RIDO
cbdcaf4c30
fix snyk 2021-06-05 08:14:04 +02:00
El RIDO
371dca1986
ensure the GCS library and dependencies get included in the scan 2021-06-05 08:10:12 +02:00
rugk
79c0ad1670
Add Siftleft scan
It seems [to cover](https://slscan.io/en/latest/#supported-languages-frameworks) PHP including license check in addition to dependency scanning.
2021-06-05 00:21:48 +02:00
rugk
8bc97517fb
Add Snyk security scan for PHP
After I found https://github.com/PrivateBin/docker-nginx-fpm-alpine/pull/44 I saw they also support PHP, so let's do it here (one level before container packaging), too.
Also it complements the CodeQL analysis, which only covers the JS part.

I added the API token to the PrivateBIn org now.
2021-06-04 23:43:01 +02:00
El RIDO
93138cbbae
we already test this via the regular unit tests 2021-05-30 09:26:13 +02:00
El RIDO
fc5e380ccc
fix composer test on PHP 8 2021-05-30 09:18:56 +02:00
El RIDO
33587d54e4
fix composer test on PHP 8 2021-05-30 09:17:23 +02:00
El RIDO
b939b64778
Merge branch 'issue-794/add-gcs-support' of https://github.com/binxio/PrivateBin into binxio-issue-794/add-gcs-support 2021-05-30 07:57:58 +02:00
Mark van Holsteijn
342270d6dd added Google Cloud Storage support 2021-05-28 22:39:50 +02:00
rugk
156155663d
Create codeql-analysis.yml
Only supports JS for now.

I've removed the build step, because welł… our JS is already "built".
2021-01-26 16:37:53 +01:00
El RIDO
73e44e1aa8
workaround 2021-01-05 19:19:05 +01:00
El RIDO
2d6d0252cf
github switched to ubuntu 20.04 and it seems to default on php 8, which our current composer setup doesn't support 2021-01-05 19:16:22 +01:00
El RIDO
ec190fdcf6
phpunit 9 requires php >= 7.3 2020-10-11 10:34:03 +02:00
El RIDO
4312f77385
experimentally enable PHP 8 beta unit testing 2020-10-10 11:21:53 +02:00
El RIDO
fbefe47806
avoid the buggy windows environment 2020-05-31 15:53:57 +02:00
El RIDO
bd7ecb9c55
develop doesn't install curl extension by default 2020-05-31 15:43:59 +02:00
El RIDO
2a04ee385d
develop doesn't install DOM extension by default 2020-05-31 15:41:30 +02:00
El RIDO
3268464ada
might only be fixed in development branch 2020-05-31 15:36:13 +02:00
El RIDO
09a2c5c3b9
attempting to fix windows unit tests 2020-05-31 15:30:30 +02:00
El RIDO
51a867bc20
removing outdated configurations and fix path of phpunit 2020-05-31 15:24:10 +02:00
El RIDO
a1bac9b6e1
remove composer lock, to avoid installing incompatible dependencies 2020-05-31 15:10:30 +02:00
El RIDO
120ba0b8ca
avoid packaged phpunit version that is incompatible with older PHP releases 2020-05-31 14:45:25 +02:00
El RIDO
bd26972a73
actually run tests and set proper working directories 2020-05-31 14:42:11 +02:00
El RIDO
7cef87e856
migrating TravisCI tests to GitHub actions 2020-05-31 14:36:09 +02:00
rugk
271c954f9a
Test PHP Composer runner of GitHub
GitHub has these new CI/CD features, so let's test whether this makes sense.

I guess this PHP thing just installs the project via composer… 🤔
2020-01-26 23:25:24 +01:00
rugk
674ebbc6fb
Remove bullet point
It is just useless here.
2017-07-06 19:14:49 +02:00
rugk
0091607618
📝 Simplify isue & PR template
I saw GitHub's new TOS already address the contribution/licensing issue, so
that the checkbox is not necessary.
See https://help.github.com/articles/github-terms-of-service-draft/#5-license-grant-to-other-users
2017-02-08 09:29:31 +01:00
rugk
8619210c33
Add note for reproduction on official site
This should make sure, users try to reproduce the issue on the official domain.
2016-10-21 22:14:44 +02:00
rugk
f5813c959c
Fix typo 2016-10-12 18:59:18 +02:00
rugk
8cb1a0a14d
Improve issue template 2016-09-03 18:23:03 +02:00
rugk
2cde59821a Add FAQ note to issue template 2016-08-24 17:35:29 +02:00
rugk
7dbca9fca6 Update ISSUE_TEMPLATE.md 2016-08-10 21:31:03 +02:00
rugk
e7c2af2dc9 Add spaces for faster writing 2016-08-10 21:30:06 +02:00
rugk
15974b368f Add instructions for how to get commit hash 2016-08-10 21:29:25 +02:00
rugk
5052768911 Add webserver 2016-08-10 21:11:15 +02:00
rugk
83c12c7f04 Add auto-close info to PR template
Explain https://help.github.com/articles/closing-issues-via-commit-messages/
2016-08-10 20:38:49 +02:00
rugk
cc65b3b700 Add explicit license statement to PR template
See https://opensource.stackexchange.com/questions/4267/how-does-contributing-to-a-floss-project-work-from-a-legal-perspective/4268
2016-08-08 19:07:07 +02:00
rugk
6e7365e949 Update PULL_REQUEST_TEMPLATE.md
I should really end the sentences I am writing... 😉
2016-07-21 21:57:11 +02:00
rugk
f51bfb7265 Update PULL_REQUEST_TEMPLATE.md 2016-07-21 21:56:42 +02:00
rugk
b05404ab38 Update CONTRIBUTING.md 2016-07-19 17:58:39 +02:00
rugk
ae8e975247 Update CONTRIBUTING.md 2016-07-19 17:58:30 +02:00
rugk
5a023ba881 Create CONTRIBUTING.md 2016-07-19 17:50:50 +02:00
rugk
5fed9b4189 Update ISSUE_TEMPLATE.md 2016-07-19 17:48:06 +02:00