Infra-Mirrors/PrivateBin
1
0
Fork 0
mirror of https://github.com/PrivateBin/PrivateBin.git synced 2025-08-03 12:06:40 -04:00
Code Issues Projects Releases Packages Wiki Activity

added test for getCookie function, documenting its limitation of not finding cookies with empty identifier

Browse source
This commit is contained in:
El RIDO 2017-02-12 17:11:21 +01:00
parent b1396a249d
commit eedb05111a
No known key found for this signature in database
GPG key ID: 0F5C940A6BD81F92
4 changed files with 30 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
js/privatebin.js
View file

@ -224,7 +224,7 @@ jQuery.PrivateBin = function($, sjcl, Base64, RawDeflate) {
* @see {@link http://www.w3schools.com/js/js_cookies.asp}
* @name helper.getCookie
* @function
* @param {string} cname
* @param {string} cname - may not be empty
* @return {string}
*/
getCookie: function(cname) {

27
js/test.js
View file

@ -313,6 +313,33 @@ describe('helper', function () {
);
});
describe('getCookie', function () {
jsc.property(
'returns the requested cookie',
'nearray asciinestring',
'nearray asciistring',
function (labels, values) {
var selectedKey = '', selectedValue = '',
cookieArray = [],
count = 0;
labels.forEach(function(item, i) {
var key = item.replace(/[\s;,=]/g, 'x'),
value = (values[i] || values[0]).replace(/[\s;,=]/g, '');
cookieArray.push(key + '=' + value);
if (Math.random() < 1 / i)
{
selectedKey = key;
selectedValue = value;
}
});
var clean = jsdom('', {cookie: cookieArray}),
result = $.PrivateBin.helper.getCookie(selectedKey);
clean();
return result === selectedValue;
}
);
});
describe('scriptLocation', function () {
jsc.property(
'returns the URL without query & fragment',