diff --git a/js/test/Alert.js b/js/test/Alert.js index a6c888f4..92464ed1 100644 --- a/js/test/Alert.js +++ b/js/test/Alert.js @@ -306,10 +306,8 @@ describe('Alert', function () { $('body').addClass('loading'); $.PrivateBin.Alert.init(); $.PrivateBin.Alert.hideLoading(); - assert.ok( - !$('body').hasClass('loading') && - $('#loadingindicator').hasClass('hidden') - ); + assert.ok(!$('body').hasClass('loading')); + assert.ok($('#loadingindicator').hasClass('hidden')); } ); }); @@ -328,10 +326,8 @@ describe('Alert', function () { ); $.PrivateBin.Alert.init(); $.PrivateBin.Alert.hideMessages(); - assert.ok( - $('#status').hasClass('hidden') && - $('#errormessage').hasClass('hidden') - ); + assert.ok($('#status').hasClass('hidden')); + assert.ok($('#errormessage').hasClass('hidden')); } ); }); @@ -381,4 +377,3 @@ describe('Alert', function () { ); }); }); - diff --git a/js/test/CryptTool.js b/js/test/CryptTool.js index ed94320a..e48e0b35 100644 --- a/js/test/CryptTool.js +++ b/js/test/CryptTool.js @@ -58,9 +58,10 @@ describe('CryptTool', function () { 'foo', 'bar', cipherMessage ); clean(); - const result = (message === plaintext); - if (!result) console.log(plaintext, cipherMessage); - assert.ok(result); + if (message !== plaintext) { + console.log(plaintext, cipherMessage); + } + assert.strictEqual(message, plaintext); }); it('can en- and decrypt a particular message (#260)', function () { diff --git a/js/test/PasteStatus.js b/js/test/PasteStatus.js index f5132342..3df9511b 100644 --- a/js/test/PasteStatus.js +++ b/js/test/PasteStatus.js @@ -217,10 +217,8 @@ describe('PasteStatus', function () { ); $.PrivateBin.PasteStatus.init(); $.PrivateBin.PasteStatus.hideMessages(); - assert.ok( - $('#remainingtime').hasClass('hidden') && - $('#pastesuccess').hasClass('hidden') - ); + assert.ok($('#remainingtime').hasClass('hidden')); + assert.ok($('#pastesuccess').hasClass('hidden')); } ); }); diff --git a/js/test/TopNav.js b/js/test/TopNav.js index b1237deb..93f215b5 100644 --- a/js/test/TopNav.js +++ b/js/test/TopNav.js @@ -52,7 +52,11 @@ describe('TopNav', function () { $('#qrcodelink').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -113,7 +117,11 @@ describe('TopNav', function () { $('#attach').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -140,7 +148,11 @@ describe('TopNav', function () { !$('#newbutton').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -169,7 +181,11 @@ describe('TopNav', function () { $('#clonebutton').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -199,7 +215,11 @@ describe('TopNav', function () { $('#rawtextbutton').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -233,7 +253,11 @@ describe('TopNav', function () { $('#filewrap').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -267,7 +291,11 @@ describe('TopNav', function () { !$('#customattachment').hasClass('hidden') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -318,7 +346,11 @@ describe('TopNav', function () { ); */ clean(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -364,7 +396,11 @@ describe('TopNav', function () { !$.PrivateBin.TopNav.getOpenDiscussion() ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); @@ -403,7 +439,11 @@ describe('TopNav', function () { !$.PrivateBin.TopNav.getOpenDiscussion() ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); @@ -443,7 +483,11 @@ describe('TopNav', function () { $.PrivateBin.TopNav.getOpenDiscussion() ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -462,7 +506,7 @@ describe('TopNav', function () { '' ); $.PrivateBin.TopNav.init(); - assert.ok($.PrivateBin.TopNav.getExpiration() === '1day'); + assert.strictEqual($.PrivateBin.TopNav.getExpiration(), '1day'); cleanup(); } ); @@ -541,7 +585,11 @@ describe('TopNav', function () { files[1].name === 'busy.gif' ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -574,7 +622,11 @@ describe('TopNav', function () { !$.PrivateBin.TopNav.getBurnAfterReading() ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -607,7 +659,11 @@ describe('TopNav', function () { !$.PrivateBin.TopNav.getOpenDiscussion() ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -642,7 +698,11 @@ describe('TopNav', function () { $.PrivateBin.TopNav.getPassword() === '' ); cleanup(); - return results.every(element => element); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + return result; } ); }); @@ -676,7 +736,11 @@ describe('TopNav', function () { $.PrivateBin.TopNav.getCustomAttachment().hasClass('test') ); cleanup(); - assert.ok(results.every(element => element)); + const result = results.every(element => element); + if (!result) { + console.log(results); + } + assert.ok(result); } ); }); @@ -738,7 +802,7 @@ describe('TopNav', function () { $.PrivateBin.Helper.reset(); $.PrivateBin.TopNav.init(); $('#rawtextbutton').click(); - assert.equal($('pre').text(), sample); + assert.strictEqual($('pre').text(), sample); clean(); } ); diff --git a/js/test/emailTemplateTest.js b/js/test/emailTemplateTest.js index ce56ab8f..29380457 100644 --- a/js/test/emailTemplateTest.js +++ b/js/test/emailTemplateTest.js @@ -80,7 +80,7 @@ function stubWinOpen($element) { // Extract and decode the body from a "mailto:?body=..." URL. function extractMailtoBody(mailtoUrl) { - assert.ok(/^mailto:\?body=/.test(mailtoUrl), 'expected a mailto:?body= URL'); + assert.match(mailtoUrl, /^mailto:\?body=/, 'expected a mailto:?body= URL'); return decodeURIComponent(mailtoUrl.replace(/^mailto:\?body=/, '')); } @@ -104,8 +104,8 @@ describe('Email - mail body content (short URL vs. fallback)', function () { assert.ok(openedUrl, 'window.open should have been called'); const body = extractMailtoBody(openedUrl); - assert.ok(body.includes('https://short.example/xYz'), 'email body should include the short URL'); - assert.ok(!body.includes('undefined'), 'email body must not contain "undefined"'); + assert.match(body, /https:\/\/short\.example\/xYz/, 'email body should include the short URL'); + assert.doesNotMatch(body, /undefined/, 'email body must not contain "undefined"'); } finally { restore(); cleanup(); @@ -127,8 +127,8 @@ describe('Email - mail body content (short URL vs. fallback)', function () { assert.ok(openedUrl, 'window.open should have been called'); const body = extractMailtoBody(openedUrl); - assert.ok(body.includes(win.location.href), 'email body should include the fallback page URL'); - assert.ok(!body.includes('undefined'), 'email body must not contain "undefined"'); + assert.match(body, new RegExp(win.location.href), 'email body should include the fallback page URL'); + assert.doesNotMatch(body, /undefined/, 'email body must not contain "undefined"'); } finally { restore(); cleanup();