mirror of
https://github.com/BookStackApp/BookStack.git
synced 2024-08-26 20:22:18 +00:00
![Dan Brown](/assets/img/avatar_default.png)
* Started mass-refactoring of the current entity repos * Rewrote book tree logic - Now does two simple queries instead of one really complex one. - Extracted logic into its own class. - Remove model-level akward union field listing. - Logic now more readable than being large separate query and compilation functions. * Extracted and split book sort logic * Finished up Book controller/repo organisation * Refactored bookshelves controllers and repo parts * Fixed issues found via phpunit * Refactored Chapter controller * Updated Chapter export controller * Started Page controller/repo refactor * Refactored another chunk of PageController * Completed initial pagecontroller refactor pass * Fixed tests and continued reduction of old repos * Removed old page remove and further reduced entity repo * Removed old entity repo, split out page controller * Ran phpcbf and split out some page content methods * Tidied up some EntityProvider elements * Fixed issued caused by viewservice change
137 lines
5.6 KiB
PHP
137 lines
5.6 KiB
PHP
<?php namespace Entity;
|
|
|
|
use BookStack\Entities\Page;
|
|
use BookStack\Entities\Repos\PageRepo;
|
|
use Tests\TestCase;
|
|
|
|
class PageRevisionTest extends TestCase
|
|
{
|
|
public function test_page_revision_views_viewable()
|
|
{
|
|
$this->asEditor();
|
|
|
|
$pageRepo = app(PageRepo::class);
|
|
$page = Page::first();
|
|
$pageRepo->update($page, ['name' => 'updated page', 'html' => '<p>new content</p>', 'summary' => 'page revision testing']);
|
|
$pageRevision = $page->revisions->last();
|
|
|
|
$revisionView = $this->get($page->getUrl() . '/revisions/' . $pageRevision->id);
|
|
$revisionView->assertStatus(200);
|
|
$revisionView->assertSee('new content');
|
|
|
|
$revisionView = $this->get($page->getUrl() . '/revisions/' . $pageRevision->id . '/changes');
|
|
$revisionView->assertStatus(200);
|
|
$revisionView->assertSee('new content');
|
|
}
|
|
|
|
public function test_page_revision_restore_updates_content()
|
|
{
|
|
$this->asEditor();
|
|
|
|
$pageRepo = app(PageRepo::class);
|
|
$page = Page::first();
|
|
$pageRepo->update($page, ['name' => 'updated page abc123', 'html' => '<p>new contente def456</p>', 'summary' => 'initial page revision testing']);
|
|
$pageRepo->update($page, ['name' => 'updated page again', 'html' => '<p>new content</p>', 'summary' => 'page revision testing']);
|
|
$page = Page::find($page->id);
|
|
|
|
|
|
$pageView = $this->get($page->getUrl());
|
|
$pageView->assertDontSee('abc123');
|
|
$pageView->assertDontSee('def456');
|
|
|
|
$revToRestore = $page->revisions()->where('name', 'like', '%abc123')->first();
|
|
$restoreReq = $this->put($page->getUrl() . '/revisions/' . $revToRestore->id . '/restore');
|
|
$page = Page::find($page->id);
|
|
|
|
$restoreReq->assertStatus(302);
|
|
$restoreReq->assertRedirect($page->getUrl());
|
|
|
|
$pageView = $this->get($page->getUrl());
|
|
$pageView->assertSee('abc123');
|
|
$pageView->assertSee('def456');
|
|
}
|
|
|
|
public function test_page_revision_count_increments_on_update()
|
|
{
|
|
$page = Page::first();
|
|
$startCount = $page->revision_count;
|
|
$resp = $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
$resp->assertStatus(302);
|
|
|
|
$this->assertTrue(Page::find($page->id)->revision_count === $startCount+1);
|
|
}
|
|
|
|
public function test_revision_count_shown_in_page_meta()
|
|
{
|
|
$page = Page::first();
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
|
|
$page = Page::find($page->id);
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
|
|
$page = Page::find($page->id);
|
|
$pageView = $this->get($page->getUrl());
|
|
$pageView->assertSee('Revision #' . $page->revision_count);
|
|
}
|
|
|
|
public function test_revision_deletion() {
|
|
$page = Page::first();
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
|
|
$page = Page::find($page->id);
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
|
|
$page = Page::find($page->id);
|
|
$beforeRevisionCount = $page->revisions->count();
|
|
|
|
// Delete the first revision
|
|
$revision = $page->revisions->get(1);
|
|
$resp = $this->asEditor()->delete($revision->getUrl('/delete/'));
|
|
$resp->assertRedirect($page->getUrl('/revisions'));
|
|
|
|
$page = Page::find($page->id);
|
|
$afterRevisionCount = $page->revisions->count();
|
|
|
|
$this->assertTrue($beforeRevisionCount === ($afterRevisionCount + 1));
|
|
|
|
// Try to delete the latest revision
|
|
$beforeRevisionCount = $page->revisions->count();
|
|
$currentRevision = $page->getCurrentRevision();
|
|
$resp = $this->asEditor()->delete($currentRevision->getUrl('/delete/'));
|
|
$resp->assertRedirect($page->getUrl('/revisions'));
|
|
|
|
$page = Page::find($page->id);
|
|
$afterRevisionCount = $page->revisions->count();
|
|
$this->assertTrue($beforeRevisionCount === $afterRevisionCount);
|
|
}
|
|
|
|
public function test_revision_limit_enforced()
|
|
{
|
|
config()->set('app.revision_limit', 2);
|
|
$page = Page::first();
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
$page = Page::find($page->id);
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
for ($i = 0; $i < 10; $i++) {
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
}
|
|
|
|
$revisionCount = $page->revisions()->count();
|
|
$this->assertEquals(2, $revisionCount);
|
|
}
|
|
|
|
public function test_false_revision_limit_allows_many_revisions()
|
|
{
|
|
config()->set('app.revision_limit', false);
|
|
$page = Page::first();
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
$page = Page::find($page->id);
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
for ($i = 0; $i < 10; $i++) {
|
|
$this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
|
|
}
|
|
|
|
$revisionCount = $page->revisions()->count();
|
|
$this->assertEquals(12, $revisionCount);
|
|
}
|
|
} |