mirror of
https://github.com/BookStackApp/BookStack.git
synced 2024-10-01 01:36:00 -04:00
492af79c27
As per guidance from google's CSP evaluator.
133 lines
4.5 KiB
PHP
133 lines
4.5 KiB
PHP
<?php
|
|
|
|
namespace Tests;
|
|
|
|
use BookStack\Util\CspService;
|
|
|
|
class SecurityHeaderTest extends TestCase
|
|
{
|
|
public function test_cookies_samesite_lax_by_default()
|
|
{
|
|
$resp = $this->get('/');
|
|
foreach ($resp->headers->getCookies() as $cookie) {
|
|
$this->assertEquals('lax', $cookie->getSameSite());
|
|
}
|
|
}
|
|
|
|
public function test_cookies_samesite_none_when_iframe_hosts_set()
|
|
{
|
|
$this->runWithEnv('ALLOWED_IFRAME_HOSTS', 'http://example.com', function () {
|
|
$resp = $this->get('/');
|
|
foreach ($resp->headers->getCookies() as $cookie) {
|
|
$this->assertEquals('none', $cookie->getSameSite());
|
|
}
|
|
});
|
|
}
|
|
|
|
public function test_secure_cookies_controlled_by_app_url()
|
|
{
|
|
$this->runWithEnv('APP_URL', 'http://example.com', function () {
|
|
$resp = $this->get('/');
|
|
foreach ($resp->headers->getCookies() as $cookie) {
|
|
$this->assertFalse($cookie->isSecure());
|
|
}
|
|
});
|
|
|
|
$this->runWithEnv('APP_URL', 'https://example.com', function () {
|
|
$resp = $this->get('/');
|
|
foreach ($resp->headers->getCookies() as $cookie) {
|
|
$this->assertTrue($cookie->isSecure());
|
|
}
|
|
});
|
|
}
|
|
|
|
public function test_iframe_csp_self_only_by_default()
|
|
{
|
|
$resp = $this->get('/');
|
|
$frameHeader = $this->getCspHeader($resp, 'frame-ancestors');
|
|
|
|
$this->assertEquals('frame-ancestors \'self\'', $frameHeader);
|
|
}
|
|
|
|
public function test_iframe_csp_includes_extra_hosts_if_configured()
|
|
{
|
|
$this->runWithEnv('ALLOWED_IFRAME_HOSTS', 'https://a.example.com https://b.example.com', function () {
|
|
$resp = $this->get('/');
|
|
$frameHeader = $this->getCspHeader($resp, 'frame-ancestors');
|
|
|
|
$this->assertNotEmpty($frameHeader);
|
|
$this->assertEquals('frame-ancestors \'self\' https://a.example.com https://b.example.com', $frameHeader);
|
|
});
|
|
}
|
|
|
|
public function test_script_csp_set_on_responses()
|
|
{
|
|
$resp = $this->get('/');
|
|
$scriptHeader = $this->getCspHeader($resp, 'script-src');
|
|
$this->assertStringContainsString('\'strict-dynamic\'', $scriptHeader);
|
|
$this->assertStringContainsString('\'nonce-', $scriptHeader);
|
|
}
|
|
|
|
public function test_script_csp_nonce_matches_nonce_used_in_custom_head()
|
|
{
|
|
$this->setSettings(['app-custom-head' => '<script>console.log("cat");</script>']);
|
|
$resp = $this->get('/login');
|
|
$scriptHeader = $this->getCspHeader($resp, 'script-src');
|
|
|
|
$nonce = app()->make(CspService::class)->getNonce();
|
|
$this->assertStringContainsString('nonce-' . $nonce, $scriptHeader);
|
|
$resp->assertSee('<script nonce="' . $nonce . '">console.log("cat");</script>');
|
|
}
|
|
|
|
public function test_script_csp_nonce_changes_per_request()
|
|
{
|
|
$resp = $this->get('/');
|
|
$firstHeader = $this->getCspHeader($resp, 'script-src');
|
|
|
|
$this->refreshApplication();
|
|
|
|
$resp = $this->get('/');
|
|
$secondHeader = $this->getCspHeader($resp, 'script-src');
|
|
|
|
$this->assertNotEquals($firstHeader, $secondHeader);
|
|
}
|
|
|
|
public function test_allow_content_scripts_settings_controls_csp_script_headers()
|
|
{
|
|
config()->set('app.allow_content_scripts', true);
|
|
$resp = $this->get('/');
|
|
$scriptHeader = $this->getCspHeader($resp, 'script-src');
|
|
$this->assertEmpty($scriptHeader);
|
|
|
|
config()->set('app.allow_content_scripts', false);
|
|
$resp = $this->get('/');
|
|
$scriptHeader = $this->getCspHeader($resp, 'script-src');
|
|
$this->assertNotEmpty($scriptHeader);
|
|
}
|
|
|
|
public function test_object_src_csp_header_set()
|
|
{
|
|
$resp = $this->get('/');
|
|
$scriptHeader = $this->getCspHeader($resp, 'object-src');
|
|
$this->assertEquals('object-src \'self\'', $scriptHeader);
|
|
}
|
|
|
|
public function test_base_uri_csp_header_set()
|
|
{
|
|
$resp = $this->get('/');
|
|
$scriptHeader = $this->getCspHeader($resp, 'base-uri');
|
|
$this->assertEquals('base-uri \'self\'', $scriptHeader);
|
|
}
|
|
|
|
/**
|
|
* Get the value of the first CSP header of the given type.
|
|
*/
|
|
protected function getCspHeader(TestResponse $resp, string $type): string
|
|
{
|
|
$cspHeaders = collect($resp->headers->all('Content-Security-Policy'));
|
|
return $cspHeaders->filter(function ($val) use ($type) {
|
|
return strpos($val, $type) === 0;
|
|
})->first() ?? '';
|
|
}
|
|
}
|