Dan Brown
0de4d6d223
Improved WYSIWYG code block behaviour via range of fixes
...
- Fixed issues with new code blocks breaking or acting odd due to
misnamed contenteditable attribute.
- Helped fix issue where code blocks may show in a strage blank state
due to timing within shadow dom loading.
- Fixed some function timing issues where some functions required their
async predecessor to have finished.
Tested rather heavily in firefox and brave.
Fixes #3292
2022-02-27 17:21:24 +00:00
Dan Brown
06f694bad2
Updated tinymce link query to break caches
...
Fixes #3293
2022-02-27 16:03:18 +00:00
Dan Brown
41689a1e65
New Crowdin updates ( #3259 )
2022-02-26 11:46:33 +00:00
Dan Brown
1e112f78d8
On WYSIWYG details unwrap, provided better restore of cursor
...
Also prevents the toolbar from sticking around after the details block
was removed.
2022-02-24 15:02:23 +00:00
Dan Brown
2b3726702d
Revamped workings of WYSIWYG code blocks
...
Code blocks in tinymce could sometimes end up exploded into the sub
elements of the codemirror display.
This changes the strategy to render codemirror within the shadow dom of
a custom element while preserving the normal pre/code DOM structure.
Still a little instability when moving/adding code blocks within details
blocks but much harder to break things now.
2022-02-09 19:24:27 +00:00
Dan Brown
536ad14276
WYSIWYG details: Improved usage reliability and dark mdoe styles
2022-02-09 11:25:22 +00:00
Dan Brown
a318775cfc
Improved wysiwyg details/summary edit controls
...
- Added specific non-editable/editable filtering to make editing within
box more reliable.
- Updated toolbar icons and controls.
2022-02-09 10:40:46 +00:00
Dan Brown
9e0b8a9fb6
Started support for WYSIWYG details/summary blocks
2022-02-08 23:08:00 +00:00
Dan Brown
7c692ec588
Changed editor bottom padding technique
...
- Ensures padding works across FF & Chrome, was only working on FF
before.
- Fixes sketchy editor positioning focus on FF, since tinyMCE would
add a hidden element to the bottom of the body which would remove/add
our body padding causing unstable positioning.
2022-02-08 17:05:38 +00:00
Dan Brown
da0dc7292c
Merged in editor translation strings
2022-02-08 15:57:19 +00:00
Dan Brown
c6ad16dba6
Merge branch 'tinymce' into development
2022-02-08 15:28:56 +00:00
Dan Brown
4ea1f0c633
Merge crowdin changes from users API changes
2022-02-08 15:14:18 +00:00
Dan Brown
f5077c17f4
Merge pull request #3238 from BookStackApp/users_api
...
User Management API
2022-02-08 13:32:45 +00:00
Dan Brown
1782618c64
New Crowdin updates ( #3251 )
...
* New translations activities.php (Hebrew)
* New translations auth.php (Hebrew)
* New translations common.php (Hebrew)
* New translations activities.php (Hebrew)
* New translations common.php (Hebrew)
* New translations entities.php (Hebrew)
* New translations errors.php (Hebrew)
* New translations validation.php (Spanish)
2022-02-08 13:29:16 +00:00
ististyle
a01bb92989
Update Korean translation ( #3256 )
...
* Update validation.php
* Update activities.php
* Update passwords.php
* Update common.php
* Update common.php
* Update auth.php
* Update components.php
* Add files via upload
* Update errors.php
* Update entities.php
* Update entities.php
* Update entities.php
* Update auth.php
* Update activities.php
* Update components.php
* Update components.php
* Update entities.php
* Update components.php
* Update entities.php
* Update errors.php
* Update settings.php
* Update settings.php
* Add files via upload
* Update errors.php
2022-02-08 13:29:01 +00:00
Dan Brown
a2bcf765a8
Split out codemirror JS to its own module
...
Added a cache-compatible module loading system/pattern to the codebase.
2022-02-08 11:10:01 +00:00
Dan Brown
130dc05517
Updated wysiwyg with dark mode patches
...
- To better fit in with default BookStack dark theme.
2022-02-08 10:09:17 +00:00
Dan Brown
572d8b3700
Removed unused scroll patch after testing
...
- Tested on android and ios
- Also checked on translations and removed todo.
2022-02-08 09:42:18 +00:00
Dan Brown
e0d9380055
Aligned some editor events, Changed wysiwyg custom styles loading
...
- Removed old 'editor-*-update' commands to instead use the aligned
'editor::replace' command that we already have.
- Changed the way custom styles are loaded for the WYSIWYG editor so we
don't need an API call but instead scape content from the parent page
header using comments as identifiers. Added tests to ensure comments
exist and align.
2022-02-08 01:01:37 +00:00
Dan Brown
15647a0409
Merged color and formats wysiwyg groups
2022-02-08 00:20:36 +00:00
Dan Brown
e88dbe4db3
Added license references to readme attribution
2022-02-08 00:18:29 +00:00
Dan Brown
84c501bcf4
Simplified wysiwyg toolbar with a overflow groups
2022-02-07 23:56:39 +00:00
Dan Brown
c8b6f622f4
Added help/about box to wysiwyg editor
...
- To display license info along with shortcuts.
- Extracted out plain layout from 503 error page.
- Added tests to ensure license references are as expected.
2022-02-07 23:19:04 +00:00
Dan Brown
ef211a76ae
Made WYSIWYG editor translatable
...
- Created new translation file for editor view.
- Added simple logic to format for tinymce.
- Aligned some of the custom labels we were using.
2022-02-06 21:17:08 +00:00
Dan Brown
b4e29d2b7d
New Crowdin updates ( #3225 )
2022-02-06 15:46:28 +00:00
Dan Brown
2732d8961f
Merge branch 'fix-code-block-linefeed' into development
2022-02-06 15:19:52 +00:00
Dan Brown
b2f863e1f1
WYSIWG: Improved handling of cross-block code block creation
...
- Updated code content to get specific text selection instead of using
node-based handling which could return the whole document when
multiple top-level nodes were in selection.
- Simplified how code gets applied into the page to not be node based
but use native editor methods to replace the selection. Allows
creation from half-way through a block.
Tested on chrome+Firefox on Fedora 35.
Builds upon changes in #3246 .
For #3200 .
2022-02-06 15:19:18 +00:00
Dan Brown
1df7497c09
Added missing validation.file message
...
- Included test to cover
- Also applied StyleCI fixes
Closes #3248
2022-02-06 14:48:33 +00:00
Dan Brown
921131f999
Modularised our tinymce config and plugins
...
- Split everything into specific plugin/concern files to make things
more managable. Means original component file is now simple and much
of the core config is focused in one place.
2022-02-05 23:15:58 +00:00
Dan Brown
0cde2704d0
Made further tweaks to align with current editor
...
- Ensured each of the core actions worked at a high level.
- Handled some TinyMCE API changes.
- Moved code block insert to its own button.
2022-02-05 21:20:20 +00:00
Dan Brown
db4093d523
Got TinyMCE 5 added in barely working state
...
- Some extensions & custom actions not working.
- Updated anything visual to not be breaking (Icons) and anything
functional that prevented loading.
2022-02-05 16:57:42 +00:00
julesdevops
049d6ba5b2
fix(wysiwyg): preserves line feeds in code block mode
2022-02-05 10:28:44 +01:00
Dan Brown
9e1c8ec82a
Added user-update API endpoint
...
- Required changing the docs generator to handle more complex
object-style rules. Bit of a hack for some types (password).
- Extracted core update logic to repo for sharing with API.
- Moved user update language string to align with activity/logging
system.
- Added tests to cover.
2022-02-03 16:52:28 +00:00
Dan Brown
2cd7a48044
Added users-delete API endpoint
...
- Refactored some delete checks into repo.
- Added tests to cover.
- Moved some translations to align with activity/logging system.
2022-02-03 15:12:50 +00:00
Dan Brown
033b163675
New Crowdin updates ( #3214 )
...
* New translations auth.php (Spanish)
* New translations auth.php (Estonian)
* New translations entities.php (Estonian)
* New translations common.php (French)
* New translations common.php (Indonesian)
* New translations common.php (Turkish)
* New translations common.php (Ukrainian)
* New translations common.php (Chinese Simplified)
* New translations common.php (Chinese Traditional)
* New translations common.php (Vietnamese)
* New translations common.php (Portuguese, Brazilian)
* New translations common.php (Persian)
* New translations common.php (Slovenian)
* New translations common.php (Spanish, Argentina)
* New translations common.php (Croatian)
* New translations common.php (Estonian)
* New translations common.php (Latvian)
* New translations common.php (Bosnian)
* New translations common.php (Norwegian Bokmal)
* New translations common.php (Swedish)
* New translations common.php (Slovak)
* New translations common.php (Spanish)
* New translations common.php (Hebrew)
* New translations common.php (Arabic)
* New translations common.php (Bulgarian)
* New translations common.php (Catalan)
* New translations common.php (Czech)
* New translations common.php (Danish)
* New translations common.php (German)
* New translations common.php (Hungarian)
* New translations common.php (Russian)
* New translations common.php (Italian)
* New translations common.php (Japanese)
* New translations common.php (Korean)
* New translations common.php (Lithuanian)
* New translations common.php (Dutch)
* New translations common.php (Polish)
* New translations common.php (Portuguese)
* New translations common.php (German Informal)
* New translations common.php (Spanish)
* New translations common.php (Italian)
* New translations settings.php (Italian)
* New translations common.php (Spanish, Argentina)
2022-02-01 11:48:29 +00:00
Dan Brown
6eadf3efb3
Added language select to the user create form
...
- Updated user invite to take language from user.
- Added tests to cover.
- Added page/tab title to user create view.
For #2576 and #2408
2022-01-31 22:15:21 +00:00
Dan Brown
17215431ca
Fixed default registration role display options
...
- This also allows an admin to choose not to have a default role.
- Also applied latest styleCI fixes.
For #3220
2022-01-31 14:16:56 +00:00
julesdevops
99202b3bb8
fix(503): massively simplify the 503 error view
...
This view was relying on too much app logic, which could lead to errors
when rendering it.
2022-01-29 10:56:13 +01:00
Dan Brown
aaa2205df1
Refreshed markdown cm instance layout on size change
...
Intended to fix positioning quirks caused by changing codemirror
instance size when you have lines that wrap and cause line height
changes. Often caused by editor toolbox expand/collapse.
This adds a debounced resize observer to refresh editor layout on size
change.
Also tweaks toolbox expand/collapse to more consistently set aria
attribute.
For #3186
2022-01-24 22:08:36 +00:00
Dan Brown
4aed3f8558
Patched gallery duplication on multi-image upload
...
Quick patch to clear the gallery display when getting the first page.
Duplication of the galler was occuring due to the mulitple upload events
loading the gallery mulitple times while only clearing the existing
gallery at the start of all refreshes.
A bit flashy in terms of user experience, as there will still be
mulitple load/clear events but fixes the duplication. Could be done more
elegently in future by communicating up image upload counts.
For #3160
2022-01-24 21:38:11 +00:00
Dan Brown
f18e2784be
New Crowdin updates ( #3158 )
...
* New translations activities.php (Slovak)
* New translations activities.php (Slovak)
* New translations common.php (Russian)
* New translations settings.php (Russian)
* New translations common.php (Japanese)
* New translations settings.php (Japanese)
* New translations activities.php (Persian)
* New translations auth.php (Persian)
* New translations auth.php (Persian)
* New translations entities.php (Persian)
* New translations common.php (Persian)
* New translations auth.php (Persian)
* New translations entities.php (Persian)
* New translations settings.php (Persian)
* New translations entities.php (Persian)
* New translations validation.php (Persian)
* New translations settings.php (Persian)
* New translations settings.php (Spanish, Argentina)
* New translations common.php (Spanish, Argentina)
* New translations settings.php (Spanish, Argentina)
* New translations activities.php (Spanish, Argentina)
* New translations entities.php (Spanish, Argentina)
* New translations entities.php (Persian)
* New translations settings.php (Persian)
* New translations entities.php (Persian)
* New translations errors.php (Persian)
* New translations settings.php (French)
* New translations common.php (French)
* New translations settings.php (French)
* New translations entities.php (Persian)
* New translations settings.php (Persian)
* New translations entities.php (Persian)
* New translations errors.php (Persian)
2022-01-24 20:53:36 +00:00
Dan Brown
af39ff15ac
Merge branch 'show_more_informations_on_recently_updated_pages'
2022-01-24 18:23:47 +00:00
Dan Brown
8b5747eae2
Further adjusted linked image sizes on PDF export
...
Further fixes for #3120 , Adds DOMPDF specific adjustments to prevent
full width linked images being cut-off as per last tweak.
This does not fix usage in smaller cases (tables) but tested on
master DOMPDF branch shows that will likely be fixed in next DOMPDF
upstream release.
DOMPDF fixes would break WKHTMLTOPDF presentation so system updated
to conditionally apply styles.
2022-01-24 17:24:00 +00:00
julesdevops
6db64763fe
enh(recently updated): show updatedBy and updated_at
2022-01-19 21:49:45 +01:00
Dan Brown
d3eaaf6457
New Crowdin updates ( #3148 )
...
* New translations common.php (Czech)
* New translations common.php (Chinese Simplified)
* New translations settings.php (Chinese Simplified)
* New translations errors.php (Japanese)
* New translations entities.php (Japanese)
* New translations common.php (Japanese)
* New translations settings.php (Japanese)
* New translations entities.php (Japanese)
* New translations settings.php (Japanese)
* New translations auth.php (Japanese)
* New translations common.php (Portuguese, Brazilian)
* New translations activities.php (Portuguese, Brazilian)
* New translations activities.php (Portuguese, Brazilian)
2022-01-10 18:17:28 +00:00
Dan Brown
941217d9fb
Improved loading for images with failed thumbnails
...
- A placeholder is now shown in the gallery.
- The page editors will use the original image url if the display
thumbnail is missing.
For #3142
2022-01-10 18:13:48 +00:00
Aitor Matxinea
2d0abc4164
Update auth.php
...
Fix misspelled word "As" to "Has".
2022-01-10 11:45:48 +01:00
Dan Brown
4d094331cf
New Crowdin updates ( #3117 )
...
* New translations auth.php (Bulgarian)
* New translations auth.php (Catalan)
* New translations auth.php (Czech)
* New translations auth.php (Danish)
* New translations auth.php (Hebrew)
* New translations auth.php (Swedish)
* New translations auth.php (Hungarian)
* New translations auth.php (Italian)
* New translations auth.php (Japanese)
* New translations auth.php (Korean)
* New translations auth.php (Lithuanian)
* New translations auth.php (Dutch)
* New translations auth.php (Polish)
* New translations auth.php (Russian)
* New translations auth.php (Slovak)
* New translations auth.php (Slovenian)
* New translations settings.php (Korean)
* New translations settings.php (Lithuanian)
* New translations settings.php (Portuguese, Brazilian)
* New translations settings.php (Norwegian Bokmal)
* New translations settings.php (Bosnian)
* New translations settings.php (Latvian)
* New translations settings.php (Estonian)
* New translations settings.php (Croatian)
* New translations settings.php (Spanish, Argentina)
* New translations settings.php (Persian)
* New translations settings.php (Indonesian)
* New translations settings.php (Vietnamese)
* New translations settings.php (Dutch)
* New translations settings.php (Chinese Traditional)
* New translations settings.php (Chinese Simplified)
* New translations settings.php (Turkish)
* New translations settings.php (Swedish)
* New translations settings.php (Slovenian)
* New translations settings.php (Slovak)
* New translations settings.php (Russian)
* New translations settings.php (Portuguese)
* New translations settings.php (Polish)
* New translations settings.php (German Informal)
* New translations settings.php (Spanish)
* New translations activities.php (Spanish)
* New translations auth.php (Spanish)
* New translations common.php (Spanish)
* New translations settings.php (Spanish)
* New translations auth.php (German)
* New translations passwords.php (German)
* New translations settings.php (German)
* New translations activities.php (German)
* New translations auth.php (German)
* New translations auth.php (German Informal)
* New translations common.php (German)
* New translations entities.php (German)
* New translations errors.php (German)
* New translations errors.php (German Informal)
* New translations settings.php (German)
* New translations settings.php (German Informal)
* New translations entities.php (Japanese)
* New translations entities.php (Vietnamese)
* New translations entities.php (Slovak)
* New translations entities.php (Slovenian)
* New translations entities.php (Swedish)
* New translations entities.php (Turkish)
* New translations entities.php (Chinese Simplified)
* New translations entities.php (Chinese Traditional)
* New translations entities.php (Portuguese, Brazilian)
* New translations entities.php (Polish)
* New translations entities.php (Indonesian)
* New translations entities.php (Persian)
* New translations entities.php (Croatian)
* New translations entities.php (Estonian)
* New translations entities.php (Latvian)
* New translations entities.php (Bosnian)
* New translations entities.php (Russian)
* New translations entities.php (Dutch)
* New translations entities.php (Portuguese)
* New translations entities.php (Bulgarian)
* New translations entities.php (Ukrainian)
* New translations entities.php (Spanish, Argentina)
* New translations entities.php (Norwegian Bokmal)
* New translations entities.php (French)
* New translations entities.php (Spanish)
* New translations entities.php (Arabic)
* New translations entities.php (Catalan)
* New translations entities.php (Lithuanian)
* New translations entities.php (Czech)
* New translations entities.php (Danish)
* New translations entities.php (German)
* New translations entities.php (Hebrew)
* New translations entities.php (Hungarian)
* New translations entities.php (Italian)
* New translations entities.php (Korean)
* New translations entities.php (German Informal)
* New translations entities.php (Spanish)
* New translations auth.php (Portuguese)
* New translations common.php (Portuguese)
* New translations errors.php (Portuguese)
* New translations settings.php (Portuguese)
* New translations activities.php (French)
* New translations activities.php (French)
* New translations auth.php (French)
* New translations common.php (French)
* New translations entities.php (French)
* New translations settings.php (French)
* New translations activities.php (Spanish, Argentina)
* New translations entities.php (Spanish, Argentina)
* New translations auth.php (Spanish, Argentina)
* New translations common.php (Spanish, Argentina)
* New translations activities.php (German Informal)
* New translations common.php (German Informal)
* New translations settings.php (Spanish, Argentina)
* New translations activities.php (Chinese Simplified)
* New translations activities.php (Chinese Simplified)
* New translations auth.php (Chinese Simplified)
* New translations common.php (Chinese Simplified)
* New translations entities.php (Chinese Simplified)
* New translations settings.php (Chinese Simplified)
* New translations activities.php (Estonian)
* New translations auth.php (Estonian)
* New translations common.php (Estonian)
* New translations entities.php (Chinese Simplified)
* New translations entities.php (Estonian)
* New translations settings.php (Chinese Simplified)
* New translations settings.php (Estonian)
* New translations settings.php (Estonian)
* New translations validation.php (Estonian)
* New translations auth.php (Italian)
* New translations common.php (Italian)
* New translations entities.php (Italian)
* New translations settings.php (Italian)
* New translations activities.php (Russian)
* New translations auth.php (Russian)
* New translations common.php (Russian)
* New translations activities.php (Russian)
* New translations entities.php (Russian)
* New translations settings.php (Russian)
* New translations activities.php (Japanese)
* New translations auth.php (Portuguese, Brazilian)
* New translations auth.php (Portuguese, Brazilian)
* New translations auth.php (Arabic)
* New translations activities.php (Czech)
* New translations auth.php (Czech)
* New translations activities.php (Czech)
* New translations auth.php (Czech)
* New translations common.php (Czech)
* New translations entities.php (Czech)
* New translations settings.php (Czech)
* New translations activities.php (Czech)
* New translations auth.php (Czech)
* New translations common.php (Czech)
* New translations entities.php (Czech)
* New translations settings.php (Czech)
* New translations auth.php (Czech)
* New translations entities.php (Czech)
* New translations settings.php (Czech)
* New translations auth.php (Czech)
* New translations auth.php (Czech)
* New translations activities.php (Latvian)
* New translations auth.php (Latvian)
* New translations common.php (Latvian)
* New translations entities.php (Latvian)
* New translations settings.php (Latvian)
* New translations activities.php (Latvian)
* New translations settings.php (Latvian)
* New translations activities.php (Italian)
* New translations entities.php (Italian)
* New translations activities.php (Italian)
* New translations settings.php (Italian)
* New translations common.php (Japanese)
* New translations settings.php (French)
* New translations common.php (Vietnamese)
* New translations common.php (Portuguese, Brazilian)
* New translations common.php (Indonesian)
* New translations common.php (Persian)
* New translations common.php (Croatian)
* New translations common.php (Estonian)
* New translations common.php (Latvian)
* New translations common.php (Bosnian)
* New translations common.php (German Informal)
* New translations settings.php (Spanish)
* New translations common.php (Chinese Simplified)
* New translations settings.php (Arabic)
* New translations settings.php (Bulgarian)
* New translations settings.php (Catalan)
* New translations settings.php (Czech)
* New translations settings.php (Danish)
* New translations settings.php (German)
* New translations settings.php (Hebrew)
* New translations settings.php (Hungarian)
* New translations settings.php (Italian)
* New translations settings.php (Japanese)
* New translations common.php (Chinese Traditional)
* New translations common.php (Turkish)
* New translations common.php (Portuguese)
* New translations common.php (Danish)
* New translations common.php (Ukrainian)
* New translations common.php (Spanish, Argentina)
* New translations common.php (Norwegian Bokmal)
* New translations settings.php (Ukrainian)
* New translations common.php (French)
* New translations common.php (Spanish)
* New translations common.php (Arabic)
* New translations common.php (Bulgarian)
* New translations common.php (Catalan)
* New translations common.php (Czech)
* New translations common.php (German)
* New translations common.php (Swedish)
* New translations common.php (Hebrew)
* New translations common.php (Hungarian)
* New translations common.php (Italian)
* New translations common.php (Korean)
* New translations common.php (Lithuanian)
* New translations common.php (Dutch)
* New translations common.php (Polish)
* New translations common.php (Russian)
* New translations common.php (Slovak)
* New translations common.php (Slovenian)
* New translations settings.php (Korean)
* New translations settings.php (Lithuanian)
* New translations settings.php (Portuguese, Brazilian)
* New translations settings.php (Norwegian Bokmal)
* New translations settings.php (Bosnian)
* New translations settings.php (Latvian)
* New translations settings.php (Estonian)
* New translations settings.php (Croatian)
* New translations settings.php (Spanish, Argentina)
* New translations settings.php (Persian)
* New translations settings.php (Indonesian)
* New translations settings.php (Vietnamese)
* New translations settings.php (Dutch)
* New translations settings.php (Chinese Traditional)
* New translations settings.php (Chinese Simplified)
* New translations settings.php (Turkish)
* New translations settings.php (Swedish)
* New translations settings.php (Slovenian)
* New translations settings.php (Slovak)
* New translations settings.php (Russian)
* New translations settings.php (Portuguese)
* New translations settings.php (Polish)
* New translations settings.php (German Informal)
* New translations common.php (Estonian)
* New translations entities.php (Estonian)
* New translations settings.php (Estonian)
* New translations common.php (Spanish)
* New translations settings.php (Spanish)
* New translations entities.php (French)
* New translations settings.php (French)
* New translations common.php (Chinese Simplified)
* New translations settings.php (Chinese Simplified)
* New translations common.php (Spanish, Argentina)
* New translations settings.php (Spanish, Argentina)
2022-01-06 12:02:49 +00:00
Dan Brown
819ec55b1b
Fixed code block language parsing issue
...
Language parsing of code blocks could falter on pasted code blocks due
to the lanuage being parsed with a space which would throw an error when
used as a css class.
This adds more extensive language parsing to be safer.
Fixes #3133
2022-01-04 11:54:24 +00:00
Dan Brown
dba506a20e
Added search autofocus on entity-selector-popup
...
Closes #3127
2022-01-04 11:30:44 +00:00