Dan Brown
dde38e91b5
Fixed delete role failing with no migrate role provided
...
For #4128
2023-03-25 12:08:45 +00:00
Dan Brown
723f108bd9
Aded roles API controller methods
...
Altered & updated permissions repo, and existing connected
RoleController to suit.
Also extracts in-app success notifications to auto activity system.
Tweaked tests where required.
2023-02-18 18:36:34 +00:00
Dan Brown
c724bfe4d3
Copied over work from user_permissions branch
...
Only that relevant to the additional testing work.
2023-01-21 11:08:34 +00:00
Dan Brown
bd412ddbf9
Updated test for perms. changes and fixed static issues
2022-10-12 12:12:36 +01:00
Dan Brown
1df9ec9647
Added proper entity permission removal on role deletion
...
Added test to cover.
2022-10-07 13:12:33 +01:00
Dan Brown
900e853b15
Quick run through of applying new test entity helper class
2022-09-29 22:11:16 +01:00
Dan Brown
b56f7355aa
Migrated much test entity usage via find/replace
2022-09-29 17:31:38 +01:00
Dan Brown
068a8a068c
Extracted entity testcase methods to own class
...
Also added some new fetch helper methods for future use.
2022-09-29 16:49:25 +01:00
Dan Brown
d8672944a5
Added image view access notice to role form
...
Added to clarify the role permission in scenarios where users may have
not read the docs site to understand image access control.
Related to #3688
2022-09-06 17:20:35 +01:00
Dan Brown
840a1ea011
Applied latest styleci changes
2022-07-23 15:11:06 +01:00
Dan Brown
72c8b138e1
Updated tests to use ssddanbrown/asserthtml package
...
Closes #3519
2022-07-23 15:10:18 +01:00
Dan Brown
895f656897
Split out settings view and made functional
...
- Split settings out to new views using a core shared layout.
- Extracted added language text to translation files.
- Updated settings routes to be dynamic to category.
- Added redirect for old primary settings route.
- Updated existing tests to cover settings route changes.
- Added tests to cover settings view.
- Improved contrast of settings links for dark mode.
2022-03-28 11:09:55 +01:00
Dan Brown
fc109f7e1c
Applied latest StyleCI changes
2021-12-20 17:40:27 +00:00
Dan Brown
da01913616
Added ability to copy a role
...
- Copies via loading in model on create view.
- Updated role views while editing to bring up to similar format as
that used for more modern app areas.
- Added tests to cover.
Related to #1123
2021-12-19 12:27:14 +00:00
Dan Brown
f139cded78
Laravel 8 shift squash & merge ( #3029 )
...
* Temporarily moved back config path
* Apply Laravel coding style
* Shift exception handler
* Shift HTTP kernel and middleware
* Shift service providers
* Convert options array to fluent methods
* Shift to class based routes
* Shift console routes
* Ignore temporary framework files
* Shift to class based factories
* Namespace seeders
* Shift PSR-4 autoloading
* Shift config files
* Default config files
* Shift Laravel dependencies
* Shift return type of base TestCase methods
* Shift cleanup
* Applied stylci style changes
* Reverted config files location
* Applied manual changes to Laravel 8 shift
Co-authored-by: Shift <shift@laravelshift.com>
2021-10-30 21:29:59 +01:00
Dan Brown
f77236aa38
Laravel 7.x Shift ( #3011 )
...
* Apply Laravel coding style
* Shift bindings
* Shift core files
* Shift to Throwable
* Add laravel/ui dependency
* Shift Eloquent methods
* Shift config files
* Shift Laravel dependencies
* Shift cleanup
* Shift test config and references
* Applied styleci changes
* Applied fixes post shift to laravel 7
Co-authored-by: Shift <shift@laravelshift.com>
2021-10-26 22:04:18 +01:00
Dan Brown
c08c8d7aa3
Applied styleci style changes
2021-09-18 21:21:44 +01:00
Dan Brown
6454e24657
Removed browserkit testing from project
...
Converted last bits of the roles tests and removed dependancies.
Updated other PHP dependancies at the same time.
2021-09-18 21:20:38 +01:00
Dan Brown
d74255df5d
Started updating RolesTest away from Browserkit
2021-09-18 00:33:03 +01:00
Dan Brown
09c2814dc7
Added role based MFA control
...
- Added new DB column for control and role updated create/update actions.
- Created new middleware as a start to actual enforcement logic.
- Added indicator to role list of whether MFA is enforced.
2021-07-03 13:34:48 +01:00
Dan Brown
934a833818
Apply fixes from StyleCI
2021-06-26 15:23:15 +00:00
Dan Brown
bbfb330b92
Added check of owner field for manage-permissions-own
...
This permission was still checking based on created-by.
Updated testing to specifically check the owner since the tests
were passing by the fact of matching creator and owner.
Fixes #2445
2021-01-04 18:07:39 +00:00
Dan Brown
4c580d1571
Added owners to entity creation and updated tests
2020-12-30 22:18:28 +00:00
Dan Brown
ef1b98019a
Fixed some mis-refactoring and split search service
...
Search service broken into index and runner tools.
2020-11-22 00:17:45 +00:00
Dan Brown
da37700ac2
Implemented user, api_tokem & role activity logging
...
Also refactored some role content, primarily updating the permission
controller to be RoleController since it only dealt with roles.
2020-11-20 18:53:01 +00:00
Dan Brown
5f1ee5fb0e
Removed role 'name' field from database
...
The 'name' field was really redundant and caused confusion in the
codebase, since the 'Display' name is often used and we have a
'system_name' for the admin and public role.
This fixes #2032 , Where external auth group matching has confusing
behaviour as matching was done against the display_name, if no
external_auth field is set, but only roles with a match 'name' field
would be considered.
This also fixes and error where the role users migration, on role
delete, would not actually fire due to mis-matching http body keys.
Looks like this has been an issue from the start. Added some testing to
cover. Fixes #2211 .
Also converted phpdoc to typehints in many areas of the reviewed code
during the above.
2020-08-04 14:55:01 +01:00
Dan Brown
a9f02550f0
Removed joint_permissions auto_increment id
...
Removed auto_incrementing id and set a primary key of the [role_id,
entity_type, entity_id, action] instead since this table could recieve a
lot of activity, especially when permission regeneration was automated,
leading to very high auto_increment counts which could max out the
integer limit.
Also updated some RolesTest comment endpoints to align with
recent route changes.
Should fix #2091
2020-08-04 13:02:31 +01:00
Dan Brown
f84bf8e883
Updated test files to be PSR-4 compliant
...
Closes #1924
2020-04-04 01:16:05 +01:00
Dan Brown
5491bd62a2
Fixed test failing due to redirect changes
...
- Also set APP_THEME param during testing to avoid local conflicts
2019-12-21 13:48:44 +00:00
Dan Brown
140298bd96
Updated to Laravel 5.8
2019-09-13 23:58:40 +01:00
Dan Brown
f417675b1d
Prevented normal users from changing own email
...
To address #1542
Updates to only allow email changes by users with the users-manage role
permission.
2019-08-06 21:29:42 +01:00
Dan Brown
7f3f6e65b9
Aligned item creation wording and updated shelf-book-add logic
2019-04-15 20:45:04 +01:00
Dan Brown
7cda9b026e
Updated tests to suit layout changes, Updated 404 page
...
- Also replaced 'or' usage in templates with null coalescing operator
2019-04-06 18:36:17 +01:00
Dan Brown
50e5527483
Added test to cover "users" header link in correct permission conditions
2019-01-05 15:22:47 +00:00
Dan Brown
2317bf2350
Added check for last admin on role change
...
Will show error message if last admin and admin role is removed.
Closes #1124
Also cleaned up user controller a little.
2018-12-30 16:11:58 +00:00
Dan Brown
919660678b
Re-structured the app code to be feature based rather than code type based
2018-09-25 12:30:50 +01:00
Dan Brown
b59e5942c8
Added testing coverage for Bookshelves
...
Created modified TestResponse so we can use DOM operations in new
Testcases as we move away from the BrowserKit tests.
2018-09-21 15:15:16 +01:00
Dan Brown
cdb1c7ef88
Added destination permission checking to entity move
2018-04-14 18:47:13 +01:00
Dan Brown
1a9f676416
Updated create routes to prevent slug clashes
...
Fixes #758
2018-03-25 11:34:42 +01:00
Dan Brown
621142a46e
Removed outdated translations and updated tests
2017-09-09 18:41:59 +01:00
Dan Brown
e9831a7507
Merge branch 'master' of git://github.com/Abijeet/BookStack into Abijeet-master
2017-08-01 19:24:33 +01:00
Dan Brown
4db2c274e2
Prevent empty-state actions visible without permission.
...
Fixes #411
2017-07-02 15:59:40 +01:00
Dan Brown
cbff801aec
Added test to cover f99c8ff.
...
Closes #409
2017-07-02 15:40:42 +01:00
Abijeet
574ee820a9
#47 - Fixes the issues with the test case.
2017-06-13 02:37:50 +05:30
Abijeet
7d02f77e67
#47 - Added more test cases to test the APIs and permission for comments.
2017-06-13 02:31:17 +05:30
Dan Brown
5570e858e5
Made more efficiency improvements to permission system
2017-04-30 11:38:58 +01:00
Dan Brown
33a2999a57
Namespaced tests to align with new laravel default
2017-02-04 11:58:42 +00:00
Dan Brown
6669998c10
Upgraded to Laravel 5.4
2017-01-25 19:35:40 +00:00
Dan Brown
dabf149411
Added user setting system and added user-lang option
...
Supports #115
2017-01-15 16:27:24 +00:00
Dan Brown
581c382f65
Fixed image delete permission issue
...
Also fixed missing translations and wrote tests to cover issue.
Fixes #258
2017-01-08 19:19:30 +00:00
