6 Commits

Author	SHA1	Message	Date
Dan Brown	934a833818	Apply fixes from StyleCI	2021-06-26 15:23:15 +00:00
Dan Brown	5f1ee5fb0e	Removed role 'name' field from database ... The 'name' field was really redundant and caused confusion in the codebase, since the 'Display' name is often used and we have a 'system_name' for the admin and public role. This fixes #2032, Where external auth group matching has confusing behaviour as matching was done against the display_name, if no external_auth field is set, but only roles with a match 'name' field would be considered. This also fixes and error where the role users migration, on role delete, would not actually fire due to mis-matching http body keys. Looks like this has been an issue from the start. Added some testing to cover. Fixes #2211. Also converted phpdoc to typehints in many areas of the reviewed code during the above.	2020-08-04 14:55:01 +01:00
Dan Brown	3991fbe726	Checked over and aligned registration option behavior across all auth options ... - Added tests to cover	2020-02-02 17:31:00 +00:00
Dan Brown	9bba84684f	Appeased codeclimate by extracting out external_auth_id group matching	2019-11-16 15:24:09 +00:00
Daniel Seiler	8e723f10dc	Add error messages, fix LDAP error	2019-08-07 15:31:10 +02:00
Daniel Seiler	03dbe32f99	Refactor for codestyle	2019-08-07 12:07:21 +02:00