From cc0ce7c6308985e7524c36214aa965757b4c92df Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Thu, 23 Mar 2017 22:19:14 +0000 Subject: [PATCH] Fixed bug preventing page revision restore Added regression tests to cover. Fixes #341 --- app/Repos/EntityRepo.php | 2 +- tests/Entity/PageContentTest.php | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/app/Repos/EntityRepo.php b/app/Repos/EntityRepo.php index 4db69137f..8f4b533ff 100644 --- a/app/Repos/EntityRepo.php +++ b/app/Repos/EntityRepo.php @@ -1058,7 +1058,7 @@ class EntityRepo public function restorePageRevision(Page $page, Book $book, $revisionId) { $this->savePageRevision($page); - $revision = $this->getById('page_revision', $revisionId); + $revision = $page->revisions()->where('id', '=', $revisionId)->first(); $page->fill($revision->toArray()); $page->slug = $this->findSuitableSlug('page', $page->name, $page->id, $book->id); $page->text = strip_tags($page->html); diff --git a/tests/Entity/PageContentTest.php b/tests/Entity/PageContentTest.php index 6f07b9626..6b64c2c64 100644 --- a/tests/Entity/PageContentTest.php +++ b/tests/Entity/PageContentTest.php @@ -53,4 +53,31 @@ class PageContentTest extends TestCase $revisionView->assertSee('new content'); } + public function test_page_revision_restore_updates_content() + { + $this->asEditor(); + + $entityRepo = $this->app[EntityRepo::class]; + $page = Page::first(); + $entityRepo->updatePage($page, $page->book_id, ['name' => 'updated page abc123', 'html' => '

new contente def456

', 'summary' => 'initial page revision testing']); + $entityRepo->updatePage($page, $page->book_id, ['name' => 'updated page again', 'html' => '

new content

', 'summary' => 'page revision testing']); + $page = Page::find($page->id); + + + $pageView = $this->get($page->getUrl()); + $pageView->assertDontSee('abc123'); + $pageView->assertDontSee('def456'); + + $revToRestore = $page->revisions()->where('name', 'like', '%abc123')->first(); + $restoreReq = $this->get($page->getUrl() . '/revisions/' . $revToRestore->id . '/restore'); + $page = Page::find($page->id); + + $restoreReq->assertStatus(302); + $restoreReq->assertRedirect($page->getUrl()); + + $pageView = $this->get($page->getUrl()); + $pageView->assertSee('abc123'); + $pageView->assertSee('def456'); + } + }