Infra-Mirrors/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-07-07 20:02:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed test failing from missing baseURL

Browse Source 
Also updated image upload test to delete before upload to prevent failed
tests breaking subsequent tests.
This commit is contained in:
Dan Brown 2018-01-28 13:27:41 +00:00
parent 88d09a2a3b
commit ba6eb6727a
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/BrowserKitTest.php
View File

@ -17,6 +17,12 @@ abstract class BrowserKitTest extends TestCase
private $admin;
private $editor;
/**
* The base URL to use while testing the application.
* @var string
*/
protected $baseUrl = 'http://localhost';
public function tearDown()
{
\DB::disconnect();

12
tests/ImageTest.php
View File

@ -5,7 +5,6 @@ use BookStack\Page;
class ImageTest extends TestCase
{
/**
* Get the path to our basic test image.
* @return string
@ -54,20 +53,25 @@ class ImageTest extends TestCase
*/
protected function deleteImage($relPath)
{
unlink(public_path($relPath));
$path = public_path($relPath);
if (file_exists($path)) {
unlink($path);
}
}
public function test_image_upload()
{
$page = Page::first();
$this->asAdmin();
$admin = $this->getAdmin();
$this->actingAs($admin);
$imageName = 'first-image.png';
$relPath = $this->getTestImagePath('gallery', $imageName);
$this->deleteImage($relPath);
$upload = $this->uploadImage($imageName, $page->id);
$upload->assertStatus(200);
$relPath = $this->getTestImagePath('gallery', $imageName);
$this->assertTrue(file_exists(public_path($relPath)), 'Uploaded image not found at path: '. public_path($relPath));