Infra-Mirrors/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-10-01 01:36:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Amended search to not break on non-alpha-num chars

Browse Source 
And also fixed exact term matches that contain non-alpha-num chars
Fixes #212
This commit is contained in:
Dan Brown 2016-10-30 12:07:11 +00:00
parent c4eed37d8e
commit b251671e3f
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
1 changed files with 32 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
app/Entity.php
View File

@ -160,26 +160,28 @@ class Entity extends Ownable
public function fullTextSearchQuery($fieldsToSearch, $terms, $wheres = []) public function fullTextSearchQuery($fieldsToSearch, $terms, $wheres = [])
{ {
$exactTerms = []; $exactTerms = [];
if (count($terms) === 0) { $fuzzyTerms = [];
$search = $this; $search = static::newQuery();
$orderBy = 'updated_at';
} else {
foreach ($terms as $key => $term) { foreach ($terms as $key => $term) {
$term = htmlentities($term, ENT_QUOTES); $safeTerm = htmlentities($term, ENT_QUOTES);
$term = preg_replace('/[+\-><\(\)~*\"@]+/', ' ', $term); $safeTerm = preg_replace('/[+\-><\(\)~*\"@]+/', ' ', $safeTerm);
if (preg_match('/&quot;.*?&quot;/', $term)) { if (preg_match('/&quot;.*?&quot;/', $safeTerm) || is_numeric($safeTerm)) {
$term = str_replace('&quot;', '', $term); $safeTerm = preg_replace('/^"(.*?)"$/', '$1', $term);
$exactTerms[] = '%' . $term . '%'; $exactTerms[] = '%' . $safeTerm . '%';
$term = '"' . $term . '"';
} else { } else {
$term = '' . $term . '*'; $safeTerm = '' . $safeTerm . '*';
if (trim($safeTerm) !== '*') $fuzzyTerms[] = $safeTerm;
} }
if ($term !== '*') $terms[$key] = $term;
} }
$termString = implode(' ', $terms); $isFuzzy = count($exactTerms) === 0 || count($fuzzyTerms) > 0;
// Perform fulltext search if relevant terms exist.
if ($isFuzzy) {
$termString = implode(' ', $fuzzyTerms);
$fields = implode(',', $fieldsToSearch); $fields = implode(',', $fieldsToSearch);
$search = static::selectRaw('*, MATCH(name) AGAINST(? IN BOOLEAN MODE) AS title_relevance', [$termString]); $search = $search->selectRaw('*, MATCH(name) AGAINST(? IN BOOLEAN MODE) AS title_relevance', [$termString]);
$search = $search->whereRaw('MATCH(' . $fields . ') AGAINST(? IN BOOLEAN MODE)', [$termString]); $search = $search->whereRaw('MATCH(' . $fields . ') AGAINST(? IN BOOLEAN MODE)', [$termString]);
}
// Ensure at least one exact term matches if in search // Ensure at least one exact term matches if in search
if (count($exactTerms) > 0) { if (count($exactTerms) > 0) {
@ -191,13 +193,13 @@ class Entity extends Ownable
} }
}); });
} }
$orderBy = 'title_relevance'; $orderBy = $isFuzzy ? 'title_relevance' : 'updated_at';
};
// Add additional where terms // Add additional where terms
foreach ($wheres as $whereTerm) { foreach ($wheres as $whereTerm) {
$search->where($whereTerm[0], $whereTerm[1], $whereTerm[2]); $search->where($whereTerm[0], $whereTerm[1], $whereTerm[2]);
} }
// Load in relations // Load in relations
if ($this->isA('page')) { if ($this->isA('page')) {
$search = $search->with('book', 'chapter', 'createdBy', 'updatedBy'); $search = $search->with('book', 'chapter', 'createdBy', 'updatedBy');